Skip to content

Commit 5d6a816

Browse files
authored
Merge pull request #1704 from seleniumbase/refactoring-and-other-updates
Refactoring and other updates
2 parents bed5943 + 5d29fce commit 5d6a816

27 files changed

+140
-238
lines changed

examples/coffee_cart_tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
"""Use SeleniumBase to test a Coffee Cart App."""
1+
"""Use SeleniumBase to test the Coffee Cart App."""
22
from seleniumbase import BaseCase
33
BaseCase.main(__name__, __file__)
44

examples/edge_test.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1-
"""
2-
This test is only for Microsoft Edge (Chromium)!
3-
(Tested on Edge Version 96.0.1054.62)
4-
"""
1+
"""This test is only for Microsoft Edge (Chromium)!"""
52
from seleniumbase import BaseCase
63

4+
if __name__ == "__main__":
5+
from pytest import main
6+
main([__file__, "--edge", "-s"])
7+
78

89
class EdgeTests(BaseCase):
910
def test_edge(self):
@@ -13,7 +14,7 @@ def test_edge(self):
1314
print(' (Run this test using "--edge" or "--browser=edge")')
1415
self.skip('Use "--edge" or "--browser=edge"')
1516
if self.headless:
16-
self.open_if_not_url("about:blank")
17+
self.open("data:,")
1718
print("\n This test is NOT designed for Headless Mode!")
1819
self.skip('Do NOT use "--headless" with this test!')
1920
self.open("edge://settings/help")

examples/github_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
class GitHubTests(BaseCase):
66
def test_github(self):
77
if self.headless or self.page_load_strategy == "none":
8-
self.open_if_not_url("about:blank")
8+
self.open_if_not_url("data:,")
99
message = "Unsupported mode for this test."
1010
print("\n " + message)
1111
self.skip(message)

examples/old_wordle_script.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
1-
"""
2-
Solve the Wordle game using SeleniumBase.
3-
This test runs on archived versions of Wordle, containing Shadow-DOM.
4-
"""
5-
1+
"""Solve the Wordle game using SeleniumBase.
2+
This test runs on archived versions of Wordle, containing Shadow-DOM."""
63
import ast
74
import random
85
import requests
96
from seleniumbase import version_tuple
107
from seleniumbase import BaseCase
118

9+
if __name__ == "__main__":
10+
from pytest import main
11+
main([__file__, "--sjw", "--pls=none"])
12+
1213

1314
class WordleTests(BaseCase):
1415

examples/parameterized_test.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,3 @@ def test_parameterized_google_search(self, search_key, expected_text, img):
1818
self.assert_text(expected_text, "#search")
1919
self.click('a:contains("%s")' % expected_text)
2020
self.assert_element(img)
21-
if "SeleniumBase" in search_key:
22-
self.click('img[alt="SeleniumBase"]')
23-
self.assert_element('img[title="SeleniumBase"]')

examples/setup.cfg

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,3 @@ logging-level=INFO
1313
[behave]
1414
show_skipped=false
1515
show_timings=false
16-
17-
[bdist_wheel]
18-
universal=1

examples/test_agent.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,18 @@ def test_user_agent(self):
99
original_user_agent = user_agent_detected
1010
if not self.user_agent:
1111
# Using the built-in user-agent string
12-
self._print("\n\nUser-Agent: %s" % user_agent_detected)
12+
print("\n\nUser-Agent: %s" % user_agent_detected)
1313
else:
1414
# User-agent was overridden using: --agent=STRING
15-
self._print("\n\nUser-Agent override: %s" % user_agent_detected)
15+
print("\n\nUser-Agent override: %s" % user_agent_detected)
1616
print("\n" + self.get_text(".ip-address p"))
1717
if not (self.headless or self.headless2 or self.xvfb):
1818
self.sleep(3)
1919

2020
# Now change the user-agent using "execute_cdp_cmd()"
2121
if not self.is_chromium():
2222
msg = "\n* execute_cdp_cmd() is only for Chromium browsers"
23-
self._print(msg)
23+
print(msg)
2424
self.skip(msg)
2525
print("\n--------------------------")
2626
try:
@@ -35,7 +35,7 @@ def test_user_agent(self):
3535
)
3636
self.open("http://whatsmyuseragent.org/")
3737
user_agent_detected = self.get_text(".user-agent p")
38-
self._print("\nUser-Agent override: %s" % user_agent_detected)
38+
print("\nUser-Agent override: %s" % user_agent_detected)
3939
print("\n" + self.get_text(".ip-address p") + "\n")
4040
if not (self.headless or self.headless2 or self.xvfb):
4141
self.sleep(3)

examples/test_apple_site.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from seleniumbase import BaseCase
2+
BaseCase.main(__name__, __file__)
23

34

45
class AppleTests(BaseCase):
@@ -9,9 +10,11 @@ def test_apple_developer_site_webdriver_instructions(self):
910
self.message_duration = 2.0
1011
if self.headless:
1112
if self._multithreaded:
13+
self.open("data:,")
1214
print("Skipping test in headless multi-threaded mode.")
1315
self.skip("Skipping test in headless multi-threaded mode.")
1416
elif self.undetectable:
17+
self.open("data:,")
1518
print("Skipping test in headless undetectable mode.")
1619
self.skip("Skipping test in headless undetectable mode.")
1720
elif self.browser == "chrome" or self.browser == "edge":

examples/test_chinese_pdf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ def test_chinese_pdf(self):
99

1010
# Get and print PDF text
1111
pdf_text = self.get_pdf_text(pdf, page=2)
12-
self._print("\n" + pdf_text)
12+
print("\n" + pdf_text)
1313

1414
# Assert PDF contains the expected text on Page 2
1515
self.assert_pdf_text(pdf, "个测试类", page=2)

examples/test_demo_site.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from seleniumbase import BaseCase
2+
BaseCase.main(__name__, __file__)
23

34

45
class DemoSiteTests(BaseCase):
@@ -115,8 +116,3 @@ def test_demo_site(self):
115116
self.demo_mode = True
116117
self.type("input", "Have a Nice Day!")
117118
self.assert_text("SeleniumBase", "h2")
118-
119-
120-
if __name__ == "__main__":
121-
from pytest import main
122-
main([__file__, "-s"])

0 commit comments

Comments
 (0)