Skip to content

Commit 5fccb54

Browse files
committed
Refactor timing
1 parent c2f4dad commit 5fccb54

File tree

1 file changed

+10
-21
lines changed

1 file changed

+10
-21
lines changed

seleniumbase/fixtures/base_case.py

Lines changed: 10 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -221,9 +221,7 @@ def open(self, url):
221221
self.__check_scope()
222222
self._check_browser()
223223
if self.__needs_minimum_wait():
224-
time.sleep(0.03)
225-
if self.undetectable:
226-
time.sleep(0.02)
224+
time.sleep(0.04)
227225
pre_action_url = None
228226
try:
229227
pre_action_url = self.driver.current_url
@@ -320,22 +318,15 @@ def open(self, url):
320318
else:
321319
raise
322320
if (
323-
self.undetectable
324-
or (
325-
self.driver.current_url == pre_action_url
326-
and pre_action_url != url
327-
)
321+
self.driver.current_url == pre_action_url
322+
and pre_action_url != url
328323
):
329324
time.sleep(0.1) # Make sure load happens
330325
if settings.WAIT_FOR_RSC_ON_PAGE_LOADS:
331326
if not self.undetectable:
332327
self.wait_for_ready_state_complete()
333-
else:
334-
time.sleep(0.15)
335328
if self.__needs_minimum_wait():
336-
time.sleep(0.07) # Force a minimum wait, even if skipping waits.
337-
if self.undetectable:
338-
time.sleep(0.02)
329+
time.sleep(0.08) # Force a minimum wait, even if skipping waits.
339330
if self.undetectable:
340331
self.__uc_frame_layer = 0
341332
if self.demo_mode:
@@ -395,7 +386,7 @@ def click(
395386
self.__shadow_click(selector, timeout)
396387
return
397388
if self.__needs_minimum_wait() or self.browser == "safari":
398-
time.sleep(0.04)
389+
time.sleep(0.05)
399390
element = page_actions.wait_for_element_visible(
400391
self.driver,
401392
selector,
@@ -632,20 +623,20 @@ def click(
632623
except Exception:
633624
pass
634625
if self.__needs_minimum_wait() or self.browser == "safari":
635-
time.sleep(0.04)
626+
time.sleep(0.05)
636627
try:
637628
if self.driver.current_url != pre_action_url:
638629
self.__ad_block_as_needed()
639630
self.__disable_beforeunload_as_needed()
640631
if self.__needs_minimum_wait():
641-
time.sleep(0.04)
632+
time.sleep(0.05)
642633
except Exception:
643634
try:
644635
self.wait_for_ready_state_complete()
645636
except Exception:
646637
pass
647638
if self.__needs_minimum_wait():
648-
time.sleep(0.03)
639+
time.sleep(0.04)
649640
else:
650641
time.sleep(0.08)
651642
if self.demo_mode:
@@ -907,7 +898,7 @@ def update_text(
907898
if not self.demo_mode and not self.slow_mode:
908899
self.__scroll_to_element(element, selector, by)
909900
if self.__needs_minimum_wait():
910-
time.sleep(0.01)
901+
time.sleep(0.02)
911902
try:
912903
element.clear() # May need https://stackoverflow.com/a/50691625
913904
backspaces = Keys.BACK_SPACE * 42 # Is the answer to everything
@@ -952,9 +943,7 @@ def update_text(
952943
if settings.WAIT_FOR_RSC_ON_PAGE_LOADS:
953944
self.wait_for_ready_state_complete()
954945
if self.__needs_minimum_wait():
955-
time.sleep(0.03)
956-
if self.undetectable:
957-
time.sleep(0.025)
946+
time.sleep(0.04)
958947
except Exception:
959948
self.wait_for_ready_state_complete()
960949
time.sleep(0.14)

0 commit comments

Comments
 (0)