Merge pull request #1411 from seleniumbase/reliability-updates-for-firefox-and-js-click

Reliability updates for Firefox and js_click()

Author: mdmintz

README.md

@@ -5,7 +5,7 @@
 <meta property="og:image" content="https://seleniumbase.io/cdn/img/mac_sb_logo_5.png" />
 <link rel="icon" href="https://seleniumbase.io/img/green_logo2.png" />
 
-<p align="center"><a href="https://github.com/seleniumbase/SeleniumBase/"><img src="https://seleniumbase.io/cdn/img/sb_media_logo_5.png" alt="SeleniumBase" title="SeleniumBase" width="300" /></a></p>
+<p align="center"><a href="https://github.com/seleniumbase/SeleniumBase/"><img src="https://seleniumbase.io/cdn/img/mac_sb_logo_5b.png" alt="SeleniumBase" title="SeleniumBase" width="320" /></a></p>
 <p align="center"><b>Powerful end-to-end testing with <a href="https://www.selenium.dev/documentation/">Selenium</a>, <a href="https://www.python.org/about/">Python</a>, and <a href="https://docs.pytest.org/en/latest/how-to/usage.html">pytest</a>.</b></p>
 
 <p align="center"><a href="https://pypi.python.org/pypi/seleniumbase" target="_blank"><img src="https://img.shields.io/pypi/v/seleniumbase.svg?color=3399EE" alt="PyPI version" /></a> <a href="https://github.com/seleniumbase/SeleniumBase/releases" target="_blank"><img src="https://img.shields.io/github/v/release/seleniumbase/SeleniumBase.svg?color=22AAEE" alt="GitHub version" /></a> <a href="https://seleniumbase.io"><img src="https://img.shields.io/badge/docs-seleniumbase.io-11BBAA.svg" alt="SeleniumBase Docs" /></a> <a href="https://github.com/seleniumbase/SeleniumBase/actions" target="_blank"><img src="https://github.com/seleniumbase/SeleniumBase/workflows/CI%20build/badge.svg" alt="SeleniumBase GitHub Actions" /></a> <a href="https://gitter.im/seleniumbase/SeleniumBase" target="_blank"><img src="https://badges.gitter.im/seleniumbase/SeleniumBase.svg" alt="SeleniumBase" /></a></p>
@@ -16,7 +16,7 @@
 <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/examples/ReadMe.md">✅ Examples</a> |
 <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/customizing_test_runs.md">🎛️ Options</a> |
 <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/seleniumbase/console_scripts/ReadMe.md">🔮 Scripts</a> |
-<a href="https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/mobile_testing.md">📱 Mobile</a>
+<a href="https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/mobile_testing.md">📱 Phone</a>
 <br />
 <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/method_summary.md">📙 APIs</a> |
 <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/help_docs/syntax_formats.md">📝 Formats</a> |
@@ -43,9 +43,7 @@
 
 --------
 
-<a href="https://github.com/seleniumbase/SeleniumBase/"><img src="https://seleniumbase.io/cdn/img/sb_text_f.png" alt="SeleniumBase" title="SeleniumBase" width="260" /></a>
-
-<p align="left">✅ An example of running a test with <b>pytest</b>: <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/examples/test_demo_site.py">test_demo_site.py</a></p>
+<p align="left"><img src="https://seleniumbase.io/img/green_logo2.png" title="SeleniumBase" width="22" /> An example of running a test with <b>pytest</b>: <a href="https://github.com/seleniumbase/SeleniumBase/blob/master/examples/test_demo_site.py">test_demo_site.py</a></p>
 
 ```bash
 cd examples/

requirements.txt

@@ -5,7 +5,7 @@ packaging>=20.9;python_version<"3.6"
 packaging>=21.3;python_version>="3.6"
 setuptools>=44.1.1;python_version<"3.6"
 setuptools>=59.6.0;python_version>="3.6" and python_version<"3.7"
-setuptools>=63.1.0;python_version>="3.7"
+setuptools>=63.2.0;python_version>="3.7"
 tomli>=1.2.3;python_version>="3.6" and python_version<"3.7"
 tomli>=2.0.1;python_version>="3.7"
 wheel>=0.37.1

seleniumbase/__version__.py

@@ -1,2 +1,2 @@
 # seleniumbase package
-__version__ = "3.5.2"
+__version__ = "3.5.3"

seleniumbase/core/browser_launcher.py

@@ -538,10 +538,8 @@ def _set_firefox_options(
     options.set_preference("pdfjs.disabled", True)
     options.set_preference("app.update.auto", False)
     options.set_preference("app.update.enabled", False)
-    options.set_preference("app.update.silent", True)
     options.set_preference("browser.formfill.enable", False)
-    options.set_preference("browser.privatebrowsing.autostart", False)
-    options.set_preference("devtools.errorconsole.enabled", True)
+    options.set_preference("browser.privatebrowsing.autostart", True)
     options.set_preference("dom.webnotifications.enabled", False)
     options.set_preference("dom.disable_beforeunload", True)
     options.set_preference("browser.contentblocking.database.enabled", True)
@@ -550,7 +548,6 @@ def _set_firefox_options(
     options.set_preference("extensions.systemAddon.update.enabled", False)
     options.set_preference("extensions.update.autoUpdateDefault", False)
     options.set_preference("extensions.update.enabled", False)
-    options.set_preference("extensions.update.silent", True)
     options.set_preference("datareporting.healthreport.service.enabled", False)
     options.set_preference("datareporting.healthreport.uploadEnabled", False)
     options.set_preference("datareporting.policy.dataSubmissionEnabled", False)
@@ -1514,7 +1511,11 @@ def get_local_driver(
                         options=firefox_options,
                     )
                 except Exception as e:
-                    if "Process unexpectedly closed" in e.msg:
+                    if (
+                        "Process unexpectedly closed" in e.msg
+                        or "Failed to read marionette port" in e.msg
+                        or "A connection attempt failed" in e.msg
+                    ):
                         # Firefox probably just auto-updated itself.
                         # Trying again right after that often works.
                         return webdriver.Firefox(
@@ -1532,9 +1533,24 @@ def get_local_driver(
         else:
             if selenium4:
                 service = FirefoxService(log_path=os.path.devnull)
-                return webdriver.Firefox(
-                    service=service, options=firefox_options
-                )
+                try:
+                    return webdriver.Firefox(
+                        service=service, options=firefox_options
+                    )
+                except Exception as e:
+                    if (
+                        "Process unexpectedly closed" in e.msg
+                        or "Failed to read marionette port" in e.msg
+                        or "A connection attempt failed" in e.msg
+                    ):
+                        # Firefox probably just auto-updated itself.
+                        # Trying again right after that often works.
+                        return webdriver.Firefox(
+                            service=service,
+                            options=firefox_options,
+                        )
+                    else:
+                        raise Exception(e.msg)  # Not an obvious fix.
             else:
                 return webdriver.Firefox(
                     service_log_path=os.path.devnull,

seleniumbase/fixtures/base_case.py

@@ -5016,7 +5016,9 @@ def js_click(
         element = self.wait_for_element_present(
             selector, by=by, timeout=settings.SMALL_TIMEOUT
         )
+        scroll_done = False
         if self.is_element_visible(selector, by=by):
+            scroll_done = True
             self.__demo_mode_highlight_if_active(selector, by)
             if scroll and not self.demo_mode and not self.slow_mode:
                 success = js_utils.scroll_to_element(self.driver, element)
@@ -5050,6 +5052,16 @@ def js_click(
             action = ["js_cl", selector, href_origin, time_stamp]
             if all_matches:
                 action[0] = "js_ca"
+        if not self.is_element_visible(selector, by=by):
+            self.wait_for_ready_state_complete()
+            if self.is_element_visible(selector, by=by):
+                if scroll and not scroll_done:
+                    success = js_utils.scroll_to_element(self.driver, element)
+                    if not success:
+                        timeout = settings.SMALL_TIMEOUT
+                        element = page_actions.wait_for_element_present(
+                            self.driver, selector, by, timeout=timeout
+                        )
         if not all_matches:
             if ":contains\\(" not in css_selector:
                 self.__js_click(selector, by=by)
@@ -11585,7 +11597,16 @@ def __js_click(self, selector, by="css selector"):
                simulateClick(someLink);"""
             % css_selector
         )
-        self.execute_script(script)
+        try:
+            self.execute_script(script)
+        except Exception:
+            # If the regular mouse-simulated click fails, do a basic JS click
+            self.wait_for_ready_state_complete()
+            script = (
+                """document.querySelector('%s').click();"""
+                % css_selector
+            )
+            self.execute_script(script)
 
     def __js_click_all(self, selector, by="css selector"):
         """Clicks all matching elements using pure JS. (No jQuery)"""

setup.py

@@ -131,7 +131,7 @@
         'packaging>=21.3;python_version>="3.6"',
         'setuptools>=44.1.1;python_version<"3.6"',
         'setuptools>=59.6.0;python_version>="3.6" and python_version<"3.7"',
-        'setuptools>=63.1.0;python_version>="3.7"',
+        'setuptools>=63.2.0;python_version>="3.7"',
         'tomli>=1.2.3;python_version>="3.6" and python_version<"3.7"',
         'tomli>=2.0.1;python_version>="3.7"',
         "wheel>=0.37.1",