Skip to content

Commit 62b5231

Browse files
committed
Add more "exclude" options for "self.assert_no_js_errors()"
1 parent 3e110e3 commit 62b5231

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

seleniumbase/fixtures/base_case.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6548,6 +6548,8 @@ def assert_no_js_errors(self, exclude=[]):
65486548
self.assert_no_js_errors()
65496549
self.assert_no_js_errors(exclude=["/api.", "/analytics."])
65506550
self.assert_no_js_errors(exclude="//api.go,/analytics.go")
6551+
self.assert_no_js_errors(exclude=["Uncaught SyntaxError"])
6552+
self.assert_no_js_errors(exclude=["TypeError", "SyntaxE"])
65516553
"""
65526554
self.__check_scope()
65536555
if (
@@ -6581,10 +6583,6 @@ def assert_no_js_errors(self, exclude=[]):
65816583
message = message.split(
65826584
" - Failed to load resource"
65836585
)[0]
6584-
elif message.count(" Uncaught TypeError: ") == 1:
6585-
message = message.split(
6586-
" Uncaught TypeError: "
6587-
)[0]
65886586
for substring in exclude:
65896587
substring = str(substring)
65906588
if (
@@ -6598,10 +6596,15 @@ def assert_no_js_errors(self, exclude=[]):
65986596
if len(errors) > 0:
65996597
for n in range(len(errors)):
66006598
f_t_l_r = " - Failed to load resource"
6599+
u_c_s_e = " Uncaught SyntaxError: "
66016600
u_c_t_e = " Uncaught TypeError: "
66026601
if f_t_l_r in errors[n]["message"]:
66036602
url = errors[n]["message"].split(f_t_l_r)[0]
66046603
errors[n] = {"Error 404 (broken link)": url}
6604+
elif u_c_s_e in errors[n]["message"]:
6605+
url = errors[n]["message"].split(u_c_s_e)[0]
6606+
error = errors[n]["message"].split(u_c_s_e)[1]
6607+
errors[n] = {"Uncaught SyntaxError (%s)" % error: url}
66056608
elif u_c_t_e in errors[n]["message"]:
66066609
url = errors[n]["message"].split(u_c_t_e)[0]
66076610
error = errors[n]["message"].split(u_c_t_e)[1]

0 commit comments

Comments
 (0)