Improve select_option_by_*() methods

Author: mdmintz

seleniumbase/fixtures/base_case.py

@@ -1223,9 +1223,12 @@ def __select_option(self, dropdown_selector, option,
             timeout = self.__get_new_timeout(timeout)
         if page_utils.is_xpath_selector(dropdown_selector):
             dropdown_by = By.XPATH
-        element = self.wait_for_element_visible(
+        self.wait_for_ready_state_complete()
+        element = self.wait_for_element_present(
             dropdown_selector, by=dropdown_by, timeout=timeout)
-        self.__demo_mode_highlight_if_active(dropdown_selector, dropdown_by)
+        if self.is_element_visible(dropdown_selector, by=dropdown_by):
+            self.__demo_mode_highlight_if_active(
+                dropdown_selector, dropdown_by)
         pre_action_url = self.driver.current_url
         try:
             if option_by == "index":
@@ -1237,7 +1240,7 @@ def __select_option(self, dropdown_selector, option,
         except (StaleElementReferenceException, ENI_Exception):
             self.wait_for_ready_state_complete()
             time.sleep(0.05)
-            element = self.wait_for_element_visible(
+            element = self.wait_for_element_present(
                 dropdown_selector, by=dropdown_by, timeout=timeout)
             if option_by == "index":
                 Select(element).select_by_index(option)