Skip to content

Commit 719ed7c

Browse files
committed
Update parsing of browser capabilities
1 parent bbdaed4 commit 719ed7c

File tree

1 file changed

+18
-0
lines changed

1 file changed

+18
-0
lines changed

seleniumbase/core/browser_launcher.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -986,13 +986,19 @@ def get_remote_driver(
986986
selenoid = False
987987
selenoid_options = None
988988
screen_resolution = None
989+
browser_version = None
990+
platform_name = None
989991
for key in desired_caps.keys():
990992
capabilities[key] = desired_caps[key]
991993
if key == "selenoid:options":
992994
selenoid = True
993995
selenoid_options = desired_caps[key]
994996
elif key == "screenResolution":
995997
screen_resolution = desired_caps[key]
998+
elif key == "version" or key == "browserVersion":
999+
browser_version = desired_caps[key]
1000+
elif key == "platform" or key == "platformName":
1001+
platform_name = desired_caps[key]
9961002
if selenium4:
9971003
chrome_options.set_capability("cloud:options", capabilities)
9981004
if selenoid:
@@ -1001,6 +1007,12 @@ def get_remote_driver(
10011007
if screen_resolution:
10021008
scres = screen_resolution
10031009
chrome_options.set_capability("screenResolution", scres)
1010+
if browser_version:
1011+
br_vers = browser_version
1012+
chrome_options.set_capability("browserVersion", br_vers)
1013+
if platform_name:
1014+
plat_name = platform_name
1015+
chrome_options.set_capability("platformName", plat_name)
10041016
return webdriver.Remote(
10051017
command_executor=address,
10061018
options=chrome_options,
@@ -1038,13 +1050,16 @@ def get_remote_driver(
10381050
selenoid = False
10391051
selenoid_options = None
10401052
screen_resolution = None
1053+
platform_name = None
10411054
for key in desired_caps.keys():
10421055
capabilities[key] = desired_caps[key]
10431056
if key == "selenoid:options":
10441057
selenoid = True
10451058
selenoid_options = desired_caps[key]
10461059
elif key == "screenResolution":
10471060
screen_resolution = desired_caps[key]
1061+
elif key == "platform" or key == "platformName":
1062+
platform_name = desired_caps[key]
10481063
if selenium4:
10491064
firefox_options.set_capability("cloud:options", capabilities)
10501065
if selenoid:
@@ -1053,6 +1068,9 @@ def get_remote_driver(
10531068
if screen_resolution:
10541069
scres = screen_resolution
10551070
firefox_options.set_capability("screenResolution", scres)
1071+
if platform_name:
1072+
plat_name = platform_name
1073+
firefox_options.set_capability("platformName", plat_name)
10561074
return webdriver.Remote(
10571075
command_executor=address,
10581076
options=firefox_options,

0 commit comments

Comments
 (0)