Make improvements to Recorder Desktop

Author: mdmintz

seleniumbase/console_scripts/sb_mkrec.py

@@ -76,6 +76,7 @@ def set_colors(use_colors):
 
 
 def main():
+    platform = sys.platform
     help_me = False
     error_msg = None
     invalid_cmd = None
@@ -85,7 +86,7 @@ def main():
     use_colors = True
     force_gui = False
 
-    if "linux" in sys.platform:
+    if "linux" in platform:
         use_colors = False
     c0, c1, c2, c5, c7, cr = set_colors(use_colors)
 
@@ -116,11 +117,9 @@ def main():
                 use_edge = True
             elif (
                 option.lower() in ("--gui", "--headed")
-                and "linux" in sys.platform
             ):
-                use_colors = True
-                c0, c1, c2, c5, c7, cr = set_colors(use_colors)
-                force_gui = True
+                if "linux" in platform:
+                    force_gui = True
             elif option.lower().startswith("--url="):
                 start_page = option[len("--url="):]
             elif option.lower() == "--url":

seleniumbase/console_scripts/sb_recorder.py

@@ -12,6 +12,7 @@
 
 import colorama
 import os
+import subprocess
 import sys
 from seleniumbase.fixtures import page_utils
 
@@ -92,10 +93,10 @@ def do_recording(file_name, url, overwrite_enabled, use_chrome, window):
                     return
             else:
                 os.remove(file_name)
-        command = "python -m sbase mkrec %s --url=%s" % (file_name, url)
+        command = "sbase mkrec %s --url=%s --gui" % (file_name, url)
         if not use_chrome:
             command += " --edge"
-        os.system(command)
+        subprocess.Popen(command, shell=True)
         send_window_to_front(window)
 
 
@@ -113,12 +114,14 @@ def do_playback(file_name, use_chrome, window, demo_mode=False):
         )
         return
     command = "pytest %s -q -s" % file_name
+    if "linux" in sys.platform:
+        command += " --gui"
     if not use_chrome:
         command += " --edge"
     if demo_mode:
         command += " --demo"
     print(command)
-    os.system(command)
+    subprocess.Popen(command, shell=True)
     send_window_to_front(window)