Skip to content

Commit 827861c

Browse files
committed
Only use pyvirtualdisplay for headless mode when available
1 parent 3ea501a commit 827861c

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

seleniumbase/fixtures/base_case.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2816,10 +2816,15 @@ def setUp(self):
28162816
self.testcase_manager.insert_testcase_data(data_payload)
28172817
self.case_start_time = int(time.time() * 1000)
28182818
if self.headless:
2819-
from pyvirtualdisplay import Display
2820-
self.display = Display(visible=0, size=(1920, 1200))
2821-
self.display.start()
2822-
self.headless_active = True
2819+
try:
2820+
from pyvirtualdisplay import Display
2821+
self.display = Display(visible=0, size=(1920, 1200))
2822+
self.display.start()
2823+
self.headless_active = True
2824+
except Exception:
2825+
# pyvirtualdisplay might not be necessary anymore because
2826+
# Chrome and Firefox now have built-in headless displays
2827+
pass
28232828

28242829
# Launch WebDriver for both Pytest and Nosetests
28252830
if not hasattr(self, "browser"):

0 commit comments

Comments
 (0)