Skip to content

Commit 855f2af

Browse files
committed
Bring the active window to front when switching drivers
1 parent 26633fb commit 855f2af

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

help_docs/method_summary.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,8 @@ self.save_recorded_actions()
265265

266266
self.activate_jquery()
267267

268+
self.bring_active_window_to_front()
269+
268270
self.bring_to_front(selector, by=By.CSS_SELECTOR)
269271

270272
self.highlight_click(selector, by=By.CSS_SELECTOR, loops=3, scroll=True)

seleniumbase/fixtures/base_case.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2986,13 +2986,15 @@ def switch_to_driver(self, driver):
29862986
self.driver = driver
29872987
if self.driver in self.__driver_browser_map:
29882988
self.browser = self.__driver_browser_map[self.driver]
2989+
self.bring_active_window_to_front()
29892990

29902991
def switch_to_default_driver(self):
29912992
""" Sets self.driver to the default/original driver. """
29922993
self.__check_scope()
29932994
self.driver = self._default_driver
29942995
if self.driver in self.__driver_browser_map:
29952996
self.browser = self.__driver_browser_map[self.driver]
2997+
self.bring_active_window_to_front()
29962998

29972999
def save_screenshot(
29983000
self, name, folder=None, selector=None, by=By.CSS_SELECTOR
@@ -3890,6 +3892,15 @@ def __are_quotes_escaped(self, string):
38903892
def __escape_quotes_if_needed(self, string):
38913893
return js_utils.escape_quotes_if_needed(string)
38923894

3895+
def bring_active_window_to_front(self):
3896+
"""Brings the active browser window to the front.
3897+
This is useful when multiple drivers are being used."""
3898+
self.__check_scope()
3899+
try:
3900+
self.switch_to_window(self.driver.current_window_handle)
3901+
except Exception:
3902+
pass
3903+
38933904
def bring_to_front(self, selector, by=By.CSS_SELECTOR):
38943905
"""Updates the Z-index of a page element to bring it into view.
38953906
Useful when getting a WebDriverException, such as the one below:

0 commit comments

Comments
 (0)