Merge pull request #547 from dE1l/fix_syntax_open_file_example

read file with context manager https://stackoverflow.com/questions/32…

Author: mdmintz

examples/boilerplates/file_parsing/parse_files.py

@@ -13,33 +13,29 @@ def setUp(self):
 
     def get_login_credentials(self, user_type):
         # Example of parsing data from a file
-        f = open('qa_login_example.txt', "r")
-        file_data = f.read()
-        file_lines = file_data.split('\n')
-        for line in file_lines:
-            line_items = line.split(',')
-            if line_items[0] == user_type:
-                return line_items[1], line_items[2]
-        f.close()
+        with open('qa_login_example.txt') as f:
+            file_lines = [line.rstrip() for line in f]
+            for line in file_lines:
+                line_items = line.split(',')
+                if line_items[0] == user_type:
+                    return line_items[1], line_items[2]
 
     def get_all_login_credentials(self):
         # Example of parsing data from a file (Method 2)
         keys = {}
-        f = open("staging_login_example.txt")
-        file_data = f.read()
-        file_lines = file_data.split('\n')
-        for line in file_lines:
-            line_items = line.split(',')
-            if line_items[0] == 'admin':
-                keys['admin'] = (
-                    {'username': line_items[1], 'password': line_items[2]})
-            if line_items[0] == 'employee':
-                keys['employee'] = (
-                    {'username': line_items[1], 'password': line_items[2]})
-            if line_items[0] == 'customer':
-                keys['customer'] = (
-                    {'username': line_items[1], 'password': line_items[2]})
-        f.close()
+        with open('staging_login_example.txt') as f:
+            file_lines = [line.rstrip() for line in f]
+            for line in file_lines:
+                line_items = line.split(',')
+                if line_items[0] == 'admin':
+                    keys['admin'] = (
+                        {'username': line_items[1], 'password': line_items[2]})
+                if line_items[0] == 'employee':
+                    keys['employee'] = (
+                        {'username': line_items[1], 'password': line_items[2]})
+                if line_items[0] == 'customer':
+                    keys['customer'] = (
+                        {'username': line_items[1], 'password': line_items[2]})
         return keys