Refactor BaseCase methods to reduce code

Author: mdmintz

seleniumbase/fixtures/base_case.py

@@ -3471,8 +3471,7 @@ def set_value(self, selector, text, by=By.CSS_SELECTOR, timeout=None):
                 self.wait_for_ready_state_complete()
         self.__demo_mode_pause_if_active()
 
-    def js_update_text(self, selector, text, by=By.CSS_SELECTOR,
-                       timeout=None):
+    def js_update_text(self, selector, text, by=By.CSS_SELECTOR, timeout=None):
         """ JavaScript + send_keys are used to update a text field.
             Performs self.set_value() and triggers event listeners.
             If text ends in "\n", set_value() presses RETURN after.
@@ -3486,18 +3485,16 @@ def js_update_text(self, selector, text, by=By.CSS_SELECTOR,
         selector, by = self.__recalculate_selector(selector, by)
         if type(text) is int or type(text) is float:
             text = str(text)
-        self.set_value(
-            selector, text, by=by, timeout=timeout)
+        self.set_value(selector, text, by=by, timeout=timeout)
         if not text.endswith('\n'):
             try:
                 element = page_actions.wait_for_element_present(
                     self.driver, selector, by, timeout=0.2)
-                element.send_keys(" \b")
+                element.send_keys(" " + Keys.BACK_SPACE)
             except Exception:
                 pass
 
-    def js_type(self, selector, text, by=By.CSS_SELECTOR,
-                timeout=None):
+    def js_type(self, selector, text, by=By.CSS_SELECTOR, timeout=None):
         """ Same as self.js_update_text()
             JavaScript + send_keys are used to update a text field.
             Performs self.set_value() and triggers event listeners.
@@ -3510,17 +3507,7 @@ def js_type(self, selector, text, by=By.CSS_SELECTOR,
         if self.timeout_multiplier and timeout == settings.LARGE_TIMEOUT:
             timeout = self.__get_new_timeout(timeout)
         selector, by = self.__recalculate_selector(selector, by)
-        if type(text) is int or type(text) is float:
-            text = str(text)
-        self.set_value(
-            selector, text, by=by, timeout=timeout)
-        if not text.endswith('\n'):
-            try:
-                element = page_actions.wait_for_element_present(
-                    self.driver, selector, by, timeout=0.2)
-                element.send_keys(" \b")
-            except Exception:
-                pass
+        self.js_update_text(selector, text, by=by, timeout=timeout)
 
     def set_text(self, selector, text, by=By.CSS_SELECTOR, timeout=None):
         """ Same as self.js_update_text()
@@ -3534,17 +3521,7 @@ def set_text(self, selector, text, by=By.CSS_SELECTOR, timeout=None):
         if self.timeout_multiplier and timeout == settings.LARGE_TIMEOUT:
             timeout = self.__get_new_timeout(timeout)
         selector, by = self.__recalculate_selector(selector, by)
-        if type(text) is int or type(text) is float:
-            text = str(text)
-        self.set_value(
-            selector, text, by=by, timeout=timeout)
-        if not text.endswith('\n'):
-            try:
-                element = page_actions.wait_for_element_present(
-                    self.driver, selector, by, timeout=0.2)
-                element.send_keys(" \b")
-            except Exception:
-                pass
+        self.js_update_text(selector, text, by=by, timeout=timeout)
 
     def jquery_update_text(self, selector, text, by=By.CSS_SELECTOR,
                            timeout=None):