Recorder: Prevent duplicate "open()" calls in codegen

Author: mdmintz

seleniumbase/fixtures/base_case.py

@@ -95,6 +95,7 @@ def __init__(self, *args, **kwargs):
         self.__last_page_url = None
         self.__last_page_source = None
         self.__skip_reason = None
+        self.__dont_record_open = False
         self.__dont_record_js_click = False
         self.__new_window_on_rec_open = True
         self.__overrided_default_timeouts = False
@@ -142,7 +143,7 @@ def open(self, url):
         if url.startswith("://"):
             # Convert URLs such as "://google.com" into "https://google.com"
             url = "https" + url
-        if self.recorder_mode:
+        if self.recorder_mode and not self.__dont_record_open:
             time_stamp = self.execute_script("return Date.now();")
             origin = self.get_origin()
             action = ["_url_", origin, url, time_stamp]
@@ -774,9 +775,11 @@ def open_start_page(self):
             if page_utils.is_valid_url(start_page):
                 self.open(start_page)
             else:
-                new_start_page = "http://" + start_page
+                new_start_page = "https://" + start_page
                 if page_utils.is_valid_url(new_start_page):
+                    self.__dont_record_open = True
                     self.open(new_start_page)
+                    self.__dont_record_open = False
                 else:
                     logging.info('Invalid URL: "%s"!' % start_page)
                     self.open("data:,")
@@ -2905,9 +2908,11 @@ def get_new_driver(
                 if page_utils.is_valid_url(self.start_page):
                     self.open(self.start_page)
                 else:
-                    new_start_page = "http://" + self.start_page
+                    new_start_page = "https://" + self.start_page
                     if page_utils.is_valid_url(new_start_page):
+                        self.__dont_record_open = True
                         self.open(new_start_page)
+                        self.__dont_record_open = False
         return new_driver
 
     def switch_to_driver(self, driver):
@@ -10494,10 +10499,12 @@ def setUp(self, masterqa_mode=False):
                     self.open(self.start_page)
                     self.__new_window_on_rec_open = True
                 else:
-                    new_start_page = "http://" + self.start_page
+                    new_start_page = "https://" + self.start_page
                     if page_utils.is_valid_url(new_start_page):
                         good_start_page = True
+                        self.__dont_record_open = True
                         self.open(new_start_page)
+                        self.__dont_record_open = False
             if self.recorder_ext or (self._crumbs and not good_start_page):
                 if self.get_current_url() != "data:,":
                     self.__new_window_on_rec_open = False