Skip to content

Commit 9f1f745

Browse files
authored
Merge pull request #1740 from seleniumbase/update-console-scripts-and-more
Update console scripts and more
2 parents 004a364 + c7cc2f4 commit 9f1f745

File tree

12 files changed

+54
-33
lines changed

12 files changed

+54
-33
lines changed

examples/coffee_cart_tests.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ def test_1_verify_nav_link_to_coffee_cart(self):
1212

1313
def test_buy_one_cappuccino(self):
1414
self.open("https://seleniumbase.io/coffee/")
15+
self.assert_title("Coffee Cart")
1516
self.click('div[data-test="Cappuccino"]')
1617
self.assert_exact_text("cart (1)", 'a[aria-label="Cart page"]')
1718
self.click('a[aria-label="Cart page"]')
@@ -50,6 +51,7 @@ def test_coffee_promo_with_preview(self):
5051

5152
def test_context_click_add_coffee(self):
5253
self.open("https://seleniumbase.io/coffee/")
54+
self.assert_title("Coffee Cart")
5355
self.context_click('div[data-test="Espresso_Macchiato"]')
5456
self.click('form button:contains("Yes")')
5557
self.assert_exact_text("cart (1)", 'a[aria-label="Cart page"]')

examples/offline_examples/user_agent_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def test_get_user_agent(self):
1717
self.skip(msg)
1818
print("\n--------------------------")
1919
try:
20-
self.driver.execute_cdp_cmd(
20+
self.execute_cdp_cmd(
2121
"Network.setUserAgentOverride",
2222
{
2323
"userAgent": "Mozilla/5.0 "
@@ -30,7 +30,7 @@ def test_get_user_agent(self):
3030
print('\nOverrided User Agent = "%s"' % new_user_agent)
3131
finally:
3232
# Reset the user-agent back to the original
33-
self.driver.execute_cdp_cmd(
33+
self.execute_cdp_cmd(
3434
"Network.setUserAgentOverride",
3535
{"userAgent": user_agent},
3636
)

examples/parameterized_test.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,17 @@
33
BaseCase.main(__name__, __file__)
44

55

6-
class GoogleTests(BaseCase):
6+
class SearchTests(BaseCase):
77
@parameterized.expand(
88
[
99
["site:Python.org Download", "Download Python", "img.python-logo"],
1010
["site:SeleniumBase.io", "SeleniumBase", 'img[alt*="SeleniumB"]'],
1111
["site:Wikipedia.org", "Wikipedia", "img.central-featured-logo"],
1212
]
1313
)
14-
def test_parameterized_google_search(self, search_key, expected_text, img):
15-
self.open("https://google.com/ncr")
16-
self.remove_elements("iframe")
17-
self.type('input[title="Search"]', search_key + "\n")
18-
self.assert_text(expected_text, "#search")
14+
def test_parameterized_search(self, search_key, expected_text, img):
15+
self.open("https://duckduckgo.com/")
16+
self.type('input[name="q"]', search_key + "\n")
17+
self.assert_text(expected_text, "div.results")
1918
self.click('a:contains("%s")' % expected_text)
2019
self.assert_element(img)

examples/test_pytest_parametrize.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@
33

44
@pytest.mark.parametrize("value", ["pytest", "selenium"])
55
def test_sb_fixture_with_no_class(sb, value):
6-
sb.open("https://google.com/ncr")
7-
sb.type('input[title="Search"]', value + "\n")
8-
sb.assert_text(value, "div#center_col")
6+
sb.open("https://duckduckgo.com/")
7+
sb.type('input[name="q"]', value + "\n")
8+
sb.assert_text(value, "div.results")
99

1010

1111
class Test_SB_Fixture:
1212
@pytest.mark.parametrize("value", ["pytest", "selenium"])
1313
def test_sb_fixture_inside_class(self, sb, value):
14-
sb.open("https://google.com/ncr")
15-
sb.type('input[title="Search"]', value + "\n")
16-
sb.assert_text(value, "div#center_col")
14+
sb.open("https://duckduckgo.com/")
15+
sb.type('input[name="q"]', value + "\n")
16+
sb.assert_text(value, "div.results")

examples/user_agent_test.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def test_user_agent(self):
2424
self.skip(msg)
2525
print("\n--------------------------")
2626
try:
27-
self.driver.execute_cdp_cmd(
27+
self.execute_cdp_cmd(
2828
"Network.setUserAgentOverride",
2929
{
3030
"userAgent": "Mozilla/5.0 "
@@ -41,7 +41,7 @@ def test_user_agent(self):
4141
self.sleep(3)
4242
finally:
4343
# Reset the user-agent back to the original
44-
self.driver.execute_cdp_cmd(
44+
self.execute_cdp_cmd(
4545
"Network.setUserAgentOverride",
4646
{"userAgent": original_user_agent},
4747
)

help_docs/method_summary.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,8 @@ self.open_html_file(html_file)
206206

207207
self.execute_script(script, *args, **kwargs)
208208

209+
self.execute_cdp_cmd(script, *args, **kwargs)
210+
209211
self.execute_async_script(script, timeout=None)
210212

211213
self.safe_execute_script(script, *args, **kwargs)

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ certifi>=2022.12.7
1818
filelock>=3.4.1;python_version<"3.7"
1919
filelock>=3.9.0;python_version>="3.7"
2020
platformdirs>=2.4.0;python_version<"3.7"
21-
platformdirs>=2.6.2;python_version>="3.7"
21+
platformdirs>=3.0.0;python_version>="3.7"
2222
pyparsing>=3.0.7;python_version<"3.7"
2323
zipp==3.6.0;python_version<"3.7"
2424
zipp>=3.12.1;python_version>="3.7"

seleniumbase/__version__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# seleniumbase package
2-
__version__ = "4.12.6"
2+
__version__ = "4.12.7"

seleniumbase/console_scripts/sb_install.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -676,7 +676,7 @@ def main(override=None, intel_for_uc=None):
676676
contents = zip_ref.namelist()
677677
if (
678678
len(contents) >= 1
679-
and name in ["chromedriver", "uc_driver"]
679+
and name in ["chromedriver", "uc_driver", "geckodriver"]
680680
):
681681
for f_name in contents:
682682
if (

seleniumbase/console_scripts/sb_mkdir.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,7 @@ def main():
159159
data = []
160160
data.append("[flake8]")
161161
data.append("exclude=recordings,temp")
162+
data.append("ignore=W503")
162163
data.append("")
163164
data.append("[nosetests]")
164165
data.append("nocapture=1")

0 commit comments

Comments
 (0)