Skip to content

Commit a4c8994

Browse files
committed
Update examples
1 parent ae8cffa commit a4c8994

21 files changed

+75
-39
lines changed

examples/boilerplates/samples/google_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ class GoogleTests(BaseCase):
77
def test_google_dot_com(self):
88
self.open("https://google.com/ncr")
99
self.sleep(0.5)
10-
self.hide_elements('iframe[name="callout"]')
1110
self.save_screenshot_to_logs() # ("./latest_logs" folder)
11+
self.sleep(0.5)
1212
self.type(HomePage.search_box, "github.com")
1313
self.assert_element(HomePage.search_button)
1414
self.assert_element(HomePage.feeling_lucky_button)

examples/boilerplates/samples/test_page_objects.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,12 @@
66
class GooglePage:
77
def go_to_google(self, sb):
88
sb.open("https://google.com/ncr")
9-
sb.remove_elements("iframe")
9+
sb.sleep(0.2)
10+
sb.hide_elements('iframe[name="callout"]') # Hide "Sign in" pop-up
11+
sb.sleep(0.1)
1012

1113
def do_search(self, sb, search_term):
14+
sb.click('input[title="Search"]')
1215
sb.type('input[title="Search"]', search_term + "\n")
1316

1417
def click_search_result(self, sb, content):

examples/chart_maker/test_area_chart.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ def test_area_chart(self):
1616
self.add_data_point("Fri", 65)
1717
self.add_data_point("Sat", 50)
1818
self.add_slide("<p><b>Area Chart</b></p>" + self.extract_chart())
19-
self.begin_presentation(filename="line_chart.html", interval=8)
19+
self.begin_presentation(filename="line_chart.html", interval=4)

examples/chart_maker/test_line_chart.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ def test_line_chart(self):
1616
self.add_data_point("Fri", 65)
1717
self.add_data_point("Sat", 50)
1818
self.add_slide("<p>Line Chart</p>" + self.extract_chart())
19-
self.begin_presentation(filename="line_chart.html", interval=8)
19+
self.begin_presentation(filename="line_chart.html", interval=4)

examples/chart_maker/test_multi_series.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,4 @@ def test_multi_series(self):
4545
self.add_data_point("Sat", 31)
4646

4747
self.add_slide("<p>Multi-Series Line Chart</p>" + self.extract_chart())
48-
self.begin_presentation(filename="multi_series_chart.html", interval=8)
48+
self.begin_presentation(filename="multi_series_chart.html", interval=4)

examples/edge_test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99
class EdgeTests(BaseCase):
1010
def test_edge(self):
1111
if self.browser != "edge":
12-
self.open("about:blank")
12+
self.open_if_not_url("about:blank")
1313
print("\n This test is only for Microsoft Edge (Chromium)!")
1414
print(' (Run this test using "--edge" or "--browser=edge")')
1515
self.skip('Use "--edge" or "--browser=edge"')
16-
if self.headless:
17-
self.open("about:blank")
16+
elif self.headless:
17+
self.open_if_not_url("about:blank")
1818
print("\n This test is NOT designed for Headless Mode!")
1919
self.skip('Do NOT use "--headless" with this test!')
2020
self.open("edge://settings/help")

examples/github_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
class GitHubTests(BaseCase):
66
def test_github(self):
77
if self.headless or self.page_load_strategy == "none":
8-
self.open_if_not_url("data:,")
8+
self.open_if_not_url("about:blank")
99
message = "Unsupported mode for this test."
1010
print("\n " + message)
1111
self.skip(message)

examples/handle_alert_test.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,6 @@ def test_alerts(self):
1515
self.assert_equal(alert.text, "My Prompt") # Not input field
1616
self.dismiss_alert()
1717
self.sleep(1) # Not needed (Lets you see the alert go away)
18+
if self.browser == "safari" and self._reuse_session:
19+
# Alerts can freeze Safari if reusing the browser session
20+
self.driver.quit()

examples/offline_examples/test_handle_alerts.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,6 @@ def test_alerts(self):
1717
self.assert_equal(alert.text, "My Prompt") # Not input field
1818
self.dismiss_alert()
1919
self.sleep(1) # Not needed (Lets you see the alert go away)
20+
if self.browser == "safari" and self._reuse_session:
21+
# Alerts can freeze Safari if reusing the browser session
22+
self.driver.quit()

examples/proxy_test.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,17 @@
66
class ProxyTests(BaseCase):
77
def test_proxy(self):
88
if self.headless:
9-
self.open("about:blank")
9+
self.open_if_not_url("about:blank")
1010
print("Skipping test in Headless Mode.")
1111
self.skip("Skipping test in Headless Mode.")
12-
if self.recorder_mode:
13-
self.open("about:blank")
12+
elif self.recorder_mode:
13+
self.open_if_not_url("about:blank")
1414
print("Skipping test in Recorder Mode.")
1515
self.skip("Skipping test in Recorder Mode.")
16+
elif self.browser == "safari":
17+
self.open_if_not_url("about:blank")
18+
print("Skipping test for using Safari.")
19+
self.skip("Skipping test for using Safari.")
1620
settings.SKIP_JS_WAITS = True
1721
if not self.page_load_strategy == "none":
1822
# This page takes too long to load otherwise

0 commit comments

Comments
 (0)