Skip to content

Commit aac418d

Browse files
authored
Merge pull request #1064 from seleniumbase/small-update-to-recorder-mode
Update Recorder Mode script-generation
2 parents 8c623cc + bd674a9 commit aac418d

File tree

6 files changed

+23
-10
lines changed

6 files changed

+23
-10
lines changed

help_docs/recorder_mode.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<img src="https://seleniumbase.io/cdn/img/sb_recorder_notification.png" title="SeleniumBase" width="380">
88

9-
(This tutorial assumes that you are using SeleniumBase version ``2.1.3`` or newer.)
9+
(This tutorial assumes that you are using SeleniumBase version ``2.1.5`` or newer.)
1010

1111
🔴 To make a new recording with Recorder Mode, you can use ``sbase mkrec`` or ``sbase codegen``):
1212

mkdocs_build/requirements.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
regex>=2021.11.2
1+
regex>=2021.11.10
22
tqdm>=4.62.3
33
docutils==0.18
44
python-dateutil==2.8.2
@@ -9,12 +9,12 @@ MarkupSafe==2.0.1;python_version>="3.6"
99
pyparsing==2.4.7;python_version>="3.6"
1010
keyring==23.2.1;python_version>="3.6"
1111
pkginfo==1.7.1;python_version>="3.6"
12-
Jinja2==3.0.2;python_version>="3.6"
12+
Jinja2==3.0.3;python_version>="3.6"
1313
click==8.0.3;python_version>="3.6"
1414
zipp==3.6.0;python_version>="3.6"
1515
readme-renderer==30.0
1616
pymdown-extensions==9.0;python_version>="3.6"
17-
importlib-metadata==4.8.1;python_version>="3.6"
17+
importlib-metadata==4.8.2;python_version>="3.6"
1818
bleach==4.1.0
1919
jsmin==3.0.0;python_version>="3.6"
2020
lunr==0.6.1;python_version>="3.6"

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ trio-websocket==0.9.2;python_version>="3.7"
4040
pyopenssl==21.0.0;python_version>="3.7"
4141
msedge-selenium-tools==3.141.3;python_version<"3.7"
4242
more-itertools==5.0.0;python_version<"3.5"
43-
more-itertools==8.10.0;python_version>="3.5"
43+
more-itertools==8.11.0;python_version>="3.5"
4444
cssselect==1.1.0
4545
filelock==3.2.1;python_version<"3.6"
4646
filelock==3.3.2;python_version>="3.6"

seleniumbase/__version__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# seleniumbase package
2-
__version__ = "2.1.4"
2+
__version__ = "2.1.5"

seleniumbase/fixtures/base_case.py

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,14 @@ def open(self, url):
157157
if ("http:") in c_url or ("https:") in c_url or ("file:") in c_url:
158158
if self.get_domain_url(url) != self.get_domain_url(c_url):
159159
self.open_new_window(switch_to=True)
160-
self.driver.get(url)
160+
try:
161+
self.driver.get(url)
162+
except Exception as e:
163+
if "ERR_CONNECTION_TIMED_OUT" in e.msg:
164+
self.sleep(0.5)
165+
self.driver.get(url)
166+
else:
167+
raise Exception(e.msg)
161168
if settings.WAIT_FOR_RSC_ON_PAGE_LOADS:
162169
self.wait_for_ready_state_complete()
163170
self.__demo_mode_pause_if_active()
@@ -3125,7 +3132,7 @@ def sleep(self, seconds):
31253132
self.__check_scope()
31263133
if not sb_config.time_limit:
31273134
time.sleep(seconds)
3128-
elif seconds <= 0.3:
3135+
elif seconds < 0.4:
31293136
shared_utils.check_if_time_limit_exceeded()
31303137
time.sleep(seconds)
31313138
shared_utils.check_if_time_limit_exceeded()
@@ -3309,7 +3316,13 @@ def __process_recorded_actions(self):
33093316
url2 = url1[:-3]
33103317
elif url2.endswith("/"):
33113318
url2 = url2[:-1]
3312-
if (url1 == url2) or (url1 == url2.replace("www.", "")):
3319+
if (
3320+
url1 == url2
3321+
or url1 == url2.replace("www.", "")
3322+
or (len(url1) > 0 and url2.startswith(url1)
3323+
and (int(srt_actions[n][3]) - int(
3324+
srt_actions[n-1][3]) < 6500))
3325+
):
33133326
srt_actions[n][0] = "f_url"
33143327
for n in range(len(srt_actions)):
33153328
if (

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@
156156
'pyopenssl==21.0.0;python_version>="3.7"',
157157
'msedge-selenium-tools==3.141.3;python_version<"3.7"',
158158
'more-itertools==5.0.0;python_version<"3.5"',
159-
'more-itertools==8.10.0;python_version>="3.5"',
159+
'more-itertools==8.11.0;python_version>="3.5"',
160160
"cssselect==1.1.0",
161161
'filelock==3.2.1;python_version<"3.6"',
162162
'filelock==3.3.2;python_version>="3.6"',

0 commit comments

Comments
 (0)