Skip to content

Commit ad6a562

Browse files
committed
Improve shadow root methods
1 parent 0cee731 commit ad6a562

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

seleniumbase/fixtures/base_case.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8061,7 +8061,7 @@ def wait_for_element_visible(
80618061
original_selector = selector
80628062
selector, by = self.__recalculate_selector(selector, by)
80638063
if self.__is_shadow_selector(selector):
8064-
return self.__wait_for_shadow_element_visible(selector, timeout)
8064+
return self.__get_shadow_element(selector, timeout)
80658065
return page_actions.wait_for_element_visible(
80668066
self.driver,
80678067
selector,
@@ -8478,7 +8478,7 @@ def wait_for_element(self, selector, by="css selector", timeout=None):
84788478
action = ["wf_el", selector, origin, time_stamp]
84798479
self.__extra_actions.append(action)
84808480
if self.__is_shadow_selector(selector):
8481-
return self.__wait_for_shadow_element_visible(selector, timeout)
8481+
return self.__get_shadow_element(selector, timeout)
84828482
return page_actions.wait_for_element_visible(
84838483
self.driver, selector, by, timeout
84848484
)
@@ -12995,7 +12995,10 @@ def __get_shadow_element(
1299512995
By.CSS_SELECTOR, value=selector_part
1299612996
)
1299712997
is_present = True
12998-
if must_be_visible:
12998+
if (
12999+
selector_part == selectors[-1]
13000+
and must_be_visible
13001+
):
1299913002
if not element.is_displayed():
1300013003
raise Exception(
1300113004
"Shadow Root element not visible!"
@@ -13010,7 +13013,11 @@ def __get_shadow_element(
1301013013
By.CSS_SELECTOR, value=selector_part
1301113014
)
1301213015
is_present = True
13013-
if must_be_visible and not element.is_displayed():
13016+
if (
13017+
selector_part == selectors[-1]
13018+
and must_be_visible
13019+
and not element.is_displayed()
13020+
):
1301413021
raise Exception(
1301513022
"Shadow Root element not visible!"
1301613023
)

0 commit comments

Comments
 (0)