Add scroll_into_view(selector)

Author: mdmintz

help_docs/method_summary.md

@@ -359,6 +359,8 @@ self.scroll_to(selector, by="css selector", timeout=None)
 self.slow_scroll_to(selector, by="css selector", timeout=None)
 # Duplicates: self.slow_scroll_to_element(selector, by="css selector")
 
+self.scroll_into_view(selector, by="css selector", timeout=None)
+
 self.scroll_to_top()
 
 self.scroll_to_bottom()

seleniumbase/fixtures/base_case.py

@@ -5471,6 +5471,7 @@ def scroll_to(self, selector, by="css selector", timeout=None):
             self.__scroll_to_element(element, selector, by)
 
     def scroll_to_element(self, selector, by="css selector", timeout=None):
+        """Same as self.scroll_to()"""
         self.scroll_to(selector, by=by, timeout=timeout)
 
     def slow_scroll_to(self, selector, by="css selector", timeout=None):
@@ -5508,8 +5509,21 @@ def slow_scroll_to(self, selector, by="css selector", timeout=None):
     def slow_scroll_to_element(
         self, selector, by="css selector", timeout=None
     ):
+        """Same as self.slow_scroll_to()"""
         self.slow_scroll_to(selector, by=by, timeout=timeout)
 
+    def scroll_into_view(self, selector, by="css selector", timeout=None):
+        """Uses the JS scrollIntoView() method to scroll to an element.
+        Unlike other scroll methods, (which put elements upper-center),
+        this method places elements at the very top of the screen."""
+        self.__check_scope()
+        if not timeout:
+            timeout = settings.SMALL_TIMEOUT
+        if self.timeout_multiplier and timeout == settings.SMALL_TIMEOUT:
+            timeout = self.__get_new_timeout(timeout)
+        element = self.wait_for_element_visible(selector, by, timeout=timeout)
+        self.execute_script("arguments[0].scrollIntoView();", element)
+
     def scroll_to_top(self):
         """Scroll to the top of the page."""
         self.__check_scope()

seleniumbase/fixtures/js_utils.py

@@ -1039,6 +1039,8 @@ def scroll_to_element(driver, element):
     )
     # The old jQuery scroll_script required by=By.CSS_SELECTOR
     # scroll_script = "jQuery('%s')[0].scrollIntoView()" % selector
+    # This other scroll_script does not centralize the element
+    # driver.execute_script("arguments[0].scrollIntoView();", element)
     try:
         driver.execute_script(scroll_script)
         return True