Make improvements to assert_text() and assert_exact_text()

Author: mdmintz

seleniumbase/fixtures/page_actions.py

@@ -28,14 +28,13 @@
 from selenium.common.exceptions import NoAlertPresentException
 from selenium.common.exceptions import NoSuchAttributeException
 from selenium.common.exceptions import NoSuchElementException
-from selenium.common.exceptions import NoSuchFrameException
 from selenium.common.exceptions import NoSuchWindowException
 from selenium.common.exceptions import StaleElementReferenceException
-from selenium.common.exceptions import TimeoutException
 from selenium.webdriver.common.by import By
 from selenium.webdriver.common.action_chains import ActionChains
+from seleniumbase.common.exceptions import TextNotVisibleException
 from seleniumbase.config import settings
-from seleniumbase.fixtures import shared_utils as s_utils
+from seleniumbase.fixtures import shared_utils
 
 
 def is_element_present(driver, selector, by=By.CSS_SELECTOR):
@@ -438,26 +437,44 @@ def wait_for_text_visible(
     """
     element = None
     is_present = False
+    full_text = None
     start_ms = time.time() * 1000.0
     stop_ms = start_ms + (timeout * 1000.0)
     for x in range(int(timeout * 10)):
-        s_utils.check_if_time_limit_exceeded()
+        shared_utils.check_if_time_limit_exceeded()
+        full_text = None
         try:
             element = driver.find_element(by=by, value=selector)
             is_present = True
-            if browser == "safari":
+            if element.tag_name == "input":
+                if (
+                    element.is_displayed()
+                    and text in element.get_property("value")
+                ):
+                    return element
+                else:
+                    if element.is_displayed():
+                        full_text = element.get_property("value").strip()
+                    element = None
+                    raise Exception()
+            elif browser == "safari":
                 if (
                     element.is_displayed()
                     and text in element.get_attribute("innerText")
                 ):
                     return element
                 else:
+                    if element.is_displayed():
+                        full_text = element.get_attribute("innerText")
+                        full_text = full_text.strip()
                     element = None
                     raise Exception()
             else:
                 if element.is_displayed() and text in element.text:
                     return element
                 else:
+                    if element.is_displayed():
+                        full_text = element.text.strip()
                     element = None
                     raise Exception()
         except Exception:
@@ -478,11 +495,20 @@ def wait_for_text_visible(
             )
             timeout_exception(NoSuchElementException, message)
         # The element exists in the HTML, but the text is not visible
-        message = (
-            "Expected text {%s} for {%s} was not visible after %s second%s!"
-            % (text, selector, timeout, plural)
-        )
-        timeout_exception(ElementNotVisibleException, message)
+        message = None
+        if not full_text or len(str(full_text.replace("\n", ""))) > 320:
+            message = (
+                "Expected text substring {%s} for {%s} was not visible "
+                "after %s second%s!" % (text, selector, timeout, plural)
+            )
+        else:
+            full_text = full_text.replace("\n", "\\n ")
+            message = (
+                "Expected text substring {%s} for {%s} was not visible "
+                "after %s second%s!\n (The string searched was {%s})"
+                % (text, selector, timeout, plural, full_text)
+            )
+        timeout_exception(TextNotVisibleException, message)
     else:
         return element
 
@@ -515,19 +541,35 @@ def wait_for_exact_text_visible(
     """
     element = None
     is_present = False
+    actual_text = None
     start_ms = time.time() * 1000.0
     stop_ms = start_ms + (timeout * 1000.0)
     for x in range(int(timeout * 10)):
-        s_utils.check_if_time_limit_exceeded()
+        shared_utils.check_if_time_limit_exceeded()
+        actual_text = None
         try:
             element = driver.find_element(by=by, value=selector)
             is_present = True
-            if browser == "safari":
+            if element.tag_name == "input":
+                if (
+                    element.is_displayed()
+                    and text.strip() == element.get_property("value").strip()
+                ):
+                    return element
+                else:
+                    if element.is_displayed():
+                        actual_text = element.get_property("value").strip()
+                    element = None
+                    raise Exception()
+            elif browser == "safari":
                 if element.is_displayed() and (
                     text.strip() == element.get_attribute("innerText").strip()
                 ):
                     return element
                 else:
+                    if element.is_displayed():
+                        actual_text = element.get_attribute("innerText")
+                        actual_text = actual_text.strip()
                     element = None
                     raise Exception()
             else:
@@ -537,6 +579,8 @@ def wait_for_exact_text_visible(
                 ):
                     return element
                 else:
+                    if element.is_displayed():
+                        actual_text = element.text.strip()
                     element = None
                     raise Exception()
         except Exception:
@@ -557,11 +601,20 @@ def wait_for_exact_text_visible(
             )
             timeout_exception(NoSuchElementException, message)
         # The element exists in the HTML, but the exact text is not visible
-        message = (
-            "Expected exact text {%s} for {%s} was not visible "
-            "after %s second%s!" % (text, selector, timeout, plural)
-        )
-        timeout_exception(ElementNotVisibleException, message)
+        message = None
+        if not actual_text or len(str(actual_text)) > 120:
+            message = (
+                "Expected exact text {%s} for {%s} was not visible "
+                "after %s second%s!" % (text, selector, timeout, plural)
+            )
+        else:
+            actual_text = actual_text.replace("\n", "\\n")
+            message = (
+                "Expected exact text {%s} for {%s} was not visible "
+                "after %s second%s!\n (Actual text was {%s})"
+                % (text, selector, timeout, plural, actual_text)
+            )
+        timeout_exception(TextNotVisibleException, message)
     else:
         return element