Skip to content

Commit af5665f

Browse files
committed
Handle spinning up new browser drivers more efficiently
1 parent 4c9d891 commit af5665f

File tree

1 file changed

+6
-15
lines changed

1 file changed

+6
-15
lines changed

seleniumbase/fixtures/base_case.py

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2818,22 +2818,13 @@ def setUp(self):
28182818
raise Exception("""SeleniumBase plugins did not load! """
28192819
"""Please reinstall using:\n"""
28202820
""" >>> "python setup.py develop" <<< """)
2821-
self.driver = browser_launcher.get_driver(self.browser,
2822-
self.headless,
2823-
self.use_grid,
2824-
self.servername,
2825-
self.port,
2826-
self.proxy_string)
2821+
self.driver = self.get_new_driver(browser=self.browser,
2822+
headless=self.headless,
2823+
servername=self.servername,
2824+
port=self.port,
2825+
proxy=self.proxy_string,
2826+
switch_to=True)
28272827
self._default_driver = self.driver
2828-
self._drivers_list.append(self.driver)
2829-
if self.headless:
2830-
# Make sure the invisible browser window is big enough
2831-
try:
2832-
self.set_window_size(1920, 1200)
2833-
except Exception:
2834-
# This shouldn't fail, but in case it does, get safely through
2835-
# setUp() so that WebDrivers can get closed during tearDown().
2836-
pass
28372828

28382829
def __insert_test_result(self, state, err):
28392830
data_payload = TestcaseDataPayload()

0 commit comments

Comments
 (0)