Merge pull request #389 from seleniumbase/fix-assert-no-404-errors-method

Fix assert_no_404_errors() method

Author: mdmintz

seleniumbase/fixtures/base_case.py

@@ -1690,7 +1690,8 @@ def assert_no_404_errors(self, multithreaded=True):
             pool.join()
         else:
             for link in links:
-                self.assert_link_status_code_is_not_404(link)
+                if "javascript:" not in link:  # Ignore links with JavaScript
+                    self.assert_link_status_code_is_not_404(link)
         if self.demo_mode:
             messenger_post = ("ASSERT NO 404 ERRORS")
             js_utils.post_messenger_success_message(

seleniumbase/fixtures/page_utils.py

@@ -13,7 +13,7 @@ def get_domain_url(url):
     Into this:
     https://blog.xkcd.com
     """
-    if "http://" not in url and "https://" not in url:
+    if not url.startswith("http://") and not url.startswith("https://"):
         return url
     url_header = url.split('://')[0]
     simple_url = url.split('://')[1]
@@ -118,7 +118,8 @@ def _get_unique_links(page_url, soup):
     Includes:
         "a"->"href", "img"->"src", "link"->"href", and "script"->"src" links.
     """
-    if "http://" not in page_url and "https://" not in page_url:
+    if not page_url.startswith("http://") and (
+            not page_url.startswith("https://")):
         return []
     prefix = 'http:'
     if page_url.startswith('https:'):

setup.py

@@ -45,7 +45,7 @@
 
 setup(
     name='seleniumbase',
-    version='1.32.10',
+    version='1.32.11',
     description='Fast, Easy, and Reliable Browser Automation & Testing.',
     long_description=long_description,
     long_description_content_type='text/markdown',