Skip to content

Commit cf59159

Browse files
authored
Merge pull request #641 from seleniumbase/bug-fixes-and-test-updates
Bug fixes and test updates
2 parents 64cbbfb + 6cd9029 commit cf59159

File tree

6 files changed

+18
-6
lines changed

6 files changed

+18
-6
lines changed

examples/swag_labs_suite.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ def test_swag_labs_basic_functional_flow(self, username):
7373
# Finish Checkout and verify the item was removed from the cart
7474
self.click("link=FINISH")
7575
self.assert_exact_text("THANK YOU FOR YOUR ORDER", "h2")
76-
self.assert_element("div.pony_express")
76+
self.assert_element("img.pony_express")
7777
self.click("#shopping_cart_container path")
7878
self.assert_element_absent("div.inventory_item_name")
7979
self.click(continue_shopping_button)

examples/test_apple_site.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ def test_apple_developer_site_webdriver_instructions(self):
1212
title = "Testing with WebDriver in Safari"
1313
self.type('[placeholder*="developer.apple.com"]', title + "\n")
1414
self.click("link=%s" % title)
15-
self.assert_element('[href="/documentation"]')
15+
self.assert_element('div.localnav-content [href*="/documentation/"]')
1616
self.assert_text(title, "h1")
17-
self.highlight("div.topic-description p")
17+
self.highlight("div.description div.abstract")
1818
self.highlight("h2")
1919
h3 = "h3:nth-of-type(%s)"
2020
self.assert_text("Make Sure You Have Safari’s WebDriver", h3 % "1")

examples/test_swag_labs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def test_swag_labs_basic_flow(self):
6565
# Finish Checkout and verify item is no longer in cart
6666
self.click("link=FINISH")
6767
self.assert_exact_text("THANK YOU FOR YOUR ORDER", "h2")
68-
self.assert_element("div.pony_express")
68+
self.assert_element("img.pony_express")
6969
self.click("#shopping_cart_container path")
7070
self.assert_element_absent("div.inventory_item_name")
7171
self.click(continue_shopping_button)

examples/test_usefixtures.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ def test_usefixtures_on_class(self):
88
sb.open("https://google.com/ncr")
99
sb.update_text('input[title="Search"]', 'SeleniumBase\n')
1010
sb.click('a[href*="github.com/seleniumbase/SeleniumBase"]')
11-
sb.assert_text("SeleniumBase", "h1.public")
11+
sb.assert_text("SeleniumBase", 'strong[itemprop="name"]')
1212
sb.assert_text("integrations")
1313
sb.assert_element('a[title="help_docs"]')
1414
sb.click('a[title="examples"]')

seleniumbase/fixtures/base_case.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,16 @@ def double_click(self, selector, by=By.CSS_SELECTOR, timeout=None):
229229
self.driver, selector, by, timeout=timeout)
230230
actions = ActionChains(self.driver)
231231
actions.double_click(element).perform()
232+
except Exception:
233+
css_selector = self.convert_to_css_selector(selector, by=by)
234+
css_selector = re.escape(css_selector)
235+
css_selector = self.__escape_quotes_if_needed(css_selector)
236+
double_click_script = (
237+
"""var targetElement1 = document.querySelector('%s');
238+
var clickEvent1 = document.createEvent('MouseEvents');
239+
clickEvent1.initEvent('dblclick', true, true);
240+
targetElement1.dispatchEvent(clickEvent1);""" % css_selector)
241+
self.execute_script(double_click_script)
232242
if settings.WAIT_FOR_RSC_ON_CLICKS:
233243
self.wait_for_ready_state_complete()
234244
if self.demo_mode:
@@ -3875,6 +3885,8 @@ def display_chart(self, chart_name=None, filename=None, interval=0):
38753885
interval - The delay time for auto-advancing charts. (in seconds)
38763886
If set to 0 (default), auto-advancing is disabled.
38773887
"""
3888+
if self.headless:
3889+
interval = 1 # Race through chart if running in headless mode
38783890
if not chart_name:
38793891
chart_name = "default"
38803892
if not filename:

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454

5555
setup(
5656
name='seleniumbase',
57-
version='1.44.2',
57+
version='1.44.3',
5858
description='Fast, Easy, and Reliable Browser Automation & Testing.',
5959
long_description=long_description,
6060
long_description_content_type='text/markdown',

0 commit comments

Comments
 (0)