Skip to content

Commit d05f015

Browse files
committed
Fix exception formatting
1 parent 018b3be commit d05f015

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

seleniumbase/core/log_helper.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,9 @@ def log_test_failure_data(test, test_logpath, driver, browser, url=None):
190190
except Exception:
191191
exc_message = "(Unknown Exception)"
192192
traceback_message = "(Unknown Traceback)"
193-
data_to_save.append("Traceback: " + traceback_message)
194-
data_to_save.append("Exception: " + str(exc_message))
193+
traceback_message = str(traceback_message).strip()
194+
data_to_save.append("Traceback:\n %s" % traceback_message)
195+
data_to_save.append("Exception: %s" % exc_message)
195196
else:
196197
traceback_message = None
197198
if hasattr(test, "is_behave") and test.is_behave:
@@ -232,16 +233,16 @@ def log_test_failure_data(test, test_logpath, driver, browser, url=None):
232233
if "/site-packages/pluggy/" not in stack:
233234
if "/site-packages/_pytest/" not in stack:
234235
good_stack.append(stack)
235-
traceback_message = "".join(good_stack)
236-
data_to_save.append("Traceback: " + traceback_message)
236+
traceback_message = str("".join(good_stack)).strip()
237+
data_to_save.append("Traceback:\n %s" % traceback_message)
237238
if hasattr(sys, "last_value"):
238239
last_value = sys.last_value
239240
if last_value:
240-
data_to_save.append("Exception: %s" + str(last_value))
241+
data_to_save.append("Exception: %s" % last_value)
241242
elif hasattr(sb_config, "_excinfo_value"):
242243
data_to_save.append("Exception: %s" % sb_config._excinfo_value)
243244
else:
244-
data_to_save.append("Traceback: " + traceback_message)
245+
data_to_save.append("Traceback:\n %s" % traceback_message)
245246
if hasattr(test, "is_nosetest") and test.is_nosetest:
246247
# Also save the data for the report
247248
sb_config._report_test_id = test_id

0 commit comments

Comments
 (0)