Skip to content

Commit ef41346

Browse files
committed
Update error-handling
1 parent 2fe10e5 commit ef41346

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

seleniumbase/fixtures/base_case.py

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -241,9 +241,13 @@ def open(self, url):
241241
"cannot determine loading status" in e.msg
242242
or "unexpected command response" in e.msg
243243
):
244-
pass # Odd issue where the open did happen. Continue.
244+
if self.__needs_minimum_wait():
245+
time.sleep(0.2)
246+
self.driver.get(url)
247+
else:
248+
pass # Odd issue where the open did happen. Continue.
245249
else:
246-
raise Exception(e.msg)
250+
raise
247251
if self.driver.current_url == pre_action_url and pre_action_url != url:
248252
time.sleep(0.1) # Make sure load happens
249253
if settings.WAIT_FOR_RSC_ON_PAGE_LOADS:
@@ -702,7 +706,7 @@ def update_text(
702706
):
703707
pass # Odd issue where the click did happen. Continue.
704708
else:
705-
raise e
709+
raise
706710
if settings.WAIT_FOR_RSC_ON_PAGE_LOADS:
707711
self.wait_for_ready_state_complete()
708712
except (StaleElementReferenceException, ENI_Exception):
@@ -725,7 +729,7 @@ def update_text(
725729
):
726730
pass # Odd issue where the click did happen. Continue.
727731
else:
728-
raise e
732+
raise
729733
if settings.WAIT_FOR_RSC_ON_PAGE_LOADS:
730734
self.wait_for_ready_state_complete()
731735
if self.__needs_minimum_wait():
@@ -2206,7 +2210,7 @@ def hover_on_element(self, selector, by="css selector"):
22062210
# (Pure hover actions won't work on early chromedriver versions)
22072211
try:
22082212
return page_actions.hover_on_element(self.driver, selector, by)
2209-
except WebDriverException as e:
2213+
except WebDriverException:
22102214
driver_capabilities = self.driver.capabilities
22112215
if "version" in driver_capabilities:
22122216
chrome_version = driver_capabilities["version"]
@@ -2232,7 +2236,7 @@ def hover_on_element(self, selector, by="css selector"):
22322236
)
22332237
raise Exception(message)
22342238
else:
2235-
raise Exception(e)
2239+
raise
22362240

22372241
def hover_and_click(
22382242
self,
@@ -11859,9 +11863,9 @@ def __click_with_offset(
1185911863
"The offset must stay inside the target element!"
1186011864
)
1186111865
raise Exception(message)
11862-
except InvalidArgumentException as e:
11866+
except InvalidArgumentException:
1186311867
if not self.browser == "chrome":
11864-
raise Exception(e)
11868+
raise
1186511869
driver_capabilities = self.driver.capabilities
1186611870
if "version" in driver_capabilities:
1186711871
chrome_version = driver_capabilities["version"]
@@ -11876,7 +11880,7 @@ def __click_with_offset(
1187611880
int(major_chromedriver_version) >= 76
1187711881
and int(major_chrome_version) >= 76
1187811882
):
11879-
raise Exception(e)
11883+
raise
1188011884
install_sb = (
1188111885
"seleniumbase get chromedriver %s" % major_chrome_version
1188211886
)
@@ -11893,7 +11897,7 @@ def __click_with_offset(
1189311897
)
1189411898
raise Exception(message)
1189511899
else:
11896-
raise Exception(e)
11900+
raise
1189711901
if self.demo_mode:
1189811902
self.__demo_mode_pause_if_active()
1189911903
elif self.slow_mode:

0 commit comments

Comments
 (0)