Skip to content

Commit eff35ce

Browse files
committed
Fix issue that may cause crashes in CDP Mode
1 parent a56253c commit eff35ce

File tree

2 files changed

+1
-6
lines changed

2 files changed

+1
-6
lines changed

seleniumbase/core/browser_launcher.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -543,11 +543,6 @@ def uc_open_with_cdp_mode(driver, url=None, **kwargs):
543543
driver.connect()
544544
current_url = driver.current_url
545545
url_protocol = current_url.split(":")[0]
546-
if url_protocol not in ["about", "data", "chrome"]:
547-
script = 'window.open("data:,","_blank");'
548-
js_utils.call_me_later(driver, script, 3)
549-
time.sleep(0.012)
550-
driver.close()
551546
driver.disconnect()
552547

553548
cdp_details = driver._get_cdp_details()

seleniumbase/fixtures/base_case.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4894,7 +4894,7 @@ def activate_cdp_mode(self, url=None, **kwargs):
48944894
self.driver.connect()
48954895
current_url = self.get_current_url()
48964896
if not current_url.startswith(("about", "data", "chrome")):
4897-
self.get_new_driver(undetectable=True)
4897+
self.open("about:blank")
48984898
self.driver.uc_open_with_cdp_mode(url, **kwargs)
48994899
else:
49004900
self.get_new_driver(undetectable=True)

0 commit comments

Comments
 (0)