Scroll to the drop selector before drag-and-drop

mdmintz · mdmintz · commit f7263d12543a · 2022-08-17T02:10:37.000-04:00
diff --git a/seleniumbase/fixtures/base_case.py b/seleniumbase/fixtures/base_case.py
@@ -2370,7 +2370,7 @@ def drag_and_drop(
             drop_selector, by=drop_by, timeout=timeout
         )
         self.__demo_mode_highlight_if_active(drop_selector, drop_by)
-        self.scroll_to(drag_selector, by=drag_by)
+        self.scroll_to(drop_selector, by=drop_by)
         drag_selector = self.convert_to_css_selector(drag_selector, drag_by)
         drop_selector = self.convert_to_css_selector(drop_selector, drop_by)
         if not jquery:

Original file line number	Diff line number	Diff line change
`@@ -2370,7 +2370,7 @@ def drag_and_drop(`
`2370`	`2370`	`drop_selector, by=drop_by, timeout=timeout`
`2371`	`2371`	`)`
`2372`	`2372`	`self.__demo_mode_highlight_if_active(drop_selector, drop_by)`
`2373`		`- self.scroll_to(drag_selector, by=drag_by)`
	`2373`	`+ self.scroll_to(drop_selector, by=drop_by)`
`2374`	`2374`	`drag_selector = self.convert_to_css_selector(drag_selector, drag_by)`
`2375`	`2375`	`drop_selector = self.convert_to_css_selector(drop_selector, drop_by)`
`2376`	`2376`	`if not jquery:`