Skip to content

Commit f997e57

Browse files
committed
Add better detection for the version of Edge installed
1 parent 22f526f commit f997e57

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

seleniumbase/core/browser_launcher.py

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1435,15 +1435,20 @@ def get_local_driver(
14351435
driver = Edge(service=service, options=edge_options)
14361436
except Exception as e:
14371437
auto_upgrade_edgedriver = False
1438+
edge_version = None
14381439
if "This version of MSEdgeDriver only supports" in e.msg:
14391440
if "Current browser version is " in e.msg:
14401441
auto_upgrade_edgedriver = True
1442+
edge_version = e.msg.split(
1443+
"Current browser version is ")[1].split(' ')[0]
1444+
elif "only supports MSEdge version " in e.msg:
1445+
auto_upgrade_edgedriver = True
1446+
edge_version = e.msg.split(
1447+
"only supports MSEdge version ")[1].split(' ')[0]
14411448
if not auto_upgrade_edgedriver:
14421449
raise Exception(e.msg) # Not an obvious fix. Raise.
14431450
else:
14441451
pass # Try upgrading EdgeDriver to match Edge.
1445-
edge_version = e.msg.split(
1446-
"Current browser version is ")[1].split(' ')[0]
14471452
args = " ".join(sys.argv)
14481453
if ("-n" in sys.argv or " -n=" in args or args == "-c"):
14491454
import fasteners
@@ -1472,15 +1477,20 @@ def get_local_driver(
14721477
)
14731478
except Exception as e:
14741479
auto_upgrade_edgedriver = False
1480+
edge_version = None
14751481
if "This version of MSEdgeDriver only supports" in e.msg:
14761482
if "Current browser version is " in e.msg:
14771483
auto_upgrade_edgedriver = True
1484+
edge_version = e.msg.split(
1485+
"Current browser version is ")[1].split(' ')[0]
1486+
elif "only supports MSEdge version " in e.msg:
1487+
auto_upgrade_edgedriver = True
1488+
edge_version = e.msg.split(
1489+
"only supports MSEdge version ")[1].split(' ')[0]
14781490
if not auto_upgrade_edgedriver:
14791491
raise Exception(e.msg) # Not an obvious fix. Raise.
14801492
else:
14811493
pass # Try upgrading EdgeDriver to match Edge.
1482-
edge_version = e.msg.split(
1483-
"Current browser version is ")[1].split(' ')[0]
14841494
args = " ".join(sys.argv)
14851495
if ("-n" in sys.argv or " -n=" in args or args == "-c"):
14861496
import fasteners

0 commit comments

Comments
 (0)