Merge pull request #712 from seleniumbase/handle-edge-case-with-file-downloads

Handle an edge case with multiple file downloads

Author: mdmintz

.github/Workflows.md

@@ -1,4 +1,4 @@
-### <img src="https://cdn2.hubspot.net/hubfs/100006/images/super_square_logo_3a.png" title="SeleniumBase" height="32"> SeleniumBase Workflows
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> SeleniumBase Workflows
 
 > **Table of Contents / Navigation:**
 > - [**CI build**](workflows/python-package.yml)

help_docs/customizing_test_runs.md

@@ -1,6 +1,6 @@
 [<img src="https://seleniumbase.io/cdn/img/super_logo_sb.png" title="SeleniumBase" width="290">](https://github.com/seleniumbase/SeleniumBase/blob/master/README.md)
 
-<h2><img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> CLI Options</h2>
+<h2><img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> CLI Options</h2>
 
 You can customize test runs from the command-line interface thanks to [SeleniumBase's pytest plugin](https://github.com/seleniumbase/SeleniumBase/blob/master/seleniumbase/plugins/pytest_plugin.py), which adds CLI options for setting/enabling the browser type, headless mode, mobile mode, multithreading mode, demo mode, proxy config, user agent config, browser extensions, and more.
 
@@ -156,14 +156,14 @@ Or the short form:
 sbase options
 ```
 
-### <img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Customizing default settings:
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Customizing default settings:
 
 An easy way to override [seleniumbase/config/settings.py](https://github.com/seleniumbase/SeleniumBase/blob/master/seleniumbase/config/settings.py) is by using a custom settings file.
 Here's the command-line option to add to tests: (See [examples/custom_settings.py](https://github.com/seleniumbase/SeleniumBase/blob/master/examples/custom_settings.py))
 ``--settings-file=custom_settings.py``
 (Settings include default timeout values, a two-factor auth key, DB credentials, S3 credentials, and other important settings used by tests.)
 
-### <img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Running tests on a remote Selenium Grid:
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Running tests on a remote Selenium Grid:
 
 SeleniumBase lets you run tests on remote Selenium Grids such as [BrowserStack](https://www.browserstack.com/automate#)'s Selenium Grid, [Sauce Labs](https://saucelabs.com/products/open-source-frameworks/selenium)'s Selenium Grid, [TestingBot](https://testingbot.com/features)'s Selenium Grid, other Grids, and even your own Grid:
 
@@ -196,15 +196,15 @@ pytest my_first_test.py --server=USERNAME:[email protected] --port=80
 
 Or you can create your own Selenium Grid for test distribution. ([See this ReadMe for details](https://github.com/seleniumbase/SeleniumBase/blob/master/seleniumbase/utilities/selenium_grid/ReadMe.md))
 
-### <img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Example tests using Logging:
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Example tests using Logging:
 
 ```bash
 pytest test_suite.py --browser=chrome
 ```
 
 (During test failures, logs and screenshots from the most recent test run will get saved to the ``latest_logs/`` folder. Those logs will get moved to ``archived_logs/`` if you have ARCHIVE_EXISTING_LOGS set to True in [settings.py](https://github.com/seleniumbase/SeleniumBase/blob/master/seleniumbase/config/settings.py), otherwise log files with be cleaned up at the start of the next test run.)
 
-### <img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Demo Mode:
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Demo Mode:
 
 If any test is moving too fast for your eyes to see what's going on, you can run it in **Demo Mode** by adding ``--demo`` on the command line, which pauses the browser briefly between actions, highlights page elements being acted on, and lets you know what test assertions are happening in real time:
 
@@ -218,22 +218,22 @@ You can override the default wait time by either updating [settings.py](https://
 pytest my_first_test.py --demo --demo-sleep=1.2
 ```
 
-### <img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Passing additional data to tests:
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Passing additional data to tests:
 
 If you want to pass additional data from the command line to your tests, you can use ``--data=STRING``. Now inside your tests, you can use ``self.data`` to access that.
 
-### <img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Running tests multithreaded:
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Running tests multithreaded:
 
 To run Pytest multithreaded on multiple CPUs at the same time, add ``-n=NUM`` or ``-n NUM`` on the command line, where NUM is the number of CPUs you want to use.
 
-### <img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Retrying failing tests automatically:
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Retrying failing tests automatically:
 
 You can use ``--reruns=NUM`` to retry failing tests that many times. Use ``--reruns-delay=SECONDS`` to wait that many seconds between retries. Example:
 ```
 pytest --reruns=2 --reruns-delay=1
 ```
 
-### <img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Debugging tests:
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Debugging tests:
 
 You can use the following calls in your scripts to help you debug issues:
 
@@ -251,7 +251,7 @@ pytest my_first_test.py --pdb -s
 
 The code above will leave your browser window open in case there's a failure. (ipdb commands: 'c', 's', 'n' => continue, step, next).
 
-### <img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Pytest Reports:
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Pytest Reports:
 
 Using ``--html=report.html`` gives you a fancy report of the name specified after your test suite completes.
 
@@ -260,7 +260,7 @@ pytest test_suite.py --html=report.html
 ```
 <img src="https://cdn2.hubspot.net/hubfs/100006/images/pytest_report_3c.png" alt="Example Pytest Report" title="Example Pytest Report" width="520" />
 
-### <img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Nosetest Reports:
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Nosetest Reports:
 
 The ``--report`` option gives you a fancy report after your test suite completes.
 
@@ -271,7 +271,7 @@ nosetests test_suite.py --report
 
 (NOTE: You can add ``--show_report`` to immediately display Nosetest reports after the test suite completes. Only use ``--show_report`` when running tests locally because it pauses the test run.)
 
-### <img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Using a Proxy Server:
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Using a Proxy Server:
 
 If you wish to use a proxy server for your browser tests (Chrome and Firefox only), you can add ``--proxy=IP_ADDRESS:PORT`` as an argument on the command line.
 
@@ -291,15 +291,15 @@ To make things easier, you can add your frequently-used proxies to PROXY_LIST in
 pytest proxy_test.py --proxy=proxy1
 ```
 
-### <img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Changing the User-Agent:
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Changing the User-Agent:
 
 If you wish to change the User-Agent for your browser tests (Chrome and Firefox only), you can add ``--agent="USER-AGENT-STRING"`` as an argument on the command line.
 
 ```bash
 pytest user_agent_test.py --agent="Mozilla/5.0 (Nintendo 3DS; U; ; en) Version/1.7412.EU"
 ```
 
-### <img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Mobile Device Testing:
+### <img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Mobile Device Testing:
 
 Use ``--mobile`` to quickly run your tests using Chrome's mobile device emulator with default values for device metrics (CSS Width, CSS Height, Pixel-Ratio) and a default value set for the user agent. To configure the mobile device metrics, use ``--metrics="CSS_Width,CSS_Height,Pixel_Ratio"`` to set those values. You'll also be able to set the user agent with ``--agent="USER-AGENT-STRING"`` (a default user agent will be used if not specified). To find real values for device metrics, [see this GitHub Gist](https://gist.github.com/sidferreira/3f5fad525e99b395d8bd882ee0fd9d00). For a list of available user agent strings, [check out this page](https://developers.whatismybrowser.com/useragents/explore/).
 

integrations/brython/ReadMe.md

@@ -5,10 +5,12 @@
 
 ### 1. Get a web server up and running:
 
+<i>Run from [SeleniumBase/integrations/brython](https://github.com/seleniumbase/SeleniumBase/tree/master/integrations/brython)</i>:
+
 ```bash
 python -m http.server
 ```
-(You can always stop the server by using ``CTRL-C``.)
+You can always stop the server by using ``CTRL-C``.
 
 ### 2. Navigate to [http://localhost:8000/](http://localhost:8000/)
 

mkdocs.yml

@@ -10,7 +10,7 @@ edit_uri: ""
 site_dir: "site"
 docs_dir: "docs"
 # Copyright
-copyright: Copyright © 2014 - 2020 Michael Mintz / SeleniumBase
+copyright: Copyright © 2014 - 2021 Michael Mintz / SeleniumBase
 # Extensions
 markdown_extensions:
   - markdown.extensions.admonition

requirements.txt

@@ -58,7 +58,7 @@ importlib-metadata==2.0.0
 virtualenv>=20.0.33
 pymysql==0.10.1
 coverage==5.3
-brython==3.8.10
+brython==3.9.0
 pyotp==2.4.0
 boto==2.49.0
 cffi==1.14.3

seleniumbase/ReadMe.md

@@ -1,6 +1,6 @@
 <img src="https://seleniumbase.io/cdn/img/sb_text_f.png" title="SeleniumBase" align="center" width="290">
 
-<h2><img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="24" /> Framework Folders</h2>
+<h2><img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Framework Folders</h2>
 
 * <b>[fixtures](https://github.com/seleniumbase/SeleniumBase/tree/master/seleniumbase/fixtures):</b> Includes [base_case.py](https://github.com/seleniumbase/SeleniumBase/blob/master/seleniumbase/fixtures/base_case.py), where SeleniumBase test methods are defined.
 * <b>[core](https://github.com/seleniumbase/SeleniumBase/tree/master/seleniumbase/core):</b> Includes [browser_launcher.py](https://github.com/seleniumbase/SeleniumBase/blob/master/seleniumbase/core/browser_launcher.py), which is used for spinning up browsers for tests.

seleniumbase/console_scripts/ReadMe.md

@@ -1,6 +1,6 @@
 [<img src="https://seleniumbase.io/cdn/img/super_logo_sb.png" title="SeleniumBase" width="290">](https://github.com/seleniumbase/SeleniumBase/blob/master/README.md)
 
-<h2><img src="https://seleniumbase.io/img/sb_icon.png" title="SeleniumBase" width="30" /> Console Scripts</h2>
+<h2><img src="https://seleniumbase.io/img/logo3a.png" title="SeleniumBase" width="28" /> Console Scripts</h2>
 
 SeleniumBase console scripts help you get things done more easily, such as installing web drivers, creating a test directory with necessary configuration files, converting old WebDriver unittest scripts into SeleniumBase code, translating tests into multiple languages, and using the Selenium Grid.
 

seleniumbase/core/browser_launcher.py

@@ -144,15 +144,15 @@ def _set_chrome_options(
         "download.directory_upgrade": True,
         "safebrowsing.enabled": False,
         "safebrowsing.disable_download_protection": True,
-        "profile": {
-            "password_manager_enabled": False,
-            "default_content_setting_values.automatic_downloads": 1,
-            "managed_default_content_settings.automatic_downloads": 1,
-            "default_content_settings.popups": 0,
-            "managed_default_content_settings.popups": 0,
-            "content_settings.exceptions.automatic_downloads.*.setting": 1,
-            "content_settings.pattern_pairs.*.multiple-automatic-downloads": 1
-        }
+        "default_content_setting_values.notifications": 0,
+        "default_content_settings.popups": 0,
+        "managed_default_content_settings.popups": 0,
+        "content_settings.exceptions.automatic_downloads.*.setting": 1,
+        "profile.password_manager_enabled": False,
+        "profile.default_content_setting_values.notifications": 0,
+        "profile.default_content_settings.popups": 0,
+        "profile.managed_default_content_settings.popups": 0,
+        "profile.default_content_setting_values.automatic_downloads": 1
     }
     if locale_code:
         prefs["intl.accept_languages"] = locale_code
@@ -769,13 +769,15 @@ def get_local_driver(
                 "download.directory_upgrade": True,
                 "safebrowsing.enabled": False,
                 "safebrowsing.disable_download_protection": True,
-                "profile": {
-                    "password_manager_enabled": False,
-                    "default_content_setting_values.automatic_downloads": 1,
-                    "managed_default_content_settings.automatic_downloads": 1,
-                    "default_content_settings.popups": 0,
-                    "managed_default_content_settings.popups": 0
-                }
+                "default_content_setting_values.notifications": 0,
+                "default_content_settings.popups": 0,
+                "managed_default_content_settings.popups": 0,
+                "content_settings.exceptions.automatic_downloads.*.setting": 1,
+                "profile.password_manager_enabled": False,
+                "profile.default_content_setting_values.notifications": 0,
+                "profile.default_content_settings.popups": 0,
+                "profile.managed_default_content_settings.popups": 0,
+                "profile.default_content_setting_values.automatic_downloads": 1
             }
             if locale_code:
                 prefs["intl.accept_languages"] = locale_code

setup.py

@@ -54,7 +54,7 @@
 
 setup(
     name='seleniumbase',
-    version='1.49.24',
+    version='1.49.25',
     description='A complete framework for Web-UI testing | seleniumbase.io',
     long_description=long_description,
     long_description_content_type='text/markdown',
@@ -152,7 +152,7 @@
         'virtualenv>=20.0.33',  # Sync with importlib-metadata and pathlib2
         'pymysql==0.10.1',
         'coverage==5.3',
-        'brython==3.8.10',
+        'brython==3.9.0',
         'pyotp==2.4.0',
         'boto==2.49.0',
         'cffi==1.14.3',