Skip to content

Commit fcd3a91

Browse files
committed
Make the self.get(url) method more flexible
1 parent 2b84777 commit fcd3a91

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

help_docs/method_summary.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,12 @@ For backwards compatibility, older versions of method names have remained to kee
88

99
```python
1010
self.open(url)
11-
# Duplicates: self.open_url(url), self.get(url)
12-
# self.visit(url), visit_url(url), self.goto(url), self.go_to(url)
11+
# Duplicates: self.open_url(url), self.visit(url), visit_url(url),
12+
# self.goto(url), self.go_to(url)
13+
14+
self.get(url)
15+
# If the url parameter is a URL: Perform self.open(url)
16+
# Otherwise: return self.get_element(URL_AS_A_SELECTOR)
1317

1418
self.click(selector, by=By.CSS_SELECTOR, timeout=None, delay=0)
1519

seleniumbase/fixtures/base_case.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,18 @@ def open(self, url):
105105
self.wait_for_ready_state_complete()
106106
self.__demo_mode_pause_if_active()
107107

108+
def get(self, url):
109+
""" If url looks like a page URL, opens the URL in the web browser.
110+
Otherwise, returns self.get_element(URL_AS_A_SELECTOR)
111+
Examples:
112+
self.get("https://seleniumbase.io") # Navigates to the URL
113+
self.get("input.class") # Finds and returns the WebElement
114+
"""
115+
if self.__looks_like_a_page_url(url):
116+
self.open(url)
117+
else:
118+
return self.get_element(url) # url is treated like a selector
119+
108120
def click(self, selector, by=By.CSS_SELECTOR, timeout=None, delay=0):
109121
if not timeout:
110122
timeout = settings.SMALL_TIMEOUT

0 commit comments

Comments
 (0)