Skip to content
This repository was archived by the owner on Jun 22, 2024. It is now read-only.

Commit 5709ba6

Browse files
Attempts to tag multi-arch images by modifying the manifest
1 parent 1e672f6 commit 5709ba6

File tree

9 files changed

+44
-31
lines changed

9 files changed

+44
-31
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ jobs:
163163
- run:
164164
name: "Tag browser images and update latest tag"
165165
command: |
166-
NAME=${NAMESPACE} VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} PUSH_IMAGE=true make tag_and_push_multi_arch_browser_images
166+
NAME=${NAMESPACE} VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} PUSH_IMAGE=true PLATFORMS=${PLATFORMS} make tag_and_push_multi_arch_browser_images
167167
NAME=${NAMESPACE} VERSION=${BRANCH} BUILD_DATE=${BUILD_DATE} make tag_multi_arch_latest
168168
- run:
169169
name: "Generate release notes"

Hub/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
# NOTE: DO *NOT* EDIT THIS FILE. IT IS GENERATED.
33
# PLEASE UPDATE Dockerfile.txt INSTEAD OF THIS FILE
44
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
5-
FROM seleniarm/base:4.1.3-20220331
6-
LABEL authors=SeleniumHQ,sj26,jamesmortensen
5+
FROM seleniarm/base:4.1.4-20220429
6+
LABEL authors=SeleniumHQ
77

88
USER 1200
99

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,10 +244,10 @@ tag_latest:
244244
tag_and_push_multi_arch_browser_images: tag_and_push_multi_arch_chromium_images tag_and_push_multi_arch_firefox_images
245245

246246
tag_and_push_multi_arch_chromium_images:
247-
./tag_and_push_multi-arch_browser_images.sh $(VERSION) $(BUILD_DATE) $(NAMESPACE) $(PUSH_IMAGE) chromium
247+
./tag_and_push_multi-arch_browser_images.sh $(VERSION) $(BUILD_DATE) $(NAMESPACE) $(PUSH_IMAGE) chromium $(PLATFORMS)
248248

249249
tag_and_push_multi_arch_firefox_images:
250-
./tag_and_push_multi-arch_browser_images.sh $(VERSION) $(BUILD_DATE) $(NAMESPACE) $(PUSH_IMAGE) firefox
250+
./tag_and_push_multi-arch_browser_images.sh $(VERSION) $(BUILD_DATE) $(NAMESPACE) $(PUSH_IMAGE) firefox $(PLATFORMS)
251251

252252
tag_multi_arch_latest:
253253
docker tag $(NAME)/base:$(TAG_VERSION) $(NAME)/base:latest

NodeBase/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
# NOTE: DO *NOT* EDIT THIS FILE. IT IS GENERATED.
33
# PLEASE UPDATE Dockerfile.txt INSTEAD OF THIS FILE
44
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
5-
FROM seleniarm/base:4.1.3-20220331
6-
LABEL authors=SeleniumHQ,sj26,jamesmortensen
5+
FROM seleniarm/base:4.1.4-20220429
6+
LABEL authors=SeleniumHQ
77

88
USER root
99

NodeChromium/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
# NOTE: DO *NOT* EDIT THIS FILE. IT IS GENERATED.
33
# PLEASE UPDATE Dockerfile.txt INSTEAD OF THIS FILE
44
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
5-
FROM seleniarm/node-base:4.1.3-20220331
6-
LABEL authors=SeleniumHQ,sj26,jamesmortensen
5+
FROM seleniarm/node-base:4.1.4-20220429
6+
LABEL authors=SeleniumHQ
77

88
USER root
99

NodeFirefox/Dockerfile

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,17 @@
22
# NOTE: DO *NOT* EDIT THIS FILE. IT IS GENERATED.
33
# PLEASE UPDATE Dockerfile.txt INSTEAD OF THIS FILE
44
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
5-
FROM seleniarm/node-base:4.1.3-20220331
6-
LABEL authors=SeleniumHQ,sj26,jamesmortensen
5+
FROM seleniarm/node-base:4.1.4-20220429
6+
LABEL authors=SeleniumHQ
77

88
#FROM local-seleniarm/node-base:4.0.0-20211018
99
#LABEL authors=SeleniumHQ,sj26,jamesmortensen
1010

1111
ARG TARGETARCH
1212
ARG TARGETVARIANT
1313

14+
ARG GECKODRIVER_VERSION=0.31.0
15+
1416
USER root
1517

1618
#=========
@@ -22,11 +24,11 @@ USER root
2224
# && apt-get -qqy install firefox libavcodec-extra \
2325
# && rm -rf /var/lib/apt/lists/* /var/cache/apt/*
2426

25-
# Temporarily installing Firefox 96.0.3 from snapshots since 98.0.2 is broken on arm64
27+
# Pulling Firefox from Debian Snapshots so we can control which version we use as latest
2628
RUN echo "deb http://deb.debian.org/debian/ sid main" >> /etc/apt/sources.list \
2729
&& apt-get update -qqy \
2830
&& apt-get install libavcodec-extra -y \
29-
&& wget https://snapshot.debian.org/archive/debian/20220209T093507Z/pool/main/f/firefox/firefox_96.0.3-1_`dpkg --print-architecture`.deb -O firefox.deb \
31+
&& wget https://snapshot.debian.org/archive/debian/20220418T084218Z/pool/main/f/firefox/firefox_99.0-1_`dpkg --print-architecture`.deb -O firefox.deb \
3032
&& apt install ./firefox.deb -y \
3133
&& rm -rf /var/lib/apt/lists/* /var/cache/apt/* ./firefox.deb
3234

@@ -43,11 +45,11 @@ RUN if [ $TARGETARCH = "arm" ] && [ $TARGETVARIANT = "v7" ]; then \
4345
exit 1 ; \
4446
fi ; \
4547
if [ "$ARCH" = "arm64" ]; then \
46-
wget --no-verbose -O /tmp/geckodriver.tar.gz https://github.com/jamesmortensen/geckodriver-arm-binaries/releases/download/v0.30.0/geckodriver-v0.30.0-linux-aarch64.tar.gz ; \
48+
wget --no-verbose -O /tmp/geckodriver.tar.gz https://github.com/jamesmortensen/geckodriver-arm-binaries/releases/download/v$GECKODRIVER_VERSION/geckodriver-v$GECKODRIVER_VERSION-linux-aarch64.tar.gz ; \
4749
elif [ "$ARCH" = "armhf" ]; then \
48-
wget --no-verbose -O /tmp/geckodriver.tar.gz https://github.com/jamesmortensen/geckodriver-arm-binaries/releases/download/v0.30.0/geckodriver-v0.30.0-linux-armv7l.tar.gz ; \
50+
wget --no-verbose -O /tmp/geckodriver.tar.gz https://github.com/jamesmortensen/geckodriver-arm-binaries/releases/download/v$GECKODRIVER_VERSION/geckodriver-v$GECKODRIVER_VERSION-linux-armv7l.tar.gz ; \
4951
else \
50-
wget --no-verbose -O /tmp/geckodriver.tar.gz https://github.com/mozilla/geckodriver/releases/download/v0.30.0/geckodriver-v0.30.0-linux64.tar.gz ; \
52+
wget --no-verbose -O /tmp/geckodriver.tar.gz https://github.com/mozilla/geckodriver/releases/download/v$GECKODRIVER_VERSION/geckodriver-v$GECKODRIVER_VERSION-linux64.tar.gz ; \
5153
fi ; \
5254
tar -C /tmp -zxf /tmp/geckodriver.tar.gz ; \
5355
rm /tmp/geckodriver.tar.gz ; \

StandaloneChromium/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
# NOTE: DO *NOT* EDIT THIS FILE. IT IS GENERATED.
33
# PLEASE UPDATE Dockerfile.txt INSTEAD OF THIS FILE
44
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
5-
FROM seleniarm/node-chromium:4.1.3-20220331
6-
LABEL authors=SeleniumHQ,sj26,jamesmortensen
5+
FROM seleniarm/node-chromium:4.1.4-20220429
6+
LABEL authors=SeleniumHQ
77

88
USER 1200
99

StandaloneFirefox/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
# NOTE: DO *NOT* EDIT THIS FILE. IT IS GENERATED.
33
# PLEASE UPDATE Dockerfile.txt INSTEAD OF THIS FILE
44
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
5-
FROM seleniarm/node-firefox:4.1.3-20220331
6-
LABEL authors=SeleniumHQ,sj26,jamesmortensen
5+
FROM seleniarm/node-firefox:4.1.4-20220429
6+
LABEL authors=SeleniumHQ
77

88
USER 1200
99

tag_and_push_multi-arch_browser_images.sh

Lines changed: 22 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ BUILD_DATE=$2
55
NAMESPACE=$3
66
PUSH_IMAGE="${4:-false}"
77
BROWSER=$5
8+
PLATFORMS=$6
89

910
TAG_VERSION=${VERSION}-${BUILD_DATE}
1011

@@ -52,16 +53,21 @@ chromium)
5253
${CHROME_SHORT_VERSION}
5354
)
5455

56+
cd NodeChromium
57+
NODE_CHROMIUM_TAGS=""
58+
STANDALONE_CHROMIUM_TAGS=""
5559
for chrome_tag in "${CHROME_TAGS[@]}"
5660
do
57-
docker tag ${NAMESPACE}/node-chromium:${TAG_VERSION} ${NAMESPACE}/node-chromium:${chrome_tag}
58-
docker tag ${NAMESPACE}/standalone-chromium:${TAG_VERSION} ${NAMESPACE}/standalone-chromium:${chrome_tag}
59-
if [ "${PUSH_IMAGE}" = true ]; then
60-
docker push ${NAMESPACE}/node-chromium:${chrome_tag}
61-
docker push ${NAMESPACE}/standalone-chromium:${chrome_tag}
62-
fi
61+
#docker tag ${NAMESPACE}/node-chromium:${TAG_VERSION} ${NAMESPACE}/node-chromium:${chrome_tag}
62+
#docker tag ${NAMESPACE}/standalone-chromium:${TAG_VERSION} ${NAMESPACE}/standalone-chromium:${chrome_tag}
63+
NODE_CHROMIUM_TAGS+=" -t ${NAME}/node-chromium:${chrome_tag}"
64+
STANDALONE_CHROMIUM_TAGS+=" -t ${NAME}/standalone-chromium:${chrome_tag}"
6365
done
64-
66+
if [ "${PUSH_IMAGE}" = true ]; then
67+
cd ../NodeChromium && docker buildx build --platform ${PLATFORMS} --push ${NODE_CHROMIUM_TAGS} .
68+
cd ../StandaloneChromium && docker buildx build --platform ${PLATFORMS} --push ${STANDALONE_CHROMIUM_TAGS} .
69+
fi
70+
6571
;;
6672
firefox)
6773
FIREFOX_VERSION=$(docker run --rm seleniarm/node-firefox:${TAG_VERSION} firefox --version | awk '{print $3}')
@@ -95,13 +101,18 @@ firefox)
95101
${FIREFOX_SHORT_VERSION}
96102
)
97103

104+
#cd NodeFirefox
105+
NODE_FIREFOX_TAGS=""
106+
STANDALONE_FIREFOX_TAGS=""
98107
for firefox_tag in "${FIREFOX_TAGS[@]}"
99108
do
100-
docker tag ${NAMESPACE}/node-firefox:${TAG_VERSION} ${NAMESPACE}/node-firefox:${firefox_tag}
101-
docker tag ${NAMESPACE}/standalone-firefox:${TAG_VERSION} ${NAMESPACE}/standalone-firefox:${firefox_tag}
109+
#docker tag ${NAMESPACE}/node-firefox:${TAG_VERSION} ${NAMESPACE}/node-firefox:${firefox_tag}
110+
#docker tag ${NAMESPACE}/standalone-firefox:${TAG_VERSION} ${NAMESPACE}/standalone-firefox:${firefox_tag}
111+
NODE_FIREFOX_TAGS+=" -t ${NAME}/node-firefox:${firefox_tag}"
112+
STANDALONE_FIREFOX_TAGS+=" -t ${NAME}/standalone-firefox:${firefox_tag}"
102113
if [ "${PUSH_IMAGE}" = true ]; then
103-
docker push ${NAMESPACE}/node-firefox:${firefox_tag}
104-
docker push ${NAMESPACE}/standalone-firefox:${firefox_tag}
114+
cd ../NodeFirefox && docker buildx build --platform ${PLATFORMS} --push ${NODE_FIREFOX_TAGS} .
115+
cd ../StandaloneFirefox && docker buildx build --platform ${PLATFORMS} --push ${STANDALONE_FIREFOX_TAGS} .
105116
fi
106117
done
107118

0 commit comments

Comments
 (0)