Skip to content
This repository was archived by the owner on Jun 22, 2024. It is now read-only.

Commit 7010a13

Browse files
Modified make build process to use --build-arg instead of generate.sh scripts, eliminating the templates. (SeleniumHQ#1656)
* Modified make build process to use --build-arg instead of generate.sh scripts. Removed unneeded txt files and sh files. * Modified test.py to include the FROM_IMAGE_ARGS when building the images using the Docker SDK for Python * Added FROM_IMAGE_ARGS to test.py and the base for FROM_IMAGE_ARGS for the Standalone browser container images. Resolved a warning caused by the Base and video Dockerfiles not needing the FROM_IMAGE_ARGS. Co-authored-by: Diego Molina <[email protected]>
1 parent fe89258 commit 7010a13

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+128
-919
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,3 +146,5 @@ ENV/
146146
/site
147147

148148
# End of https://www.gitignore.io/api/python
149+
.DS_Store
150+

Distributor/Dockerfile

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
2-
# NOTE: DO *NOT* EDIT THIS FILE. IT IS GENERATED.
3-
# PLEASE UPDATE Dockerfile.txt INSTEAD OF THIS FILE
4-
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
5-
FROM selenium/base:4.4.0-20220812
6-
LABEL authors=SeleniumHQ
1+
ARG NAMESPACE
2+
ARG VERSION
3+
ARG AUTHORS
4+
FROM ${NAMESPACE}/base:${VERSION}
5+
LABEL authors=${AUTHORS}
76

87
USER 1200
98

Distributor/Dockerfile.txt

Lines changed: 0 additions & 12 deletions
This file was deleted.

Distributor/generate.sh

Lines changed: 0 additions & 14 deletions
This file was deleted.

EventBus/Dockerfile

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
2-
# NOTE: DO *NOT* EDIT THIS FILE. IT IS GENERATED.
3-
# PLEASE UPDATE Dockerfile.txt INSTEAD OF THIS FILE
4-
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
5-
FROM selenium/base:4.4.0-20220812
6-
LABEL authors=SeleniumHQ
1+
ARG NAMESPACE
2+
ARG VERSION
3+
ARG AUTHORS
4+
FROM ${NAMESPACE}/base:${VERSION}
5+
LABEL authors=${AUTHORS}
76

87
USER 1200
98

EventBus/Dockerfile.txt

Lines changed: 0 additions & 17 deletions
This file was deleted.

EventBus/generate.sh

Lines changed: 0 additions & 14 deletions
This file was deleted.

Hub/Dockerfile

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
2-
# NOTE: DO *NOT* EDIT THIS FILE. IT IS GENERATED.
3-
# PLEASE UPDATE Dockerfile.txt INSTEAD OF THIS FILE
4-
# !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
5-
FROM selenium/base:4.4.0-20220812
6-
LABEL authors=SeleniumHQ
1+
ARG NAMESPACE
2+
ARG VERSION
3+
ARG AUTHORS
4+
FROM ${NAMESPACE}/base:${VERSION}
5+
LABEL authors=${AUTHORS}
76

87
USER 1200
98

Hub/Dockerfile.txt

Lines changed: 0 additions & 21 deletions
This file was deleted.

Hub/generate.sh

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)