Merge branch 'trunk' into full-grid

Author: jamesmortensen

.github/workflows/build-test.yml

@@ -2,11 +2,7 @@ name: Build & test
 
 on:
   push:
-    branches:
-      - trunk
   pull_request:
-    branches:
-      - trunk
 
 permissions:
   contents: read
@@ -25,7 +21,7 @@ jobs:
       - name: Output Docker info
         run: docker info
       - name: Set up Python 3.8
-        uses: actions/setup-python@v4.4.0
+        uses: actions/setup-python@v4.5.0
         with:
           python-version: 3.8
       - name: Get branch name (only for push to branch)

.github/workflows/deploy.yml

@@ -51,25 +51,25 @@ jobs:
           DOCKER_USERNAME: ${{secrets.DOCKER_USERNAME}}
           DOCKER_PASSWORD: ${{secrets.DOCKER_PASSWORD}}
       - name: Deploy new images
-        uses: nick-invision/retry@3e91a01664abd3c5cd539100d10d33b9c5b68482 # v2
+        uses: nick-invision/retry@943e742917ac94714d2f408a0e8320f2d1fcafcd # v2
         with:
           timeout_minutes: 20
           max_attempts: 3
           command: VERSION="${GRID_VERSION}" BUILD_DATE=${BUILD_DATE} make release
       - name: Tag images as latest
-        uses: nick-invision/retry@3e91a01664abd3c5cd539100d10d33b9c5b68482 # v2
+        uses: nick-invision/retry@943e742917ac94714d2f408a0e8320f2d1fcafcd # v2
         with:
           timeout_minutes: 20
           max_attempts: 3
           command: VERSION="${GRID_VERSION}" BUILD_DATE=${BUILD_DATE} make tag_latest
       - name: Deploy latest tag
-        uses: nick-invision/retry@3e91a01664abd3c5cd539100d10d33b9c5b68482 # v2
+        uses: nick-invision/retry@943e742917ac94714d2f408a0e8320f2d1fcafcd # v2
         with:
           timeout_minutes: 20
           max_attempts: 3
           command: VERSION="${GRID_VERSION}" BUILD_DATE=${BUILD_DATE} make release_latest
       - name: Tag browser images
-        uses: nick-invision/retry@3e91a01664abd3c5cd539100d10d33b9c5b68482 # v2
+        uses: nick-invision/retry@943e742917ac94714d2f408a0e8320f2d1fcafcd # v2
         with:
           timeout_minutes: 20
           max_attempts: 3

.github/workflows/helm-chart-release.yml

@@ -23,6 +23,6 @@ jobs:
           git config user.email "[email protected]"
 
       - name: Run chart-releaser
-        uses: helm/chart-releaser-action@v1.4.1
+        uses: helm/chart-releaser-action@v1.5.0
         env:
           CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"

.github/workflows/test-video.yml

@@ -2,11 +2,7 @@ name: Test video files
 
 on:
   push:
-    branches:
-      - trunk
   pull_request:
-    branches:
-      - trunk
 
 permissions:
   contents: read
@@ -22,7 +18,7 @@ jobs:
       - name: Output Docker info
         run: docker info
       - name: Set up Python 3.8
-        uses: actions/setup-python@v4.4.0
+        uses: actions/setup-python@v4.5.0
         with:
           python-version: 3.8
       - name: Get branch name (only for push to branch)

NodeFirefox/Dockerfile.multi-arch

@@ -24,7 +24,7 @@ USER root
 RUN echo "deb http://deb.debian.org/debian/ sid main" >> /etc/apt/sources.list \
   && apt-get update -qqy \
   && apt-get install libavcodec-extra -y \
-  && wget https://snapshot.debian.org/archive/debian/20221204T212138Z/pool/main/f/firefox/firefox_107.0.1-1_`dpkg --print-architecture`.deb -O firefox.deb \
+  && wget https://snapshot.debian.org/archive/debian/20221231T090612Z/pool/main/f/firefox/firefox_108.0-2_`dpkg --print-architecture`.deb -O firefox.deb \
   && apt install ./firefox.deb -y \
   && rm -rf /var/lib/apt/lists/* /var/cache/apt/* ./firefox.deb
 

README.md

@@ -925,12 +925,12 @@ captured in the same video.
 [Chrome](https://developers.google.com/web/updates/2017/04/headless-chrome), 
 When using headless mode, there's no need for the [Xvfb](https://en.wikipedia.org/wiki/Xvfb) server to be started.
 
-To avoid starting the server you can set the `SE_START_XVFB` environment variable to `false` 
+To avoid starting the server you can set the `START_XVFB` environment variable to `false` 
 (or any other value than `true`), for example:
 
 ``` bash
 $ docker run -d --net grid -e SE_EVENT_BUS_HOST=selenium-hub -e SE_EVENT_BUS_PUBLISH_PORT=4442 \
-  -e SE_EVENT_BUS_SUBSCRIBE_PORT=4443 -e SE_START_XVFB=false --shm-size="2g" selenium/node-chrome:4.7.2-20221219
+  -e SE_EVENT_BUS_SUBSCRIBE_PORT=4443 -e START_XVFB=false --shm-size="2g" selenium/node-chrome:4.7.2-20221219
 ```
 
 For more information, see this GitHub [issue](https://github.com/SeleniumHQ/docker-selenium/issues/567).
@@ -1176,15 +1176,24 @@ If you get a prompt asking for a password, it is: `secret`. If you wish to chang
 it in the `/NodeBase/Dockerfile` and build the images yourself, or you can define a Docker image that derives from 
 the posted ones which reconfigures it:
 
+Dockerfile example that extends the `node-chrome:4.7.2-20221219`. You can choose another browser image or a Standalone
+browser image.
+
 ``` dockerfile
-#FROM selenium/node-chrome:4.7.2-20221219
-#FROM selenium/node-edge:4.7.2-20221219
-#FROM selenium/node-firefox:4.7.2-20221219
-#Choose the FROM statement that works for you.
+FROM selenium/node-chrome:4.7.2-20221219
 
 RUN x11vnc -storepasswd <your-password-here> /home/seluser/.vnc/passwd
 ```
 
+Save the `Dockerfile` as `DockerfileVNCPasswordChanged`, open a terminal and on the same directory run:
+
+```shell
+docker build -t selenium/node-chrome-vnc-password-changed:4.7.2-20221219 -f DockerfileVNCPasswordChanged .
+```
+
+And from now on, instead of using `node-chrome:4.7.2-20221219` in your scripts or docker-compose files, use
+`selenium/node-chrome-vnc-password-changed:4.7.2-20221219`.
+
 If you want to run VNC without password authentication you can set the environment variable `SE_VNC_NO_PASSWORD=1`.
 
 If you want to run VNC in view-only mode you can set the environment variable `SE_VNC_VIEW_ONLY=1`.
@@ -1285,7 +1294,7 @@ or
 
 `Message: unknown error: Chrome failed to start: exited abnormally`
 
-The reason _might_ be that you've set the `SE_START_XVFB` environment variable to "false", but forgot to 
+The reason _might_ be that you've set the `START_XVFB` environment variable to "false", but forgot to 
 actually run Firefox, Chrome or Edge in headless mode.
 
 ### Mounting volumes to retrieve downloaded files