Skip to content
This repository was archived by the owner on Jun 22, 2024. It is now read-only.

Commit f231d40

Browse files
committed
bug(chart) CRITICAL: Node startup probe loop infinite when ingress hostname is set
Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent ff3b679 commit f231d40

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

charts/selenium-grid/configs/node/nodePreStop.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,17 @@ function signal_node_to_drain() {
4747

4848
function replace_localhost_by_service_name() {
4949
internal="${SE_HUB_HOST:-$SE_ROUTER_HOST}:${SE_HUB_PORT:-$SE_ROUTER_PORT}"
50+
echo "SE_NODE_GRID_URL: ${SE_NODE_GRID_URL}"
5051
if [[ "${SE_NODE_GRID_URL}" == *"/localhost"* ]]; then
5152
SE_GRID_URL=${SE_NODE_GRID_URL//localhost/${internal}}
5253
elif [[ "${SE_NODE_GRID_URL}" == *"/127.0.0.1"* ]]; then
5354
SE_GRID_URL=${SE_NODE_GRID_URL//127.0.0.1/${internal}}
5455
elif [[ "${SE_NODE_GRID_URL}" == *"/0.0.0.0"* ]]; then
5556
SE_GRID_URL=${SE_NODE_GRID_URL//0.0.0.0/${internal}}
57+
else
58+
SE_GRID_URL=${SE_NODE_GRID_URL}
5659
fi
57-
echo "SE_GRID_URL: ${SE_GRID_URL}"
60+
echo "Set SE_GRID_URL internally: ${SE_GRID_URL}"
5861
}
5962
replace_localhost_by_service_name
6063

charts/selenium-grid/configs/node/nodeProbe.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,17 @@ ID=$(echo $RANDOM)
1010

1111
function replace_localhost_by_service_name() {
1212
internal="${SE_HUB_HOST:-$SE_ROUTER_HOST}:${SE_HUB_PORT:-$SE_ROUTER_PORT}"
13+
echo "SE_NODE_GRID_URL: ${SE_NODE_GRID_URL}"
1314
if [[ "${SE_NODE_GRID_URL}" == *"/localhost"* ]]; then
1415
SE_GRID_URL=${SE_NODE_GRID_URL//localhost/${internal}}
1516
elif [[ "${SE_NODE_GRID_URL}" == *"/127.0.0.1"* ]]; then
1617
SE_GRID_URL=${SE_NODE_GRID_URL//127.0.0.1/${internal}}
1718
elif [[ "${SE_NODE_GRID_URL}" == *"/0.0.0.0"* ]]; then
1819
SE_GRID_URL=${SE_NODE_GRID_URL//0.0.0.0/${internal}}
20+
else
21+
SE_GRID_URL=${SE_NODE_GRID_URL}
1922
fi
20-
echo "SE_GRID_URL: ${SE_GRID_URL}"
23+
echo "Set SE_GRID_URL internally: ${SE_GRID_URL}"
2124
}
2225
replace_localhost_by_service_name
2326

0 commit comments

Comments
 (0)