use beanloader to watch for quota changes

Author: innokenty

proxy/pom.xml

@@ -27,6 +27,12 @@
             <version>${project.version}</version>
         </dependency>
 
+        <dependency>
+            <groupId>ru.yandex.qatools.beanloader</groupId>
+            <artifactId>beanloader</artifactId>
+            <version>2.0</version>
+        </dependency>
+
         <!-- Commons -->
         <dependency>
             <groupId>commons-io</groupId>

proxy/src/main/java/ru/qatools/gridrouter/ConfigRepository.java

@@ -5,36 +5,35 @@
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.stereotype.Repository;
+import ru.qatools.beanloader.BeanChangeListener;
+import ru.qatools.beanloader.BeanWatcher;
 import ru.qatools.gridrouter.config.Browser;
 import ru.qatools.gridrouter.config.Browsers;
 import ru.qatools.gridrouter.config.Version;
 import ru.qatools.gridrouter.json.JsonCapabilities;
 
 import javax.annotation.PostConstruct;
-import javax.annotation.PreDestroy;
 import javax.xml.bind.JAXB;
 import javax.xml.bind.JAXBException;
 import java.io.File;
 import java.io.IOException;
-import java.nio.file.DirectoryStream;
 import java.nio.file.Path;
 import java.util.HashMap;
 import java.util.Map;
 
 import static java.nio.file.Files.newDirectoryStream;
-import static ru.qatools.gridrouter.utils.DirectoryWatcher.newWatcher;
 
 /**
  * @author Alexander Andyashin [email protected]
  * @author Dmitry Baev [email protected]
  * @author Innokenty Shuvalov [email protected]
  */
 @Repository
-public class ConfigRepository {
+public class ConfigRepository implements BeanChangeListener<Browsers> {
 
     private static final Logger LOGGER = LoggerFactory.getLogger(ConfigRepository.class);
 
-    public static final String XML_GLOB = "*.xml";
+    private static final String XML_GLOB = "*.xml";
 
     @Value("${grid.config.quota.directory}")
     private File quotaDirectory;
@@ -46,62 +45,42 @@ public class ConfigRepository {
 
     private Map<String, String> routes = new HashMap<>();
 
-    private Thread quotaWatcherThread;
-
     @PostConstruct
     public void init() throws JAXBException, IOException {
-        initBrowsers(getQuotaPath());
         if (isQuotaHotReload()) {
             startQuotaWatcher();
-        }
-    }
-
-    @PreDestroy
-    public void destroy() {
-        if (isQuotaHotReload()) {
-            stopQuotaWatcher();
+        } else {
+            loadQuotaOnce(getQuotaPath());
         }
     }
 
     private void startQuotaWatcher() {
         LOGGER.debug("Starting quota watcher");
-        setQuotaWatcherThread(newWatcher(getQuotaPath(), "glob:" + XML_GLOB, (kind, browserPath) -> {
-            LOGGER.info("Reload configuration [{}] on event [{}]", browserPath, kind.name());
-            initBrowsers(getQuotaPath());
-        }));
-        getQuotaWatcherThread().start();
-
+        try {
+            BeanWatcher.watchFor(Browsers.class, getQuotaPath().toString(), XML_GLOB, this);
+        } catch (IOException e) {
+            LOGGER.error("Quota configuration loading failed: \n\n{}", e);
+        }
     }
 
-    private void stopQuotaWatcher() {
-        LOGGER.debug("Stopping quota watcher");
-        if (getQuotaWatcherThread() != null && getQuotaWatcherThread().isAlive()) {
-            getQuotaWatcherThread().interrupt();
+    private void loadQuotaOnce(Path quotaPath) throws IOException {
+        for (Path filename : newDirectoryStream(quotaPath, XML_GLOB)) {
+            beanChanged(filename, JAXB.unmarshal(filename.toFile(), Browsers.class));
         }
     }
 
-    public void initBrowsers(Path quotaPath) {
-        Map<String, Browsers> temporaryUserBrowsers = new HashMap<>(getUserBrowsers());
-        Map<String, String> temporaryRoutes = new HashMap<>(getRoutes());
-        try (DirectoryStream<Path> stream = newDirectoryStream(quotaPath, XML_GLOB)) {
-            for (Path browsersPath : stream) {
-                LOGGER.info("Load configuration from [{}]", browsersPath);
-                String user = getFileName(browsersPath);
-                try {
-                    Browsers browsers = JAXB.unmarshal(browsersPath.toFile(), Browsers.class);
-                    temporaryUserBrowsers.put(user, browsers);
-                    temporaryRoutes.putAll(browsers.getRoutesMap());
-
-                    LOGGER.info("Loaded configuration for [{}] from [{}]: \n\n{}",
-                            user, browsersPath, browsers.toXml());
-                } catch (Exception e) {
-                    LOGGER.error("Loaded configuration failed for [{}]: \n\n{}", browsersPath, e);
-                }
-            }
-            setUserBrowsers(temporaryUserBrowsers);
-            setRoutes(temporaryRoutes);
-        } catch (IOException e) {
-            LOGGER.error("Loaded configuration failed: \n\n{}", e);
+    @Override
+    public void beanChanged(Path filename, Browsers browsers) {
+        if (browsers == null) {
+            LOGGER.info("Configuration file [{}] was deleted. "
+                    + "It is not purged from the running gridrouter process though.", filename);
+        } else {
+            LOGGER.info("Loading quota configuration file [{}]", filename);
+            String user = getFileName(filename);
+            userBrowsers.put(user, browsers);
+            routes.putAll(browsers.getRoutesMap());
+            LOGGER.info("Loaded quota configuration for [{}] from [{}]: \n\n{}",
+                    user, filename, browsers.toXml());
         }
     }
 
@@ -117,10 +96,6 @@ public Map<String, String> getRoutes() {
         return routes;
     }
 
-    protected void setRoutes(Map<String, String> routes) {
-        this.routes = routes;
-    }
-
     public Map<String, Browsers> getUserBrowsers() {
         return this.userBrowsers;
     }
@@ -129,10 +104,6 @@ protected Browsers getUserBrowsers(String user) {
         return getUserBrowsers().get(user);
     }
 
-    protected void setUserBrowsers(Map<String, Browsers> userBrowsers) {
-        this.userBrowsers = userBrowsers;
-    }
-
     public Version findVersion(String user, JsonCapabilities caps) {
         return userBrowsers.get(user).find(caps.getBrowserName(), caps.getVersion());
     }
@@ -150,13 +121,4 @@ public Map<String, Integer> getBrowsersCountMap(String user) {
         }
         return countMap;
     }
-
-    public Thread getQuotaWatcherThread() {
-        return quotaWatcherThread;
-    }
-
-    public void setQuotaWatcherThread(Thread quotaWatcherThread) {
-        this.quotaWatcherThread = quotaWatcherThread;
-    }
-
 }