Skip to content

Commit b4592a8

Browse files
committed
Add route param to stats counter
1 parent ea4f53b commit b4592a8

File tree

4 files changed

+23
-9
lines changed

4 files changed

+23
-9
lines changed

proxy/src/main/java/ru/qatools/gridrouter/ProxyServlet.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ protected String rewriteTarget(HttpServletRequest request) {
8787

8888
if (isSessionDeleteRequest(request, command)) {
8989
LOGGER.info("[SESSION_DELETED] [{}] [{}] [{}]", remoteHost, route, command);
90-
statsCounter.deleteSession(getFullSessionId(uri));
90+
statsCounter.deleteSession(getFullSessionId(uri), route);
9191
} else {
92-
statsCounter.updateSession(getFullSessionId(uri));
92+
statsCounter.updateSession(getFullSessionId(uri), route);
9393
}
9494

9595
try {

proxy/src/main/java/ru/qatools/gridrouter/RouteServlet.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ protected void doPost(HttpServletRequest request, HttpServletResponse response)
116116
replyWithOk(hubMessage, response);
117117
LOGGER.info("[SESSION_CREATED] [{}] [{}] [{}] [{}] [{}] [{}]",
118118
user, remoteHost, browser, route, sessionId, attempt);
119-
statsCounter.startSession(hubMessage.getSessionId(), user, browser, actualVersion.getNumber());
119+
statsCounter.startSession(hubMessage.getSessionId(), user, browser, actualVersion.getNumber(), route);
120120
return;
121121
}
122122
LOGGER.warn("[SESSION_FAILED] [{}] [{}] [{}] [{}] - {}",

proxy/src/main/java/ru/qatools/gridrouter/sessions/MemoryStatsCounter.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public class MemoryStatsCounter implements StatsCounter {
2121
private final Map<String, BrowsersCountMap> user2browserCount = new HashMap<>();
2222

2323
@Override
24-
public synchronized void startSession(String sessionId, String user, String browser, String version) {
24+
public synchronized void startSession(String sessionId, String user, String browser, String version, String route) {
2525
if (session2instant.put(sessionId, now()) == null) {
2626
session2user.put(sessionId, user);
2727
session2browserVersion.put(sessionId, new BrowserVersion(browser, version));
@@ -31,12 +31,12 @@ public synchronized void startSession(String sessionId, String user, String brow
3131
}
3232

3333
@Override
34-
public void updateSession(String sessionId) {
34+
public void updateSession(String sessionId, String route) {
3535
session2instant.replace(sessionId, now());
3636
}
3737

3838
@Override
39-
public synchronized void deleteSession(String sessionId) {
39+
public synchronized void deleteSession(String sessionId, String route) {
4040
if (session2instant.remove(sessionId) != null) {
4141
String user = session2user.remove(sessionId);
4242
BrowserVersion browser = session2browserVersion.remove(sessionId);

proxy/src/main/java/ru/qatools/gridrouter/sessions/StatsCounter.java

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,25 @@
88
*/
99
public interface StatsCounter {
1010

11-
void startSession(String sessionId, String user, String browser, String version);
11+
default void startSession(String sessionId, String user, String browser, String version) {
12+
startSession(sessionId, user, browser, version, null);
13+
}
1214

13-
void updateSession(String sessionId);
15+
default void updateSession(String sessionId) {
16+
updateSession(sessionId, null);
17+
}
1418

15-
void deleteSession(String sessionId);
19+
default void deleteSession(String sessionId) {
20+
deleteSession(sessionId, null);
21+
}
22+
23+
void startSession(String sessionId, String user, String browser, String version, String route);
24+
25+
default void updateSession(String sessionId, String route) {
26+
27+
}
28+
29+
void deleteSession(String sessionId, String route);
1630

1731
void expireSessionsOlderThan(Duration duration);
1832

0 commit comments

Comments
 (0)