rename shorten-url with create-shorten-url

Author: selimyanat

api/src/shorten-url/create-shorten-url/shorten-url.controller.spec.ts renamed to api/src/shorten-url/create-shorten-url/create-shorten-url.controller.spec.ts

@@ -1,17 +1,17 @@
 import { Test, TestingModule } from '@nestjs/testing';
-import { ShortenUrlController } from './shorten-url.controller';
+import { CreateShortenUrlController } from './create-shorten-url.controller';
 import { ConfigModule } from '@nestjs/config';
 import { ShortenUrlModule } from '../shorten-url.module';
 
 describe('ShortenUrl controller', () => {
-  let underTest: ShortenUrlController;
+  let underTest: CreateShortenUrlController;
 
   beforeEach(async () => {
     const app: TestingModule = await Test.createTestingModule({
       imports: [await ConfigModule.forRoot(), ShortenUrlModule],
     }).compile();
 
-    underTest = app.get<ShortenUrlController>(ShortenUrlController);
+    underTest = app.get<CreateShortenUrlController>(CreateShortenUrlController);
   });
 
   describe('shortenUrl', () => {

api/src/shorten-url/create-shorten-url/shorten-url.controller.ts renamed to api/src/shorten-url/create-shorten-url/create-shorten-url.controller.ts

@@ -1,16 +1,15 @@
 import { Body, Controller, Logger, Post } from '@nestjs/common';
-import { ShortenUrlUsecase } from './shorten-url.usecase';
+import { CreateShortenUrlUsecase } from './create-shorten-url.usecase';
 import { CreateShortenUrlDto } from './create-shorten-url.dto';
 
 @Controller('/shorten-url')
-export class ShortenUrlController {
-  constructor(private readonly shortenUrlUsecase: ShortenUrlUsecase) {}
+export class CreateShortenUrlController {
+  constructor(private readonly shortenUrlUsecase: CreateShortenUrlUsecase) {}
 
   @Post()
   async shortenUrl(
     @Body() request: CreateShortenUrlDto,
   ): Promise<{ shortenedUrl: string }> {
-    Logger.log(`Received url ${request.url} to shorten`);
     // TODO perhaps it is worth converting the URL from string to URL object
     const shortenedUrl = await this.shortenUrlUsecase.shortenUrl(request.url);
     return { shortenedUrl };

api/src/shorten-url/create-shorten-url/shorten-url.usecase.ts renamed to api/src/shorten-url/create-shorten-url/create-shorten-url.usecase.ts

@@ -4,11 +4,11 @@ import { ShortenUrlRepository } from '../shorten-url.repository';
 import { ConfigService } from '@nestjs/config';
 
 @Injectable()
-export class ShortenUrlUsecase {
+export class CreateShortenUrlUsecase {
   private static BASE62_CHARACTERS =
     '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz';
 
-  private static BASE62 = ShortenUrlUsecase.BASE62_CHARACTERS.length;
+  private static BASE62 = CreateShortenUrlUsecase.BASE62_CHARACTERS.length;
 
   private readonly shortenedBaseUrl: string;
 
@@ -35,13 +35,13 @@ export class ShortenUrlUsecase {
   }
 
   private encodeBase62(id: number): string {
-    if (id === 0) return ShortenUrlUsecase.BASE62_CHARACTERS[0];
+    if (id === 0) return CreateShortenUrlUsecase.BASE62_CHARACTERS[0];
 
     let encoded = '';
     while (id > 0) {
-      const remainder = id % ShortenUrlUsecase.BASE62;
-      encoded = ShortenUrlUsecase.BASE62_CHARACTERS[remainder] + encoded;
-      id = Math.floor(id / ShortenUrlUsecase.BASE62);
+      const remainder = id % CreateShortenUrlUsecase.BASE62;
+      encoded = CreateShortenUrlUsecase.BASE62_CHARACTERS[remainder] + encoded;
+      id = Math.floor(id / CreateShortenUrlUsecase.BASE62);
     }
     return encoded;
   }

api/src/shorten-url/redirect-to-original-url/redirect-to-original-url-controller.spec.ts

@@ -1,19 +1,21 @@
-import { ShortenUrlController } from '../create-shorten-url/shorten-url.controller';
+import { CreateShortenUrlController } from '../create-shorten-url/create-shorten-url.controller';
 import { RedirectToOriginalUrlController } from './redirect-to-original-url.controller';
 import { Test, TestingModule } from '@nestjs/testing';
 import { ConfigModule } from '@nestjs/config';
 import { ShortenUrlModule } from '../shorten-url.module';
 
 describe('Redirect to original url controller', () => {
-  let shortenUrlController: ShortenUrlController;
+  let shortenUrlController: CreateShortenUrlController;
   let underTest: RedirectToOriginalUrlController;
 
   beforeEach(async () => {
     const app: TestingModule = await Test.createTestingModule({
       imports: [await ConfigModule.forRoot(), ShortenUrlModule],
     }).compile();
 
-    shortenUrlController = app.get<ShortenUrlController>(ShortenUrlController);
+    shortenUrlController = app.get<CreateShortenUrlController>(
+      CreateShortenUrlController,
+    );
     underTest = app.get<RedirectToOriginalUrlController>(
       RedirectToOriginalUrlController,
     );

api/src/shorten-url/redirect-to-original-url/redirect-to-original-url.controller.ts

@@ -16,7 +16,9 @@ export class RedirectToOriginalUrlController {
   @Get(':slug')
   @Redirect(undefined, 302)
   async redirectToOriginalUrl(@Param('slug') slug: string) {
-    const originalUrl = await this.getOriginalUrlUsecase.getOriginalUrl(slug);
+    const originalUrl = await this.getOriginalUrlUsecase.redirectToOriginalUrl(
+      slug,
+    );
     if (!originalUrl) {
       throw new NotFoundException(`Shortened URL "${slug}" not found`);
     }

api/src/shorten-url/redirect-to-original-url/redirect-to-original-url.usecase.ts

@@ -8,9 +8,9 @@ export class RedirectToOriginalUrlUsecase {
     private readonly shortenUrlRepository: ShortenUrlRepository,
   ) {}
 
-  async getOriginalUrl(shortenedUrl: string): Promise<string | null> {
+  async redirectToOriginalUrl(slug: string): Promise<string | null> {
     // TODO: reconstruct the URL ? or store only the shorted path ??
-    const url = 'http://localhost:3000/' + shortenedUrl;
+    const url = 'http://localhost:3000/' + slug;
     return await this.shortenUrlRepository.findOriginalURL(url);
   }
 }

api/src/shorten-url/shorten-url.module.ts

@@ -1,7 +1,7 @@
 import { Module } from '@nestjs/common';
 import { ConfigModule } from '@nestjs/config';
-import { ShortenUrlController } from './create-shorten-url/shorten-url.controller';
-import { ShortenUrlUsecase } from './create-shorten-url/shorten-url.usecase';
+import { CreateShortenUrlController } from './create-shorten-url/create-shorten-url.controller';
+import { CreateShortenUrlUsecase } from './create-shorten-url/create-shorten-url.usecase';
 import { ShortenUrlIdGeneratorService } from './create-shorten-url/shorten-url.id-generator.service';
 import { InfrastructureModule } from '../infrastructure/infrastructure.module';
 import { ShortenUrlRepository } from './shorten-url.repository';
@@ -13,14 +13,14 @@ import { RedirectToOriginalUrlController } from './redirect-to-original-url/redi
     ConfigModule, // ✅ Ensure ConfigModule is available
     InfrastructureModule.register(), // ✅ Register InfrastructureModule dynamically
   ],
-  controllers: [ShortenUrlController, RedirectToOriginalUrlController],
+  controllers: [CreateShortenUrlController, RedirectToOriginalUrlController],
   providers: [
     {
       provide: 'ShortenUrlRepository',
       useExisting: ShortenUrlRepository, // ✅ Use injected provider
     },
     ShortenUrlIdGeneratorService,
-    ShortenUrlUsecase,
+    CreateShortenUrlUsecase,
     RedirectToOriginalUrlUsecase,
   ],
 })