ci: Lint with XO

Author: pvdlg

lib/index.js

@@ -8,12 +8,6 @@ const compareReleaseTypes = require('./compare-release-types');
 const RELEASE_TYPES = require('./default/release-types');
 const DEFAULT_RELEASE_RULES = require('./default/release-rules');
 
-/**
- * @callback commitAnalyzerCallback
- * @param {Error} error error object.
- * @param {string} changelog changelog generated by the plugin.
- */
-
 /**
  * Determine the type of release to create based on a list of commits.
  *
@@ -24,9 +18,8 @@ const DEFAULT_RELEASE_RULES = require('./default/release-rules');
  * @param {Object} pluginConfig.parserOpts additional `conventional-changelog-parser` options that will overwrite ones loaded by `preset` or `config`.
  * @param {Object} options semantic-release options
  * @param {Array} options.commits array of commits
- * @param {commitAnalyzerCallback} callback The callback called with the release type.
  */
-async function commitAnalyzer(pluginConfig, {commits, logger}, callback) {
+async function commitAnalyzer(pluginConfig, {commits, logger}) {
   const releaseRules = loadReleaseRules(pluginConfig);
   const config = await loadParserConfig(pluginConfig);
   let releaseType = null;

lib/load/release-rules.js

@@ -20,7 +20,7 @@ module.exports = ({releaseRules}) => {
         : releaseRules;
 
     if (!Array.isArray(loadedReleaseRules)) {
-      throw new Error('Error in commit-analyzer configuration: "releaseRules" must be an array of rules');
+      throw new TypeError('Error in commit-analyzer configuration: "releaseRules" must be an array of rules');
     }
 
     loadedReleaseRules.forEach(rule => {

package.json

@@ -32,35 +32,18 @@
     "conventional-changelog-express": "^0.2.0",
     "conventional-changelog-jshint": "^0.2.0",
     "cz-conventional-changelog": "^2.0.0",
-    "eslint": "^4.5.0",
     "eslint-config-prettier": "^2.3.0",
-    "eslint-config-standard": "^10.2.1",
-    "eslint-plugin-import": "^2.7.0",
-    "eslint-plugin-node": "^5.1.1",
     "eslint-plugin-prettier": "^2.3.0",
-    "eslint-plugin-promise": "^3.5.0",
-    "eslint-plugin-standard": "^3.0.1",
     "nyc": "^11.1.0",
     "prettier": "~1.8.0",
     "rimraf": "^2.6.1",
     "semantic-release": "^9.0.2",
-    "sinon": "^4.0.2"
+    "sinon": "^4.0.2",
+    "xo": "^0.18.2"
   },
   "engines": {
     "node": ">=4"
   },
-  "eslintConfig": {
-    "extends": [
-      "standard",
-      "prettier"
-    ],
-    "plugins": [
-      "prettier"
-    ],
-    "rules": {
-      "prettier/prettier": 2
-    }
-  },
   "files": [
     "lib"
   ],
@@ -107,12 +90,22 @@
     "url": "https://github.com/semantic-release/commit-analyzer.git"
   },
   "scripts": {
-    "clean": "rimraf coverage && rimraf .nyc_output",
     "cm": "git-cz",
     "codecov": "codecov -f coverage/coverage-final.json",
-    "lint": "eslint lib test",
-    "pretest": "npm run clean && npm run lint",
+    "lint": "xo",
+    "pretest": "npm run lint",
     "semantic-release": "semantic-release",
     "test": "nyc ava -v"
+  },
+  "xo": {
+    "extends": [
+      "prettier"
+    ],
+    "plugins": [
+      "prettier"
+    ],
+    "rules": {
+      "prettier/prettier": 2
+    }
   }
 }