test: adapt addChannel test

Author: gr2m

index.js

@@ -10,7 +10,7 @@ import failGitHub from './lib/fail.js';
 
 let verified;
 
-async function verifyConditions(pluginConfig, context) {
+export async function verifyConditions(pluginConfig, context) {
   const {options} = context;
   // If the GitHub publish plugin is used and has `assets`, `successComment`, `failComment`, `failTitle`, `labels` or `assignees` configured, validate it now in order to prevent any release if the configuration is wrong
   if (options.publish) {
@@ -29,7 +29,7 @@ async function verifyConditions(pluginConfig, context) {
   verified = true;
 }
 
-async function publish(pluginConfig, context) {
+export async function publish(pluginConfig, context) {
   if (!verified) {
     await verifyGitHub(pluginConfig, context);
     verified = true;
@@ -38,7 +38,7 @@ async function publish(pluginConfig, context) {
   return publishGitHub(pluginConfig, context);
 }
 
-async function addChannel(pluginConfig, context) {
+export async function addChannel(pluginConfig, context) {
   if (!verified) {
     await verifyGitHub(pluginConfig, context);
     verified = true;
@@ -47,7 +47,7 @@ async function addChannel(pluginConfig, context) {
   return addChannelGitHub(pluginConfig, context);
 }
 
-async function success(pluginConfig, context) {
+export async function success(pluginConfig, context) {
   if (!verified) {
     await verifyGitHub(pluginConfig, context);
     verified = true;
@@ -56,7 +56,7 @@ async function success(pluginConfig, context) {
   await successGitHub(pluginConfig, context);
 }
 
-async function fail(pluginConfig, context) {
+export async function fail(pluginConfig, context) {
   if (!verified) {
     await verifyGitHub(pluginConfig, context);
     verified = true;
@@ -65,6 +65,3 @@ async function fail(pluginConfig, context) {
   await failGitHub(pluginConfig, context);
 }
 
-const plugin = {verifyConditions, addChannel, publish, success, fail};
-
-export default plugin;

lib/definitions/constants.js

@@ -1,7 +1,3 @@
-const ISSUE_ID = '<!-- semantic-release:github -->';
+export const ISSUE_ID = '<!-- semantic-release:github -->';
 
-const RELEASE_NAME = 'GitHub release';
-
-const CONSTANTS = {ISSUE_ID, RELEASE_NAME};
-
-export default CONSTANTS;
+export const RELEASE_NAME = 'GitHub release';

lib/definitions/rate-limit.js

@@ -1,15 +1,15 @@
 /**
  * Default exponential backoff configuration for retries.
  */
-const RETRY_CONF = {retries: 3, factor: 2, minTimeout: 1000};
+export const RETRY_CONF = {retries: 3, factor: 2, minTimeout: 1000};
 
 /**
  * Rate limit per API endpoints.
  *
  * See {@link https://developer.github.com/v3/search/#rate-limit|Search API rate limit}.
  * See {@link https://developer.github.com/v3/#rate-limiting|Rate limiting}.
  */
-const RATE_LIMITS = {
+export const RATE_LIMITS = {
   search: ((60 * 1000) / 30) * 1.1, // 30 calls per minutes => 1 call every 2s + 10% safety margin
   core: {
     read: ((60 * 60 * 1000) / 5000) * 1.1, // 5000 calls per hour => 1 call per 720ms + 10% safety margin
@@ -22,8 +22,4 @@ const RATE_LIMITS = {
  *
  * See {@link https://developer.github.com/v3/guides/best-practices-for-integrators/#dealing-with-abuse-rate-limits|Dealing with abuse rate limits}
  */
-const GLOBAL_RATE_LIMIT = 1000;
-
-const RATE_LIMIT = {RETRY_CONF, RATE_LIMITS, GLOBAL_RATE_LIMIT};
-
-export default RATE_LIMIT;
+export const GLOBAL_RATE_LIMIT = 1000;

test/add-channel.test.js

@@ -1,27 +1,27 @@
 import test from 'ava';
-import {cleanAll} from 'nock';
-import {stub} from 'sinon';
-import proxyquire from 'proxyquire';
+import nock from 'nock';
+import sinon from 'sinon';
+import quibble from "quibble"
 
 import {authenticate} from './helpers/mock-github.js';
-import rateLimit from './helpers/rate-limit.js';
+import * as RATE_LIMIT from './helpers/rate-limit.js';
 
 /* eslint camelcase: ["error", {properties: "never"}] */
 
-const addChannel = proxyquire('../lib/add-channel', {
-  './get-client': proxyquire('../lib/get-client', {'./definitions/rate-limit': rateLimit}),
-});
+// mock rate limit imported via lib/get-client.js
+await quibble.esm('../lib/definitions/rate-limit.js', RATE_LIMIT)
+const addChannel = (await import('../lib/add-channel.js')).default
 
 test.beforeEach((t) => {
   // Mock logger
-  t.context.log = stub();
-  t.context.error = stub();
+  t.context.log = sinon.stub();
+  t.context.error = sinon.stub();
   t.context.logger = {log: t.context.log, error: t.context.error};
 });
 
 test.afterEach.always(() => {
   // Clear nock
-  cleanAll();
+  nock.cleanAll();
 });
 
 test.serial('Update a release', async (t) => {

test/helpers/mock-github.js

@@ -9,7 +9,7 @@ import nock from 'nock';
  * @param {String} [githubApiPathPrefix=env.GH_PREFIX || env.GITHUB_PREFIX || ''] The GitHub Enterprise API prefix.
  * @return {Object} A `nock` object ready to respond to a github authentication request.
  */
-function authenticate(
+export function authenticate(
   env = {},
   {
     githubToken = env.GH_TOKEN || env.GITHUB_TOKEN || 'GH_TOKEN',
@@ -28,7 +28,7 @@ function authenticate(
  * @param {String} [uploadUrl] The url on which to intercept http requests.
  * @return {Object} A `nock` object ready to respond to a github file upload request.
  */
-function upload(
+export function upload(
   env = {},
   {
     githubToken = env.GH_TOKEN || env.GITHUB_TOKEN || 'GH_TOKEN',
@@ -41,6 +41,3 @@ function upload(
     reqheaders: {Authorization: `token ${githubToken}`, 'content-type': contentType, 'content-length': contentLength},
   });
 }
-
-const mockGithub = {authenticate, upload};
-export default mockGithub;

test/helpers/rate-limit.js

@@ -1,8 +1,5 @@
-const RETRY_CONF = {retries: 3, factor: 1, minTimeout: 1, maxTimeout: 1};
+export const RETRY_CONF = {retries: 3, factor: 1, minTimeout: 1, maxTimeout: 1};
 
-const RATE_LIMITS = {search: 1, core: {read: 1, write: 1}};
+export const RATE_LIMITS = {search: 1, core: {read: 1, write: 1}};
 
-const GLOBAL_RATE_LIMIT = 1;
-
-const RATE_LIMIT = {RETRY_CONF, RATE_LIMITS, GLOBAL_RATE_LIMIT};
-export default RATE_LIMIT;
+export const GLOBAL_RATE_LIMIT = 1;