Skip to content

Commit 54aef02

Browse files
Merge remote-tracking branch 'semantic-release/master'
2 parents 5b00e1a + 7f079f7 commit 54aef02

File tree

7 files changed

+354
-1534
lines changed

7 files changed

+354
-1534
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
runs-on: ubuntu-latest
2020
steps:
2121
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
22-
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
22+
- uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
2323
with:
2424
cache: npm
2525
node-version: lts/*

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
steps:
2929
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
3030
- name: "Use Node.js ${{ matrix.node-version }}"
31-
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
31+
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
3232
with:
3333
node-version: "${{ matrix.node-version }}"
3434
cache: npm
@@ -46,7 +46,7 @@ jobs:
4646
- run: git config --global user.name github-actions
4747
- run: git config --global user.email [email protected]
4848
- name: Use Node.js from .nvmrc
49-
uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
49+
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
5050
with:
5151
node-version-file: .nvmrc
5252
cache: npm

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ When using the _GITHUB_TOKEN_, the **minimum required permissions** are:
9595
| `releasedLabels` | The [labels](https://help.github.com/articles/about-labels) to add to each issue and pull request resolved by the release. Set to `false` to not add any label. See [releasedLabels](#releasedlabels). | `['released<%= nextRelease.channel ? \` on @\${nextRelease.channel}\` : "" %>']- |
9696
| `addReleases` | Will add release links to the GitHub Release. Can be `false`, `"bottom"` or `"top"`. See [addReleases](#addReleases). | `false` |
9797
| `draftRelease` | A boolean indicating if a GitHub Draft Release should be created instead of publishing an actual GitHub Release. | `false` |
98-
| `releaseNameTemplate` | A [Lodash template](https://lodash.com/docs#template) to customize the github release's name | `<%= nextverison.name %>` |
99-
| `releaseBodyTemplate` | A [Lodash template](https://lodash.com/docs#template) to customize the github release's body | `<%= nextverison.notes %>` |
98+
| `releaseNameTemplate` | A [Lodash template](https://lodash.com/docs#template) to customize the github release's name | `<%= nextRelease.name %>` |
99+
| `releaseBodyTemplate` | A [Lodash template](https://lodash.com/docs#template) to customize the github release's body | `<%= nextRelease.notes %>` |
100100
| `discussionCategoryName` | The category name in which to create a linked discussion to the release. Set to `false` to disable creating discussion for a release. | `false` |
101101

102102
#### proxy

lib/success.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,13 @@ export default async function success(pluginConfig, context, { Octokit }) {
5454

5555
const errors = [];
5656

57-
if (successComment === false && releasedLabels === false) {
57+
if (
58+
(successComment === false && releasedLabels === false) ||
59+
isEmpty(commits)
60+
) {
61+
if (isEmpty(commits)) {
62+
logger.log("No commits found in release");
63+
}
5864
logger.log("Skip commenting / adding labels on issues and pull requests.");
5965
} else {
6066
const parser = issueParser(

0 commit comments

Comments
 (0)