fix(latest): add make_latest property to the GH release PATCH request during publish (#1169)

* fix(latest): add make_latest property to the GH release PATCH request during publish

It's required to not mark as latest when removing draft status after assets upload

* test: fix tests

Author: viceice

lib/publish.js

@@ -167,6 +167,7 @@ export default async function publish(pluginConfig, context, { Octokit }) {
     repo,
     release_id: releaseId,
     draft: false,
+    make_latest: isLatestRelease(branch),
   };
 
   // add discussion_category_name if discussionCategoryName is not undefined or false

test/integration.test.js

@@ -418,7 +418,7 @@ test("Publish a release with an array of assets", async (t) => {
       `https://api.github.local/repos/${owner}/${repo}/releases/${releaseId}`,
       { html_url: releaseUrl },
       {
-        body: { draft: false },
+        body: { draft: false, make_latest: "true" },
       },
     )
     .postOnce(
@@ -514,7 +514,7 @@ test("Publish a release with release information in assets", async (t) => {
       `https://api.github.local/repos/${owner}/${repo}/releases/${releaseId}`,
       { html_url: releaseUrl },
       {
-        body: { draft: false },
+        body: { draft: false, make_latest: "false" },
       },
     )
     .postOnce(
@@ -910,7 +910,7 @@ test("Verify, release and notify success", async (t) => {
     .patchOnce(
       `https://api.github.local/repos/${owner}/${repo}/releases/${releaseId}`,
       { html_url: releaseUrl },
-      { body: { draft: false } },
+      { body: { draft: false, make_latest: "true" } },
     )
     .getOnce(
       `https://api.github.local/repos/${owner}/${repo}/pulls/1/commits`,

test/publish.test.js

@@ -461,7 +461,7 @@ test("Publish a release with one asset", async (t) => {
     .patchOnce(
       `https://api.github.local/repos/${owner}/${repo}/releases/${releaseId}`,
       { upload_url: uploadUrl, html_url: releaseUrl },
-      { body: { draft: false } },
+      { body: { draft: false, make_latest: "true" } },
     )
     .postOnce(
       `${uploadOrigin}${uploadUri}?name=${encodeURIComponent(
@@ -549,7 +549,7 @@ test("Publish a release with one asset and custom github url", async (t) => {
     .patchOnce(
       `${env.GH_URL}/prefix/repos/${owner}/${repo}/releases/${releaseId}`,
       { upload_url: uploadUrl, html_url: releaseUrl },
-      { body: { draft: false } },
+      { body: { draft: false, make_latest: "true" } },
     )
     .postOnce(
       `${env.GH_URL}${uploadUri}?name=${encodeURIComponent(
@@ -631,7 +631,7 @@ test("Publish a release with an array of missing assets", async (t) => {
     .patchOnce(
       `https://api.github.local/repos/${owner}/${repo}/releases/${releaseId}`,
       { html_url: releaseUrl },
-      { body: { draft: false } },
+      { body: { draft: false, make_latest: "true" } },
     );
 
   const result = await publish(
@@ -729,6 +729,7 @@ test("Publish a release with asset and create discussion", async (t) => {
         body: {
           draft: false,
           discussion_category_name: pluginConfig.discussionCategoryName,
+          make_latest: "true",
         },
       },
     )