Simplify template expansion to always apply templates

Co-authored-by: fgreinacher <[email protected]>

Author: Copilot

lib/publish.js

@@ -56,40 +56,42 @@ export default async (pluginConfig, context) => {
   debug("milestones: %o", milestones);
 
   if (assets && assets.length > 0) {
-    // Apply template expansion to assets BEFORE globbing, but only when templates are present
-    const needsTemplateExpansion = (str) => str && typeof str === 'string' && str.includes('${');
-    
+    // Apply template expansion to assets BEFORE globbing (original approach but moved before)
     const templatedAssets = assets.map((asset) => {
       if (isPlainObject(asset)) {
         const templatedAsset = { ...asset };
-        if (asset.path && needsTemplateExpansion(asset.path)) {
-          templatedAsset.path = template(asset.path)(context);
+        if (asset.path) {
+          if (Array.isArray(asset.path)) {
+            templatedAsset.path = asset.path.map(pattern => template(pattern)(context));
+          } else {
+            templatedAsset.path = template(asset.path)(context);
+          }
         }
-        if (asset.url && needsTemplateExpansion(asset.url)) {
+        if (asset.url) {
           templatedAsset.url = template(asset.url)(context);
         }
-        if (asset.label && needsTemplateExpansion(asset.label)) {
+        if (asset.label) {
           templatedAsset.label = template(asset.label)(context);
         }
-        if (asset.type && needsTemplateExpansion(asset.type)) {
+        if (asset.type) {
           templatedAsset.type = template(asset.type)(context);
         }
-        if (asset.filepath && needsTemplateExpansion(asset.filepath)) {
+        if (asset.filepath) {
           templatedAsset.filepath = template(asset.filepath)(context);
         }
-        if (asset.target && needsTemplateExpansion(asset.target)) {
+        if (asset.target) {
           templatedAsset.target = template(asset.target)(context);
         }
-        if (asset.status && needsTemplateExpansion(asset.status)) {
+        if (asset.status) {
           templatedAsset.status = template(asset.status)(context);
         }
         return templatedAsset;
       } else if (Array.isArray(asset)) {
-        // Handle array of glob patterns - only apply templates if needed
-        return asset.map(pattern => needsTemplateExpansion(pattern) ? template(pattern)(context) : pattern);
+        // Handle array of glob patterns
+        return asset.map(pattern => template(pattern)(context));
       } else {
-        // String asset path - only apply template if needed
-        return needsTemplateExpansion(asset) ? template(asset)(context) : asset;
+        // String asset path
+        return template(asset)(context);
       }
     });
 
@@ -106,16 +108,13 @@ export default async (pluginConfig, context) => {
 
     await Promise.all(
       allAssets.map(async (asset) => {
-        // Templates may have been expanded before globbing, but we need to handle remaining cases
-        const needsTemplateExpansion = (str) => str && typeof str === 'string' && str.includes('${');
-        
         const path = isPlainObject(asset) ? asset.path : asset;
-        const _url = asset.url ? (needsTemplateExpansion(asset.url) ? template(asset.url)(context) : asset.url) : undefined;
-        const label = asset.label ? (needsTemplateExpansion(asset.label) ? template(asset.label)(context) : asset.label) : undefined;
-        const type = asset.type ? (needsTemplateExpansion(asset.type) ? template(asset.type)(context) : asset.type) : undefined;
-        const filepath = asset.filepath ? (needsTemplateExpansion(asset.filepath) ? template(asset.filepath)(context) : asset.filepath) : undefined;
-        const target = asset.target ? (needsTemplateExpansion(asset.target) ? template(asset.target)(context) : asset.target) : undefined;
-        const status = asset.status ? (needsTemplateExpansion(asset.status) ? template(asset.status)(context) : asset.status) : undefined;
+        const _url = asset.url;
+        const label = asset.label;
+        const type = asset.type;
+        const filepath = asset.filepath;
+        const target = asset.target;
+        const status = asset.status;
 
         if (_url) {
           assetsList.push({ label, rawUrl: _url, type, filepath });