refactor: introduce projectApiUrl abstraction

Author: fgreinacher

lib/fail.js

@@ -27,6 +27,7 @@ export default async (pluginConfig, context) => {
   } = resolveConfig(pluginConfig, context);
   const projectPath = getProjectPath(context, gitlabUrl, repositoryUrl);
   const encodedProjectPath = encodeURIComponent(projectPath);
+  const projectApiUrl = urlJoin(gitlabApiUrl, `/projects/${encodedProjectPath}`);
   const apiOptions = {
     headers: { "PRIVATE-TOKEN": gitlabToken },
     retry: { limit: retryLimit },
@@ -42,7 +43,7 @@ Using 'false' for 'failComment' or 'failTitle' is deprecated and will be removed
     const encodedFailTitle = encodeURIComponent(failTitle);
     const description = failComment ? template(failComment)({ branch, errors }) : getFailComment(branch, errors);
 
-    const issuesEndpoint = urlJoin(gitlabApiUrl, `/projects/${encodedProjectPath}/issues`);
+    const issuesEndpoint = urlJoin(projectApiUrl, `issues`);
     const openFailTitleIssueEndpoint = urlJoin(issuesEndpoint, `?state=opened&search=${encodedFailTitle}`);
 
     const openFailTitleIssues = await got(openFailTitleIssueEndpoint, { ...apiOptions }).json();

lib/publish.js

@@ -29,6 +29,7 @@ export default async (pluginConfig, context) => {
   const assetsList = [];
   const projectPath = getProjectPath(context, gitlabUrl, repositoryUrl);
   const encodedProjectPath = encodeURIComponent(projectPath);
+  const projectApiUrl = urlJoin(gitlabApiUrl, `/projects/${encodedProjectPath}`);
   const encodedGitTag = encodeURIComponent(gitTag);
   const encodedVersion = encodeURIComponent(version);
   const apiOptions = {
@@ -114,8 +115,8 @@ export default async (pluginConfig, context) => {
             const encodedLabel = encodeURIComponent(label);
             // https://docs.gitlab.com/ee/user/packages/generic_packages/#publish-a-package-file
             uploadEndpoint = urlJoin(
-              gitlabApiUrl,
-              `/projects/${encodedProjectPath}/packages/generic/release/${encodedVersion}/${encodedLabel}?${
+              projectApiUrl,
+              `packages/generic/release/${encodedVersion}/${encodedLabel}?${
                 status ? `status=${status}&` : ""
               }select=package_file`
             );
@@ -131,16 +132,16 @@ export default async (pluginConfig, context) => {
 
             // https://docs.gitlab.com/ee/user/packages/generic_packages/#download-package-file
             const url = urlJoin(
-              gitlabApiUrl,
-              `/projects/${encodedProjectPath}/packages/generic/release/${encodedVersion}/${encodedLabel}`
+              projectApiUrl,
+              `packages/generic/release/${encodedVersion}/${encodedLabel}`
             );
 
             assetsList.push({ label, alt: "release", url, type: "package", filepath });
 
             logger.log("Uploaded file: %s (%s)", url, response.file.url);
           } else {
             // Handle normal assets
-            uploadEndpoint = urlJoin(gitlabApiUrl, `/projects/${encodedProjectPath}/uploads`);
+            uploadEndpoint = urlJoin(projectApiUrl, "uploads");
 
             debug("POST-ing the file %s to %s", file, uploadEndpoint);
 
@@ -167,7 +168,7 @@ export default async (pluginConfig, context) => {
 
   debug("Create a release for git tag %o with commit %o", gitTag, gitHead);
 
-  const createReleaseEndpoint = urlJoin(gitlabApiUrl, `/projects/${encodedProjectPath}/releases`);
+  const createReleaseEndpoint = urlJoin(projectApiUrl, "releases");
 
   const json = {
     /* eslint-disable camelcase */

lib/success.js

@@ -19,6 +19,7 @@ export default async (pluginConfig, context) => {
     resolveConfig(pluginConfig, context);
   const projectPath = getProjectPath(context, gitlabUrl, repositoryUrl);
   const encodedProjectPath = encodeURIComponent(projectPath);
+  const projectApiUrl = urlJoin(gitlabApiUrl, `/projects/${encodedProjectPath}`);
   const apiOptions = {
     headers: { "PRIVATE-TOKEN": gitlabToken },
     retry: { limit: retryLimit },
@@ -78,8 +79,8 @@ Using 'false' for 'successComment' is deprecated and will be removed in a future
 
       const getRelatedMergeRequests = async (commitHash) => {
         const relatedMergeRequestsEndpoint = urlJoin(
-          gitlabApiUrl,
-          `/projects/${encodedProjectPath}/repository/commits/${commitHash}/merge_requests`
+          projectApiUrl,
+          `repository/commits/${commitHash}/merge_requests`
         );
         debug("Getting MRs from %s", relatedMergeRequestsEndpoint);
         const relatedMergeRequests = await got