Merge branch 'master' into ci-job-token

Author: tachyons

.github/workflows/release.yml

@@ -18,8 +18,8 @@ jobs:
     name: release
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
-      - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      - uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
         with:
           cache: npm
           node-version: lts/*

.github/workflows/test.yml

@@ -23,9 +23,9 @@ jobs:
           - windows-latest
     runs-on: "${{ matrix.os }}"
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - name: "Use Node.js ${{ matrix.node-version }}"
-        uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
+        uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
         with:
           node-version: "${{ matrix.node-version }}"
           cache: npm
@@ -37,9 +37,9 @@ jobs:
     runs-on: ubuntu-latest
     needs: test_matrix
     steps:
-      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - name: "Use Node.js ${{ matrix.node-version }}"
-        uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
+        uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
         with:
           node-version: "${{ matrix.node-version }}"
           cache: npm

AGENTS.md

@@ -0,0 +1,41 @@
+# Agent Guidelines for @semantic-release/gitlab
+
+## Commands
+
+- **Test**: `npm test` or `npm run test`
+- **Lint**: `npm run lint`
+- **Fix linting**: `npm run lint:fix`
+- **Coverage**: Tests include coverage reporting via c8
+
+## Code Style
+
+- **Node.js Version**: 20.8.1+
+- **Module type**: ES modules (`"type": "module"`)
+- **Formatting**: Prettier with 120 character line width and ES5 trailing commas
+- **Testing**: AVA test framework
+- **Coverage**: c8 for code coverage
+
+## Development Guidelines
+
+- **Perform minimal changes**: Focus on the specific issue and make the smallest possible changes
+- **Focus on reviewers**: Write clear, understandable code that is easy to review
+- **Use semantic commits**: Follow conventional commit format (e.g., `feat:`, `fix:`, `docs:`, `test:`)
+- **Run tests and formatting before committing**: Always run `npm test` and `npm run lint` before making commits
+
+## Project Structure
+
+- `lib/` - Core library modules
+- `test/` - Test files (using AVA)
+- `index.js` - Main entry point
+- Configuration files support semantic-release conventions
+
+## Testing Requirements
+
+- All changes must maintain or improve test coverage
+- Tests use nock for HTTP mocking
+- Integration tests verify GitLab API interactions
+- Run `npm test` to execute the full test suite
+
+## Semantic Release Integration
+
+This is a semantic-release plugin, so changes should follow semantic versioning principles and conventional commit formats for automated releases.

README.md

@@ -28,7 +28,6 @@ export default async (pluginConfig, context) => {
   const { projectPath, projectApiUrl } = getProjectContext(context, gitlabUrl, gitlabApiUrl, repositoryUrl);
 
   const encodedGitTag = encodeURIComponent(gitTag);
-  const encodedVersion = encodeURIComponent(version);
   const apiOptions = {
     headers: {
       [tokenHeader]: gitlabToken,
@@ -76,6 +75,7 @@ export default async (pluginConfig, context) => {
         const filepath = asset.filepath ? template(asset.filepath)(context) : undefined;
         const target = asset.target ? template(asset.target)(context) : undefined;
         const status = asset.status ? template(asset.status)(context) : undefined;
+        const packageName = asset.packageName ? template(asset.packageName)(context) : "release";
 
         if (_url) {
           assetsList.push({ label, rawUrl: _url, type, filepath });
@@ -103,17 +103,21 @@ export default async (pluginConfig, context) => {
           debug("file filepath: %o", filepath);
           debug("file target: %o", target);
           debug("file status: %o", status);
+          debug("package name: %o", packageName);
 
           let uploadEndpoint;
           let response;
 
           if (target === "generic_package") {
+            const finalLabel = label ?? pathlib.basename(file);
             // Upload generic packages
-            const encodedLabel = encodeURIComponent(label);
+            const encodedVersion = encodeURIComponent(version);
+            const encodedPackageName = encodeURIComponent(packageName);
+            const encodedLabel = encodeURIComponent(finalLabel);
             // https://docs.gitlab.com/ee/user/packages/generic_packages/#publish-a-package-file
             uploadEndpoint = urlJoin(
               projectApiUrl,
-              `packages/generic/release/${encodedVersion}/${encodedLabel}?${
+              `packages/generic/${encodedPackageName}/${encodedVersion}/${encodedLabel}?${
                 status ? `status=${status}&` : ""
               }select=package_file`
             );
@@ -128,9 +132,12 @@ export default async (pluginConfig, context) => {
             }
 
             // https://docs.gitlab.com/ee/user/packages/generic_packages/#download-package-file
-            const url = urlJoin(projectApiUrl, `packages/generic/release/${encodedVersion}/${encodedLabel}`);
+            const url = urlJoin(
+              projectApiUrl,
+              `packages/generic/${encodedPackageName}/${encodedVersion}/${encodedLabel}`
+            );
 
-            assetsList.push({ label, alt: "release", url, type: "package", filepath });
+            assetsList.push({ label: finalLabel, alt: packageName, url, type: "package", filepath });
 
             logger.log("Uploaded file: %s (%s)", url, response.file.url);
           } else {