Skip to content

Commit 0b73d76

Browse files
committed
feat(rbac): add missing service account roles
1 parent cbb3382 commit 0b73d76

File tree

5 files changed

+42
-1
lines changed

5 files changed

+42
-1
lines changed

ee/rbac/assets/permissions.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,10 @@ permissions:
7070
description: "View the existing dashboards within the organization."
7171
- name: "organization.dashboards.manage"
7272
description: "Create new dashboard views."
73+
- name: "organization.service_accounts.view"
74+
description: "View service accounts within the organization."
75+
- name: "organization.service_accounts.manage"
76+
description: "Manage service accounts within the organization."
7377
project:
7478
- name: "project.view"
7579
description: "Access the project. This permission is needed to see any page within the project."
@@ -133,3 +137,7 @@ permissions:
133137
description: "Manually stop running jobs or workflows."
134138
- name: "project.job.attach"
135139
description: "SSH into the running job, or start a debug session."
140+
- name: "project.service_accounts.view"
141+
description: "View service accounts within the project."
142+
- name: "project.service_accounts.manage"
143+
description: "Manage service accounts within the project."

ee/rbac/assets/roles.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ roles:
3939
- "organization.custom_roles.view"
4040
- "organization.dashboards.view"
4141
- "organization.dashboards.manage"
42+
- "organization.service_accounts.view"
43+
- "organization.service_accounts.manage"
4244
- name: "Admin"
4345
description: "Admins can modify settings within the organization or any of its projects. However, they do not have access to billing information, and they cannot change general organization details, such as the organization name and URL."
4446
maps_to: "Admin"
@@ -77,6 +79,8 @@ roles:
7779
- "organization.dashboards.view"
7880
- "organization.dashboards.manage"
7981
- "project.delete"
82+
- "organization.service_accounts.view"
83+
- "organization.service_accounts.manage"
8084
- name: "Member"
8185
description: "Members can access the organization's homepage and the projects they are assigned to. However, they are not able to modify any settings."
8286
permissions:
@@ -129,6 +133,8 @@ roles:
129133
- "project.job.rerun"
130134
- "project.job.stop"
131135
- "project.job.attach"
136+
- "project.service_accounts.view"
137+
- "project.service_accounts.manage"
132138
- name: "Contributor"
133139
description: "Contributors can manually run, stop, or edit workflows. They can view job logs, start debug sessions and SSH into the machines. Additionally, they can view secrets, schedulers, and notifications used within the projects but can't modify them."
134140
permissions:

helm-chart/templates/configmaps/features.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,8 @@ data:
112112
enabled: true
113113
wf_editor_via_jobs:
114114
enabled: true
115+
service_accounts:
116+
enabled: true
115117
{{- else }}
116118
features.yml: |-
117119
activity_monitor:
@@ -216,4 +218,6 @@ data:
216218
enabled: true
217219
new_project_onboarding:
218220
enabled: true
221+
service_accounts:
222+
enabled: true
219223
{{- end }}

helm-chart/templates/configmaps/permissions.yaml

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,10 @@ data:
5050
description: "Create new dashboard views."
5151
- name: "organization.instance_git_integration.manage"
5252
description: "Manage the instance Git integration settings."
53+
- name: "organization.service_accounts.view"
54+
description: "View service accounts within the organization."
55+
- name: "organization.service_accounts.manage"
56+
description: "Manage service accounts within the organization."
5357
project:
5458
- name: "project.view"
5559
description: "Access the project. This permission is needed to see any page within the project."
@@ -109,6 +113,10 @@ data:
109113
description: "Manually stop running jobs or workflows."
110114
- name: "project.job.attach"
111115
description: "SSH into the running job, or start a debug session."
116+
- name: "project.service_accounts.view"
117+
description: "View service accounts within the project."
118+
- name: "project.service_accounts.manage"
119+
description: "Manage service accounts within the project."
112120
{{- end }}
113121
{{- if eq .Values.global.edition "ee" }}
114122
permissions.yaml: |-
@@ -186,6 +194,10 @@ data:
186194
description: "Create new dashboard views."
187195
- name: "organization.instance_git_integration.manage"
188196
description: "Manage the instance Git integration settings."
197+
- name: "organization.service_accounts.view"
198+
description: "View service accounts within the organization."
199+
- name: "organization.service_accounts.manage"
200+
description: "Manage service accounts within the organization."
189201
project:
190202
- name: "project.view"
191203
description: "Access the project. This permission is needed to see any page within the project."
@@ -249,4 +261,9 @@ data:
249261
description: "Manually stop running jobs or workflows."
250262
- name: "project.job.attach"
251263
description: "SSH into the running job, or start a debug session."
252-
{{- end }}
264+
- name: "project.service_accounts.view"
265+
description: "View service accounts within the project."
266+
- name: "project.service_accounts.manage"
267+
description: "Manage service accounts within the project."
268+
269+
{{- end }}

helm-chart/templates/configmaps/roles.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ data:
3333
- "organization.dashboards.view"
3434
- "organization.dashboards.manage"
3535
- "organization.instance_git_integration.manage"
36+
- "organization.service_accounts.view"
37+
- "organization.service_accounts.manage"
3638
- name: "Admin"
3739
description: "Admins can modify settings within the organization or any of its projects. However, they do not have access to billing information, and they cannot change general organization details, such as the organization name and URL."
3840
maps_to: "Admin"
@@ -57,6 +59,8 @@ data:
5759
- "organization.dashboards.view"
5860
- "organization.dashboards.manage"
5961
- "project.delete"
62+
- "organization.service_accounts.view"
63+
- "organization.service_accounts.manage"
6064
- name: "Member"
6165
description: "Members can access the organization's homepage and the projects they are assigned to. However, they are not able to modify any settings."
6266
permissions:
@@ -287,6 +291,8 @@ data:
287291
- "project.job.rerun"
288292
- "project.job.stop"
289293
- "project.job.attach"
294+
- "project.service_accounts.view"
295+
- "project.service_accounts.manage"
290296
- name: "Contributor"
291297
description: "Contributors can manually run, stop, or edit workflows. They can view job logs, start debug sessions and SSH into the machines. Additionally, they can view secrets, schedulers, and notifications used within the projects but can't modify them."
292298
permissions:

0 commit comments

Comments
 (0)