Skip to content

Commit 1bafa4c

Browse files
Change proto interceptor to automatically convert to the Reponse struct
1 parent 98e35a3 commit 1bafa4c

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

ee/ephemeral_environments/lib/ephemeral_environments/grpc/ephemeral_environments_server.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ defmodule EphemeralEnvironments.Grpc.EphemeralEnvironmentsServer do
2727
def create(request, _stream) do
2828
case EphemeralEnvironments.Service.EphemeralEnvironmentType.create(request.environment_type) do
2929
{:ok, ret} ->
30-
EphemeralEnvironments.Utils.Proto.from_map(%{environment_type: ret}, CreateResponse)
30+
%{environment_type: ret}
3131

3232
{:error, error_message} ->
3333
raise GRPC.RPCError, status: :unknown, message: error_message

ee/ephemeral_environments/lib/ephemeral_environments/grpc/interceptors/proto_converte.ex

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,12 @@ defmodule EphemeralEnvironments.Grpc.Interceptor.ProtoConverter do
77
end
88

99
def call(request, stream, next, _) do
10-
Logger.debug("Proto intercepter #{inspect(request)}")
11-
converted = EphemeralEnvironments.Utils.Proto.to_map(request)
12-
next.(converted, stream)
10+
Logger.debug("Proto intercepter - Request: #{inspect(request)}")
11+
converted_request = EphemeralEnvironments.Utils.Proto.to_map(request)
12+
{:ok, stream, response} = next.(converted_request, stream)
13+
14+
converted_response = EphemeralEnvironments.Utils.Proto.from_map(response, stream.response_mod)
15+
Logger.debug("Proto intercepter - Response: #{inspect(converted_response)}")
16+
{:ok, stream, converted_response}
1317
end
1418
end

0 commit comments

Comments
 (0)