Skip to content

Commit 26c99e9

Browse files
authored
fix(front): move css loading from js => css (#457)
## πŸ“ Description The current CSS processing pipeline does not support loading CSS styles from JavaScript. Because of this, we've moved loading styles from JS files to the `main.css` file. ## βœ… Checklist - [x] I have tested this change - [ ] This change requires documentation update
1 parent 04de3db commit 26c99e9

File tree

18 files changed

+15
-22
lines changed

18 files changed

+15
-22
lines changed

β€Žfront/assets/css/main.css

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
/* Vendor library styles */
2+
@import "tippy.js/dist/tippy.css";
3+
@import "tippy.js/dist/svg-arrow.css";
4+
5+
@import 'tom-select/dist/css/tom-select.min.css';
6+
7+
@import 'pikaday/css/pikaday.css';
8+
9+
@import 'billboard.js/dist/billboard.min.css';
10+
11+
@import "github-markdown-css/github-markdown-light.css";
12+
113
/* Main CSS entry point - combines all CSS files */
214
@import "./app-semaphore.css";
315
@import "./app.css";

β€Žfront/assets/js/dashboard/interval_selector.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import $ from "jquery"; // live on click event
22

33
import pikaday from 'pikaday';
4-
import 'pikaday/css/pikaday.css';
54
import querystringify from 'querystringify';
65

76
export class IntervalSelector {

β€Žfront/assets/js/deployments/components/subjects.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ export default {
44
}
55
}
66

7-
import 'tom-select/dist/css/tom-select.min.css'
7+
88
import TomSelect from 'tom-select'
99

1010
class SubjectsComponent {

β€Žfront/assets/js/deployments/history_page.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { QueryList } from "../query_list"
22
import { Props } from "../props"
33
import _ from "lodash"
44

5-
import 'pikaday/css/pikaday.css';
65
import pikaday from 'pikaday';
76

87
export default {

β€Žfront/assets/js/flaky_tests/components/disruption_history_chart.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { createRef } from "preact";
22
import bb, { bar } from "billboard.js";
3-
import 'billboard.js/dist/billboard.min.css';
43
import { HistoryItem } from "../types/flaky_test_item";
54
import { useEffect } from "preact/hooks";
65

β€Žfront/assets/js/flaky_tests/components/history_chart.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { Fragment, createRef } from "preact";
22
import bb, { bar } from "billboard.js";
3-
import 'billboard.js/dist/billboard.min.css';
43
import { HistoryItem } from "../types/flaky_test_item";
54
import { useEffect } from "preact/hooks";
65
import { ChartHelpers } from "js/toolbox";

β€Žfront/assets/js/flaky_tests/components/top_flaky_charts.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11

22
import * as stores from "../stores";
3-
import 'billboard.js/dist/billboard.min.css';
43
import { Status } from "../types";
54
import { LoadingIndicator } from "./loading_indicator";
65
import { Message } from "./flaky_test_table";

β€Žfront/assets/js/flaky_tests/pages/flaky_tests_page.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ import * as types from "../types";
66
// @ts-ignore
77
import { Notice } from "js/notice";
88
import * as components from "../components";
9-
import 'tippy.js/dist/tippy.css'; // optional
10-
import 'tippy.js/themes/light.css';
119
import { RequestStatus, Status } from "../types";
1210
import { FetchData } from "../network/request";
1311
import { FlakyTestItem, HistoryItem } from "../types/flaky_test_item";

β€Žfront/assets/js/insights/components/custom_dashboards.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ import { DashboardItemCard } from './dashboard_item_card';
1616
import { InsightsType, typeByMetric } from '../types/insights_type';
1717
import { empty_custom_dashboard } from './zero_state/empty_custom_dashboard';
1818
import Tippy from '@tippyjs/react';
19-
import 'tippy.js/dist/tippy.css'; // optional
20-
import 'tippy.js/themes/light.css';
2119
import { handleMetricDatePickerChanged } from "../util/event_handlers";
2220
import * as stores from "../stores";
2321

β€Žfront/assets/js/insights/components/dashboard_item_card.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ import { DashboardItem } from '../types/dashboard';
22
import { InsightsType, typeByMetric } from '../types/insights_type';
33
import * as customCharts from './custom_charts';
44
import Tippy from '@tippyjs/react';
5-
import 'tippy.js/dist/tippy.css'; // optional
6-
import 'tippy.js/themes/light.css';
75
import { useState } from 'preact/hooks';
86
import { metricFromNumber } from "../util/metric";
97

0 commit comments

Comments
Β (0)