fix(front): display promoter information for scheduled workflows (#307)

## 📝 Description
Currently, scheduled tasks do not correctly show who ran their
promotions.
This PR ensures that the correct promoter information is displayed when
a promotion is manually triggered.

## ✅ Checklist
- [x] I have tested this change
- [ ] This change requires documentation update

Author: skipi

front/lib/front/models/pipeline/triggerer.ex

@@ -118,7 +118,7 @@ defmodule Front.Models.Pipeline.Triggerer do
         {:user, {triggerer.wf_triggerer_user_id, ""}}
 
       :SCHEDULED_RUN ->
-        :none
+        detect_scheduled_run_owner(triggerer)
 
       :SCHEDULED_MANUAL_RUN ->
         {:user, {triggerer.wf_triggerer_user_id, ""}}
@@ -137,6 +137,17 @@ defmodule Front.Models.Pipeline.Triggerer do
     end
   end
 
+  defp detect_scheduled_run_owner(triggerer) do
+    PplTriggeredBy.key(triggerer.ppl_triggered_by)
+    |> case do
+      :PROMOTION ->
+        {:user, {triggerer.ppl_triggerer_user_id, ""}}
+
+      _ ->
+        :none
+    end
+  end
+
   @spec detect_trigger(InternalApi.Plumber.Pipeline.t()) :: {trigger_type(), triggered_by()}
   # # credo:disable-for-next-line Credo.Check.Refactor.CyclomaticComplexity
   defp detect_trigger(pipeline) do
@@ -148,6 +159,9 @@ defmodule Front.Models.Pipeline.Triggerer do
       wf_triggered_by == :API ->
         {:API, :none}
 
+      wf_triggered_by == :SCHEDULE && ppl_triggered_by == :PROMOTION ->
+        {:MANUAL_PROMOTION, :none}
+
       wf_triggered_by == :SCHEDULE ->
         {:SCHEDULED_RUN, {:task, {triggerer.wf_triggerer_id, ""}}}
 

front/test/front/models/pipeline/triggerer_test.exs

@@ -35,6 +35,15 @@ defmodule Front.Models.Pipeline.TriggererTest do
       assert {:task, _} = triggerer.triggered_by
       assert :none == triggerer.owner
     end
+
+    test "constructs proper triggerer for promotions" do
+      pipeline = Factories.pipeline_with_trigger(:SCHEDULED_RUN_WITH_PROMOTION)
+      triggerer = Triggerer.construct(pipeline)
+
+      assert :MANUAL_PROMOTION == triggerer.trigger_type
+      assert :none = triggerer.triggered_by
+      assert {:user, _} = triggerer.owner
+    end
   end
 
   describe "#construct for scheduled manual run" do

front/test/support/factories.ex

@@ -3099,64 +3099,74 @@ defmodule Support.Factories do
   end
 
   def pipeline_with_trigger(trigger_type \\ nil) do
-    trigger_type
-    |> case do
-      :INITIAL_WORKFLOW ->
+    db = %{
+      INITIAL_WORKFLOW: fn ->
         pipeline(
           triggerer: [
             wf_triggered_by: WfTriggeredBy.value(:HOOK),
             ppl_triggered_by: PplTriggeredBy.value(:WORKFLOW)
           ]
         )
-
-      :WORKFLOW_RERUN ->
+      end,
+      WORKFLOW_RERUN: fn ->
         pipeline(
           triggerer: [
             workflow_rerun_of: Ecto.UUID.generate()
           ]
         )
-
-      :API ->
+      end,
+      API: fn ->
         pipeline(
           triggerer: [
             wf_triggered_by: WfTriggeredBy.value(:API)
           ]
         )
-
-      :SCHEDULED_RUN ->
+      end,
+      SCHEDULED_RUN: fn ->
         pipeline(
           triggerer: [
             wf_triggered_by: WfTriggeredBy.value(:SCHEDULE)
           ]
         )
-
-      :SCHEDULED_MANUAL_RUN ->
+      end,
+      SCHEDULED_RUN_WITH_PROMOTION: fn ->
+        pipeline(
+          triggerer: [
+            wf_triggered_by: WfTriggeredBy.value(:SCHEDULE),
+            ppl_triggered_by: PplTriggeredBy.value(:PROMOTION)
+          ]
+        )
+      end,
+      SCHEDULED_MANUAL_RUN: fn ->
         pipeline(
           triggerer: [
             wf_triggered_by: WfTriggeredBy.value(:MANUAL_RUN)
           ]
         )
-
-      :PIPELINE_PARTIAL_RERUN ->
+      end,
+      PIPELINE_PARTIAL_RERUN: fn ->
         pipeline(
           triggerer: [
             ppl_triggered_by: PplTriggeredBy.value(:PARTIAL_RE_RUN)
           ]
         )
-
-      :MANUAL_PROMOTION ->
+      end,
+      MANUAL_PROMOTION: fn ->
         pipeline(
           triggerer: [
             ppl_triggered_by: PplTriggeredBy.value(:PROMOTION)
           ]
         )
-
-      :AUTO_PROMOTION ->
+      end,
+      AUTO_PROMOTION: fn ->
         pipeline(
           triggerer: [
             ppl_triggered_by: PplTriggeredBy.value(:AUTO_PROMOTION)
           ]
         )
-    end
+      end
+    }
+
+    db[trigger_type].()
   end
 end