Skip to content

Commit 4fa2a94

Browse files
fix(front): pipeline status message shows who triggered pipeline correctly (#483)
## 📝 Description renderedtext/tasks#8347 ## ✅ Checklist - [x] I have tested this change - [x] ~This change requires documentation update~
1 parent 81d7de9 commit 4fa2a94

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

front/lib/front/models/pipeline/triggerer.ex

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -156,18 +156,6 @@ defmodule Front.Models.Pipeline.Triggerer do
156156
ppl_triggered_by = PplTriggeredBy.key(triggerer.ppl_triggered_by)
157157

158158
cond do
159-
wf_triggered_by == :API ->
160-
{:API, :none}
161-
162-
wf_triggered_by == :SCHEDULE && ppl_triggered_by == :PROMOTION ->
163-
{:MANUAL_PROMOTION, :none}
164-
165-
wf_triggered_by == :SCHEDULE ->
166-
{:SCHEDULED_RUN, {:task, {triggerer.wf_triggerer_id, ""}}}
167-
168-
wf_triggered_by == :MANUAL_RUN ->
169-
{:SCHEDULED_MANUAL_RUN, {:task, {triggerer.wf_triggerer_id, ""}}}
170-
171159
ppl_triggered_by == :PARTIAL_RE_RUN ->
172160
{:PIPELINE_PARTIAL_RERUN, {:pipeline, triggerer.ppl_triggerer_id}}
173161

@@ -180,6 +168,15 @@ defmodule Front.Models.Pipeline.Triggerer do
180168
triggerer.workflow_rerun_of != "" ->
181169
{:WORKFLOW_RERUN, {:workflow, triggerer.workflow_rerun_of}}
182170

171+
wf_triggered_by == :API ->
172+
{:API, :none}
173+
174+
wf_triggered_by == :SCHEDULE ->
175+
{:SCHEDULED_RUN, {:task, {triggerer.wf_triggerer_id, ""}}}
176+
177+
wf_triggered_by == :MANUAL_RUN ->
178+
{:SCHEDULED_MANUAL_RUN, {:task, {triggerer.wf_triggerer_id, ""}}}
179+
183180
wf_triggered_by == :HOOK && ppl_triggered_by == :WORKFLOW ->
184181
{:INITIAL_WORKFLOW, {:hook, triggerer.wf_triggerer_id}}
185182

front/test/support/factories.ex

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3155,6 +3155,7 @@ defmodule Support.Factories do
31553155
MANUAL_PROMOTION: fn ->
31563156
pipeline(
31573157
triggerer: [
3158+
wf_triggered_by: WfTriggeredBy.value(:MANUAL_RUN),
31583159
ppl_triggered_by: PplTriggeredBy.value(:PROMOTION)
31593160
]
31603161
)

0 commit comments

Comments
 (0)