fix: add git and gitlab support for tasks (#98)

Author: forestileao

hooks_processor/lib/hooks_processor/hooks/grpc/server.ex

@@ -142,9 +142,13 @@ defmodule HooksProcessor.Hooks.Grpc.Server do
   defp repo_html_url(repository = %{integration_type: :GITHUB_OAUTH_TOKEN}), do: repo_html_url(:github, repository)
   defp repo_html_url(repository = %{integration_type: :GITHUB_APP}), do: repo_html_url(:github, repository)
   defp repo_html_url(repository = %{integration_type: :BITBUCKET}), do: repo_html_url(:bitbucket, repository)
+  defp repo_html_url(repository = %{integration_type: :GITLAB}), do: repo_html_url(:gitlab, repository)
+  defp repo_html_url(repository = %{integration_type: :GIT}), do: repo_html_url(:git, repository)
 
   defp repo_html_url(:github, repository), do: "https://github.com/#{repository.owner}/#{repository.name}"
   defp repo_html_url(:bitbucket, repository), do: "https://bitbucket.org/#{repository.owner}/#{repository.name}"
+  defp repo_html_url(:gitlab, repository), do: "https://gitlab.com/#{repository.owner}/#{repository.name}"
+  defp repo_html_url(_, _), do: ""
 
   defp form_response(:create, hook) do
     %CreateResponse{
@@ -180,4 +184,6 @@ defmodule HooksProcessor.Hooks.Grpc.Server do
   defp provider(:GITHUB_OAUTH_TOKEN), do: "github"
   defp provider(:GITHUB_APP), do: "github"
   defp provider(:BITBUCKET), do: "bitbucket"
+  defp provider(:GITLAB), do: "gitlab"
+  defp provider(:GIT), do: "git"
 end

periodic_scheduler/scheduler/lib/internal_api/plumber_w_f.workflow.pb.ex

@@ -25,6 +25,8 @@ defmodule InternalApi.PlumberWF.ScheduleRequest.ServiceType do
   field :LOCAL, 1
   field :SNAPSHOT, 2
   field :BITBUCKET, 3
+  field :GITLAB, 4
+  field :GIT, 5
 end
 
 defmodule InternalApi.PlumberWF.ListLatestWorkflowsRequest.Order do

periodic_scheduler/scheduler/lib/internal_api/repository_integrator.pb.ex

@@ -5,6 +5,8 @@ defmodule InternalApi.RepositoryIntegrator.IntegrationType do
   field :GITHUB_OAUTH_TOKEN, 0
   field :GITHUB_APP, 1
   field :BITBUCKET, 2
+  field :GITLAB, 3
+  field :GIT, 4
 end
 
 defmodule InternalApi.RepositoryIntegrator.IntegrationScope do

periodic_scheduler/scheduler/lib/scheduler/actions/schedule_wf_impl.ex

@@ -140,6 +140,8 @@ defmodule Scheduler.Actions.ScheduleWfImpl do
   defp schedule_workflow_service_type(:GITHUB_OAUTH_TOKEN), do: :GIT_HUB
   defp schedule_workflow_service_type(:GITHUB_APP), do: :GIT_HUB
   defp schedule_workflow_service_type(:BITBUCKET), do: :BITBUCKET
+  defp schedule_workflow_service_type(:GITLAB), do: :GITLAB
+  defp schedule_workflow_service_type(:GIT), do: :GIT
 
   defp parameter_values_to_env_vars(parameter_values) do
     Enum.into(parameter_values, [], &parameter_value_to_env_var/1)

periodic_scheduler/scheduler/test/actions/schedule_wf_impl_test.exs

@@ -170,6 +170,123 @@ defmodule Scheduler.Actions.ScheduleWfImpl.Test do
     assert schedule_params.triggered_by == :SCHEDULE
   end
 
+  test "schedule() - schedule params are correctly formed for gitlab in JustRun case", ctx do
+    alias Scheduler.Actions.ScheduleWfImpl
+
+    use_mock_workflow_service()
+    mock_workflow_service_response("just_run")
+    reset_mock_feature_service()
+    mock_feature_response("just_run")
+    use_mock_project_service()
+    mock_projecthub_response("ok")
+    use_mock_repository_service()
+    mock_repositoryhub_response("ok")
+
+    ts_before = DateTime.utc_now()
+    timestamp = Timex.shift(ts_before, minutes: -1)
+
+    periodic =
+      ctx.periodic
+      |> Periodics.changeset("v1.1", %{
+        parameters: [
+          %{name: "param_gitlab1", required: true, default_value: "value1"},
+          %{name: "param_gitlab2", required: false, default_value: "value2"},
+          %{name: "param_gitlab3", required: false, default_value: "value3"},
+          %{name: "param_gitlab4", required: false}
+        ]
+      })
+      |> Scheduler.PeriodicsRepo.update!()
+
+    assert {:ok, _pid} = ScheduleWfImpl.start_schedule_task(ctx.periodic.id, timestamp)
+
+    :timer.sleep(2_000)
+
+    assert {:ok, [tr]} = PTQueries.get_n_by_periodic_id(ctx.periodic.id, 1)
+
+    assert tr.scheduling_status == "passed"
+    assert tr.scheduled_workflow_id == "wf_id"
+    assert tr.error_description == nil
+
+    assert Map.new(tr.parameter_values, &{&1.name, &1.value}) ==
+             %{
+               "param_gitlab1" => "value1",
+               "param_gitlab2" => "value2",
+               "param_gitlab3" => "value3"
+             }
+
+    assert tr.attempts == 1
+
+    assert DateTime.compare(tr.scheduled_at, ts_before) == :gt
+
+    repository = %{id: UUID.uuid4(), integration_type: :GITLAB}
+
+    assert {:ok, schedule_params} =
+             ScheduleWfImpl.form_just_run_schedule_params(periodic, tr, repository)
+
+    assert schedule_params.service == :GITLAB
+    assert schedule_params.requester_id == periodic.requester_id
+    assert schedule_params.triggered_by == :SCHEDULE
+  end
+
+  test "schedule() - schedule params are correctly formed for git agnostic in JustRun case",
+       ctx do
+    alias Scheduler.Actions.ScheduleWfImpl
+
+    use_mock_workflow_service()
+    mock_workflow_service_response("just_run")
+    reset_mock_feature_service()
+    mock_feature_response("just_run")
+    use_mock_project_service()
+    mock_projecthub_response("ok")
+    use_mock_repository_service()
+    mock_repositoryhub_response("ok")
+
+    ts_before = DateTime.utc_now()
+    timestamp = Timex.shift(ts_before, minutes: -1)
+
+    periodic =
+      ctx.periodic
+      |> Periodics.changeset("v1.1", %{
+        parameters: [
+          %{name: "param_git1", required: true, default_value: "value1"},
+          %{name: "param_git2", required: false, default_value: "value2"},
+          %{name: "param_git3", required: false, default_value: "value3"},
+          %{name: "param_git4", required: false}
+        ]
+      })
+      |> Scheduler.PeriodicsRepo.update!()
+
+    assert {:ok, _pid} = ScheduleWfImpl.start_schedule_task(ctx.periodic.id, timestamp)
+
+    :timer.sleep(2_000)
+
+    assert {:ok, [tr]} = PTQueries.get_n_by_periodic_id(ctx.periodic.id, 1)
+
+    assert tr.scheduling_status == "passed"
+    assert tr.scheduled_workflow_id == "wf_id"
+    assert tr.error_description == nil
+
+    assert Map.new(tr.parameter_values, &{&1.name, &1.value}) ==
+             %{
+               "param_git1" => "value1",
+               "param_git2" => "value2",
+               "param_git3" => "value3"
+             }
+
+    assert tr.attempts == 1
+
+    assert DateTime.compare(tr.scheduled_at, ts_before) == :gt
+
+    repository = %{id: UUID.uuid4(), integration_type: :GIT}
+
+    assert {:ok, schedule_params} =
+             ScheduleWfImpl.form_just_run_schedule_params(periodic, tr, repository)
+
+    assert schedule_params.service == :GIT
+    assert schedule_params.requester_id == periodic.requester_id
+    assert schedule_params.triggered_by == :SCHEDULE
+  end
+
   test "schedule() - when project service fails for JustRun case then workflow is not scheduled",
        ctx do
     use_mock_workflow_service()