fix(github-hooks): support ready_for_review hook from github (#518)

## 📝 Description
Draft PRs that are converted to regular PRs don't trigger builds because
the GitHub webhook action `ready_for_review` is not in the list of
supported actions in the webhook filter.

## ✅ Checklist
- [x] I have tested this change
- [ ] This change requires documentation update

Author: skipi

github_hooks/lib/repo_host/api/payload.rb

@@ -15,6 +15,14 @@ def pull_request?
     end
     alias_method :is_pull_request?, :pull_request?
 
+    def draft_pull_request?
+      false
+    end
+
+    def pull_request_ready_for_review?
+      false
+    end
+
     def pr_head_repo_name
       nil
     end

github_hooks/lib/repo_host/bitbucket/payload.rb

@@ -149,6 +149,10 @@ def draft_pull_request?
       false
     end
 
+    def pull_request_ready_for_review?
+      false
+    end
+
     # ❌
     def pull_request_within_repo?
       return false unless pull_request?

github_hooks/lib/repo_host/git/payload.rb

@@ -19,6 +19,10 @@ def draft_pull_request?
       false
     end
 
+    def pull_request_ready_for_review?
+      false
+    end
+
     def pr_head_repo_name
       nil
     end

github_hooks/lib/repo_host/github/payload.rb

@@ -9,6 +9,7 @@ class Payload
     PULL_REQUEST_REOPENED = "reopened"
     PULL_REQUEST_CLOSED = "closed"
     PULL_REQUEST_COMMIT = "synchronize"
+    PULL_REQUEST_READY_FOR_REVIEW = "ready_for_review"
 
     def initialize(payload)
       @data = JSON.parse(payload)
@@ -184,6 +185,10 @@ def pull_request_commit?
       @action == PULL_REQUEST_COMMIT
     end
 
+    def pull_request_ready_for_review?
+      @action == PULL_REQUEST_READY_FOR_REVIEW
+    end
+
     def pull_request_number
       @data["number"] if pull_request?
     end

github_hooks/lib/repo_host/gitlab/payload.rb

@@ -35,6 +35,15 @@ def draft_pull_request?
         pull_request? && data.dig("object_attributes", "draft")
       end
 
+      def pull_request_ready_for_review?
+        return false unless pull_request?
+        return false unless data.dig("object_attributes", "action") == "update"
+
+        # Check if it was previously draft and is now not draft
+        data.dig("changes", "draft", "previous") == true &&
+          data.dig("changes", "draft", "current") == false
+      end
+
       def pr_head_repo_name
         data.dig("object_attributes", "repository", "name")
       end

github_hooks/lib/semaphore/repo_host/github/webhook_filter.rb

@@ -5,7 +5,7 @@ class WebhookFilter
     MEMBER_GITHUB_WEBHOOK_EVENT = ["member", "membership", "team"]
     GITHUB_APP_WEBHOOK_EVENTS = ["installation", "installation_repositories"]
     SUPPORTED_GITHUB_WEBHOOK_EVENTS = ["push", "pull_request", "member", "issue_comment", "installation", "installation_repositories", "team", "membership", "repository"]
-    SUPPORTED_GITHUB_PULL_REQUEST_ACTIONS = ["opened", "synchronize", "closed", "reopened"]
+    SUPPORTED_GITHUB_PULL_REQUEST_ACTIONS = ["opened", "synchronize", "closed", "reopened", "ready_for_review"]
     SUPPORTED_PR_COMMANDS = ["/sem-approve"]
 
     def initialize(request, payload)

github_hooks/lib/semaphore/repo_host/hooks/handler.rb

@@ -194,6 +194,14 @@ def self.run(workflow, logger, hook_payload = "", signature = "", retries = 0)
           return
         end
 
+        # Skip ready_for_review events when build_draft_pr is enabled
+        # (the PR was already building as a draft)
+        if draft_pr_allowed?(workflow.project) && workflow.payload.pull_request_ready_for_review?
+          logger.info("skip-ready-for-review-when-building-drafts")
+          workflow.update(:state => Workflow::STATE_SKIP_DRAFT_PR)
+          return
+        end
+
         state, meta, msg = update_pr_data(workflow.project, workflow.pull_request_number, workflow.commit_sha)
         case state
         when :not_found

github_hooks/spec/lib/semaphore/repo_host/github/webhook_filter_spec.rb

@@ -173,6 +173,31 @@
 
       end
 
+      context "ready_for_review" do
+
+        let(:payload) do
+          <<-PAYLOAD
+              {
+                "action": "ready_for_review",
+                "pull_request":{
+                  "draft": false,
+                  "head":{
+                    "label": "owner_1:branch"
+                  },
+                  "base":{
+                    "label": "owner_2:branch"
+                  }
+                }
+              }
+          PAYLOAD
+        end
+
+        it "returns false" do
+          expect(filter.unsupported_webhook?).to eql(false)
+        end
+
+      end
+
       context "other" do
 
         let(:payload) do