Skip to content

Commit 654dbcf

Browse files
authored
dev(front): enable live reload for front service in local development (#441)
- Remove entr file watching in favor of LiveReload - Enable distributed node for clustering in local development - Move hardcoded internal APIs from dev config to docker compose - Remove CORS headers blocking LiveReload websockets - Enable websocket upgrades for LiveReload in ingress ## 📝 Description <!-- Describe your changes in detail --> ## ✅ Checklist - [x] I have tested this change - [x] ~This change requires documentation update~
1 parent c858fdc commit 654dbcf

File tree

14 files changed

+116
-145
lines changed

14 files changed

+116
-145
lines changed

front/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,15 @@ COPY front/assets ./
5656
FROM elixir AS dev
5757
WORKDIR /app
5858
RUN apk update \
59-
&& apk add --no-cache chromium-chromedriver inotify-tools bash gnupg entr
59+
&& apk add --no-cache chromium-chromedriver inotify-tools bash gnupg
6060

6161
COPY --from=elixir /elixir ./
6262
COPY --from=node /assets ./assets
6363
WORKDIR /app/assets
6464
RUN node build.js
6565
WORKDIR /app
6666

67-
CMD ["sh", "-c", "find lib config | entr -n -r mix phx.server"]
67+
CMD ["sh", "-c", "elixir --name [email protected] --cookie mycookie -S mix phx.server"]
6868
# -- dev stage
6969

7070
# -- builder stage - build artifacts are created here

front/Makefile

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@ CACHE_PORT=6379
2929
CACHE_POOL_SIZE=5
3030
AMQP_URL=amqp://0.0.0.0:5672
3131

32+
#
33+
# Internal API URLs env file
34+
#
35+
INTERNAL_API_ENV_FILE = env/.env.internal-apis
36+
3237
CONTAINER_ENV_VARS = \
3338
-e CI=$(CI) \
3439
-e MIX_ENV=$(MIX_ENV) \
@@ -42,7 +47,8 @@ CONTAINER_ENV_VARS = \
4247
-e SEED_PROJECTS="initializing_failed,zebra,guard,errored,test_results,test_results_debug,after_pipeline,bitbucket" \
4348
-e SEED_CLOUD_MACHINES=true \
4449
-e SECRET_KEY_BASE="keyboard-cat-please-use-this-only-for-dev-and-testing-it-is-insecure" \
45-
-e SESSION_SIGNING_SALT="keyboard-cat-please-use-this-only-for-dev-and-testing-it-is-insecure"
50+
-e SESSION_SIGNING_SALT="keyboard-cat-please-use-this-only-for-dev-and-testing-it-is-insecure" \
51+
--env-file $(INTERNAL_API_ENV_FILE)
4652

4753

4854
CONTAINER_CE_ENV_VARS =\
@@ -55,7 +61,8 @@ CONTAINER_CE_ENV_VARS =\
5561
-e WORKFLOW_TEMPLATES_YAMLS_PATH="/app/workflow_templates/ce" \
5662
-e EXCLUDE_STUBS="GoferMock" \
5763
-e SECRET_KEY_BASE="keyboard-cat-please-use-this-only-for-dev-and-testing-it-is-insecure" \
58-
-e SESSION_SIGNING_SALT="keyboard-cat-please-use-this-only-for-dev-and-testing-it-is-insecure"
64+
-e SESSION_SIGNING_SALT="keyboard-cat-please-use-this-only-for-dev-and-testing-it-is-insecure" \
65+
--env-file $(INTERNAL_API_ENV_FILE)
5966

6067
test.ex.setup: export MIX_ENV=test
6168
test.ex.setup:

front/config/dev.exs

Lines changed: 4 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@ config :front, FrontWeb.Endpoint,
2121
~r{lib/front_web/views/.*(ex)$},
2222
~r{lib/front_web/templates/.*(eex)$},
2323
~r{assets/js/.*(ts|tsx|js)$}
24-
]
24+
],
25+
web_console_logger: true
2526
]
2627

2728
# Do not include metadata nor timestamps in development logs
@@ -30,48 +31,9 @@ config :logger, :console, format: "[$level] $message\n"
3031
config :phoenix, :stacktrace_depth, 20
3132

3233
config :front,
33-
cookie_name: "_semaphoreappdotcom_dev_session",
34-
# API endpoints
35-
artifacthub_api_grpc_endpoint: "127.0.0.1:50052",
36-
audit_grpc_endpoint: "127.0.0.1:50052",
37-
authentication_grpc_endpoint: "127.0.0.1:50051",
38-
billing_api_grpc_endpoint: "127.0.0.1:50052",
39-
branch_api_grpc_endpoint: "127.0.0.1:50052",
40-
dashboard_api_grpc_endpoint: "127.0.0.1:50052",
41-
feature_grpc_endpoint: "127.0.0.1:50052",
42-
gofer_grpc_endpoint: "127.0.0.1:50052",
43-
guard_grpc_endpoint: "127.0.0.1:50052",
44-
guard_user_grpc_endpoint: "127.0.0.1:50052",
45-
instance_config_grpc_endpoint: "127.0.0.1:50052",
46-
job_api_grpc_endpoint: "127.0.0.1:50052",
47-
loghub2_api_grpc_endpoint: "127.0.0.1:50051",
48-
loghub_api_grpc_endpoint: "127.0.0.1:50051",
49-
notification_api_grpc_endpoint: "127.0.0.1:50052",
50-
okta_grpc_endpoint: "127.0.0.1:50052",
51-
organization_api_grpc_endpoint: "127.0.0.1:50052",
52-
periodic_scheduler_grpc_endpoint: "127.0.0.1:50052",
53-
permission_patrol_grpc_endpoint: "127.0.0.1:50052",
54-
pipeline_api_grpc_endpoint: "127.0.0.1:50052",
55-
ppl_grpc_endpoint: "127.0.0.1:50051",
56-
pre_flight_checks_grpc_endpoint: "127.0.0.1:50052",
57-
projecthub_grpc_endpoint: "127.0.0.1:50052",
58-
rbac_grpc_endpoint: "127.0.0.1:50052",
59-
groups_grpc_endpoint: "127.0.0.1:50052",
60-
repo_proxy_grpc_endpoint: "127.0.0.1:50051",
61-
repohub_grpc_endpoint: "127.0.0.1:50052",
62-
repository_integrator_grpc_endpoint: "127.0.0.1:50052",
63-
repositoryhub_grpc_endpoint: "127.0.0.1:50052",
64-
scouter_grpc_endpoint: "127.0.0.1:50052",
65-
secrets_api_grpc_endpoint: "127.0.0.1:50052",
66-
self_hosted_agents_grpc_endpoint: "127.0.0.1:50052",
67-
superjerry_grpc_endpoint: "127.0.0.1:50051",
68-
task_grpc_endpoint: "127.0.0.1:50052",
69-
velocity_grpc_endpoint: "127.0.0.1:50052",
70-
workflow_api_grpc_endpoint: "127.0.0.1:50052",
71-
jwt_grpc_endpoint: "127.0.0.1:50052",
72-
license_grpc_endpoint: "127.0.0.1:50052"
34+
cookie_name: "_semaphoreappdotcom_dev_session"
7335

74-
config :front, domain: "semaphoredev.dev"
36+
config :front, domain: System.get_env("BASE_DOMAIN") || "semaphoredev.dev"
7537
config :front, me_host: nil, me_path: "/me"
7638
config :front, docs_domain: "docs.semaphoredev.dev"
7739
config :front, guard_grpc_timeout: 1_000

front/config/runtime.exs

Lines changed: 47 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,57 @@ config :front,
5555
cache_pool_size: elem(Integer.parse(System.get_env("CACHE_POOL_SIZE") || "5"), 0),
5656
github_app_url: System.get_env("GITHUB_APPLICATION_URL"),
5757
cookie_name: System.get_env("COOKIE_NAME"),
58-
branch_api_grpc_endpoint: System.get_env("BRANCH_GRPC_URL") || "127.0.0.1:50052",
5958
use_rbac_api: if(System.get_env("USE_RBAC_API") == "true", do: true, else: false)
6059

6160
on_prem? = if(System.get_env("ON_PREM") == "true", do: true, else: false)
6261

62+
# Internal API endpoints - always read from environment variables for all environments
63+
# Test environment will need these env vars set, or use stubs in test setup
64+
config :front,
65+
artifacthub_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_ARTIFACTHUB"),
66+
audit_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_AUDIT"),
67+
authentication_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_AUTHENTICATION"),
68+
billing_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_BILLING"),
69+
branch_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_BRANCH"),
70+
dashboard_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_DASHBOARDHUB"),
71+
feature_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_FEATURE"),
72+
guard_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_GUARD"),
73+
guard_user_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_USER"),
74+
hooks_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_HOOKS"),
75+
instance_config_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_INSTANCE_CONFIG"),
76+
job_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_JOB"),
77+
loghub2_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_LOGHUB2"),
78+
notification_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_NOTIFICATION"),
79+
okta_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_OKTA"),
80+
organization_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_ORGANIZATION"),
81+
periodic_scheduler_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_SCHEDULER"),
82+
pipeline_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_PLUMBER"),
83+
ppl_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_PLUMBER"),
84+
pre_flight_checks_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_PFC"),
85+
projecthub_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_PROJECT"),
86+
rbac_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_RBAC"),
87+
repo_proxy_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_REPO_PROXY"),
88+
repohub_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_REPOHUB"),
89+
repository_integrator_grpc_endpoint:
90+
System.fetch_env!("INTERNAL_API_URL_REPOSITORY_INTEGRATOR"),
91+
repositoryhub_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_REPOSITORY"),
92+
scouter_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_SCOUTER"),
93+
# sobelow_skip ["Config.Secrets"]
94+
secrets_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_SECRETHUB"),
95+
self_hosted_agents_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_SELFHOSTEDHUB"),
96+
superjerry_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_SUPERJERRY"),
97+
task_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_TASK"),
98+
velocity_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_VELOCITY"),
99+
workflow_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_PLUMBER"),
100+
jwt_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_SECRETHUB"),
101+
permission_patrol_grpc_endpoint: "127.0.0.1:50052"
102+
103+
config :front,
104+
license_grpc_endpoint: System.get_env("INTERNAL_API_URL_LICENSE_CHECKER"),
105+
gofer_grpc_endpoint: System.get_env("INTERNAL_API_URL_GOFER"),
106+
groups_grpc_endpoint: System.get_env("INTERNAL_API_URL_GROUPS"),
107+
loghub_api_grpc_endpoint: System.get_env("INTERNAL_API_URL_LOGHUB")
108+
63109
if config_env() == :prod do
64110
config :logger, level: (System.get_env("LOG_LEVEL") || "info") |> String.to_atom()
65111
config :front, docs_domain: System.get_env("DOCS_DOMAIN", "docs.semaphoreci.com")
@@ -75,51 +121,6 @@ if config_env() == :prod do
75121
config :front,
76122
support_app_id: System.get_env("HELPSCOUT_APP_ID"),
77123
support_app_secret: System.get_env("HELPSCOUT_APP_SECRET")
78-
79-
config :front,
80-
artifacthub_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_ARTIFACTHUB"),
81-
audit_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_AUDIT"),
82-
authentication_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_AUTHENTICATION"),
83-
billing_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_BILLING"),
84-
branch_api_grpc_endpoint: System.get_env("INTERNAL_API_URL_BRANCH"),
85-
dashboard_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_DASHBOARDHUB"),
86-
feature_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_FEATURE"),
87-
guard_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_GUARD"),
88-
guard_user_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_USER"),
89-
hooks_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_HOOKS"),
90-
instance_config_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_INSTANCE_CONFIG"),
91-
job_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_JOB"),
92-
loghub2_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_LOGHUB2"),
93-
notification_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_NOTIFICATION"),
94-
okta_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_OKTA"),
95-
organization_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_ORGANIZATION"),
96-
periodic_scheduler_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_SCHEDULER"),
97-
permission_patrol_grpc_endpoint: "127.0.0.1:50052",
98-
pipeline_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_PLUMBER"),
99-
ppl_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_PLUMBER"),
100-
pre_flight_checks_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_PFC"),
101-
projecthub_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_PROJECT"),
102-
rbac_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_RBAC"),
103-
repo_proxy_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_REPO_PROXY"),
104-
repohub_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_REPOHUB"),
105-
repository_integrator_grpc_endpoint:
106-
System.fetch_env!("INTERNAL_API_URL_REPOSITORY_INTEGRATOR"),
107-
repositoryhub_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_REPOSITORY"),
108-
scouter_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_SCOUTER"),
109-
# sobelow_skip ["Config.Secrets"]
110-
secrets_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_SECRETHUB"),
111-
self_hosted_agents_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_SELFHOSTEDHUB"),
112-
superjerry_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_SUPERJERRY"),
113-
task_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_TASK"),
114-
velocity_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_VELOCITY"),
115-
workflow_api_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_PLUMBER"),
116-
jwt_grpc_endpoint: System.fetch_env!("INTERNAL_API_URL_SECRETHUB"),
117-
license_grpc_endpoint: System.get_env("INTERNAL_API_URL_LICENSE", "license-checker:50051")
118-
119-
config :front,
120-
gofer_grpc_endpoint: System.get_env("INTERNAL_API_URL_GOFER"),
121-
groups_grpc_endpoint: System.get_env("INTERNAL_API_URL_GROUPS"),
122-
loghub_api_grpc_endpoint: System.get_env("INTERNAL_API_URL_LOGHUB")
123124
end
124125

125126
config :front,

front/config/test.exs

Lines changed: 1 addition & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -12,45 +12,7 @@ config :logger, :console,
1212
format: {Support.Logger, :format},
1313
metadata: [:file, :line, :inspect]
1414

15-
config :front,
16-
artifacthub_api_grpc_endpoint: "127.0.0.1:50052",
17-
audit_grpc_endpoint: "127.0.0.1:50052",
18-
authentication_grpc_endpoint: "127.0.0.1:50051",
19-
billing_api_grpc_endpoint: "127.0.0.1:50052",
20-
branch_api_grpc_endpoint: "127.0.0.1:50052",
21-
dashboard_api_grpc_endpoint: "127.0.0.1:50052",
22-
feature_grpc_endpoint: "127.0.0.1:50052",
23-
gofer_grpc_endpoint: "127.0.0.1:50052",
24-
guard_grpc_endpoint: "127.0.0.1:50052",
25-
guard_user_grpc_endpoint: "127.0.0.1:50052",
26-
instance_config_grpc_endpoint: "127.0.0.1:50052",
27-
job_api_grpc_endpoint: "127.0.0.1:50052",
28-
loghub_api_grpc_endpoint: "127.0.0.1:50051",
29-
notification_api_grpc_endpoint: "127.0.0.1:50052",
30-
okta_grpc_endpoint: "127.0.0.1:50052",
31-
organization_api_grpc_endpoint: "127.0.0.1:50052",
32-
periodic_scheduler_grpc_endpoint: "127.0.0.1:50052",
33-
permission_patrol_grpc_endpoint: "127.0.0.1:50052",
34-
pipeline_api_grpc_endpoint: "127.0.0.1:50052",
35-
ppl_grpc_endpoint: "127.0.0.1:50051",
36-
pre_flight_checks_grpc_endpoint: "127.0.0.1:50052",
37-
projecthub_grpc_endpoint: "127.0.0.1:50052",
38-
rbac_grpc_endpoint: "127.0.0.1:50052",
39-
groups_grpc_endpoint: "127.0.0.1:50052",
40-
repo_proxy_grpc_endpoint: "127.0.0.1:50051",
41-
repohub_grpc_endpoint: "127.0.0.1:50052",
42-
repository_integrator_grpc_endpoint: "127.0.0.1:50052",
43-
repositoryhub_grpc_endpoint: "127.0.0.1:50052",
44-
scouter_grpc_endpoint: "127.0.0.1:50052",
45-
secrets_api_grpc_endpoint: "127.0.0.1:50052",
46-
self_hosted_agents_grpc_endpoint: "127.0.0.1:50052",
47-
superjerry_grpc_endpoint: "127.0.0.1:50051",
48-
task_grpc_endpoint: "127.0.0.1:50052",
49-
usage_grpc_endpoint: "127.0.0.1:50052",
50-
velocity_grpc_endpoint: "127.0.0.1:50052",
51-
workflow_api_grpc_endpoint: "127.0.0.1:50052",
52-
jwt_grpc_endpoint: "127.0.0.1:50052",
53-
license_grpc_endpoint: "127.0.0.1:50052"
15+
# Internal API endpoints configuration removed - now handled in runtime.exs
5416

5517
config :front,
5618
domain: "semaphoretest.test",

front/docker-compose.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ services:
3434
SECRET_KEY_BASE: "keyboard-cat-please-use-this-only-for-dev-and-testing-it-is-insecure"
3535
SESSION_SIGNING_SALT: "keyboard-cat-please-use-this-only-for-dev-and-testing-it-is-insecure"
3636

37+
env_file:
38+
- ./env/.env.internal-apis
39+
3740
links:
3841
- redis-cache:redis-cache
3942
- rabbitmq:rabbitmq

front/env/.env.internal-apis

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
# Internal API URLs
2+
INTERNAL_API_URL_ARTIFACTHUB=127.0.0.1:50052
3+
INTERNAL_API_URL_AUDIT=127.0.0.1:50052
4+
INTERNAL_API_URL_AUTHENTICATION=127.0.0.1:50051
5+
INTERNAL_API_URL_BILLING=127.0.0.1:50052
6+
INTERNAL_API_URL_BRANCH=127.0.0.1:50052
7+
INTERNAL_API_URL_DASHBOARDHUB=127.0.0.1:50052
8+
INTERNAL_API_URL_FEATURE=127.0.0.1:50052
9+
INTERNAL_API_URL_GUARD=127.0.0.1:50052
10+
INTERNAL_API_URL_USER=127.0.0.1:50052
11+
INTERNAL_API_URL_HOOKS=127.0.0.1:50052
12+
INTERNAL_API_URL_INSTANCE_CONFIG=127.0.0.1:50052
13+
INTERNAL_API_URL_JOB=127.0.0.1:50052
14+
INTERNAL_API_URL_LOGHUB2=127.0.0.1:50051
15+
INTERNAL_API_URL_NOTIFICATION=127.0.0.1:50052
16+
INTERNAL_API_URL_OKTA=127.0.0.1:50052
17+
INTERNAL_API_URL_ORGANIZATION=127.0.0.1:50052
18+
INTERNAL_API_URL_SCHEDULER=127.0.0.1:50052
19+
INTERNAL_API_URL_PERMISSION_PATROL=127.0.0.1:50052
20+
INTERNAL_API_URL_PLUMBER=127.0.0.1:50052
21+
INTERNAL_API_URL_PFC=127.0.0.1:50052
22+
INTERNAL_API_URL_PROJECT=127.0.0.1:50052
23+
INTERNAL_API_URL_RBAC=127.0.0.1:50052
24+
INTERNAL_API_URL_REPO_PROXY=127.0.0.1:50051
25+
INTERNAL_API_URL_REPOHUB=127.0.0.1:50052
26+
INTERNAL_API_URL_REPOSITORY_INTEGRATOR=127.0.0.1:50052
27+
INTERNAL_API_URL_REPOSITORY=127.0.0.1:50052
28+
INTERNAL_API_URL_SCOUTER=127.0.0.1:50052
29+
INTERNAL_API_URL_SECRETHUB=127.0.0.1:50052
30+
INTERNAL_API_URL_SELFHOSTEDHUB=127.0.0.1:50052
31+
INTERNAL_API_URL_SUPERJERRY=127.0.0.1:50051
32+
INTERNAL_API_URL_TASK=127.0.0.1:50052
33+
INTERNAL_API_URL_VELOCITY=127.0.0.1:50052
34+
INTERNAL_API_URL_LICENSE=127.0.0.1:50052
35+
INTERNAL_API_URL_GOFER=127.0.0.1:50052
36+
INTERNAL_API_URL_GROUPS=127.0.0.1:50052
37+
INTERNAL_API_URL_LOGHUB=127.0.0.1:50051
38+
INTERNAL_API_URL_LICENSE_CHECKER=127.0.0.1:50052

front/helm/templates/job-page.yaml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ spec:
6565
securityContext:
6666
privileged: false
6767
allowPrivilegeEscalation: false
68-
readOnlyRootFilesystem: {{ not .Values.global.development.writableRootFilesystem | default true }}
68+
readOnlyRootFilesystem: {{ not .Values.global.development.writableRootFilesystem }}
6969
capabilities:
7070
drop:
7171
- ALL
@@ -154,11 +154,6 @@ spec:
154154
secretKeyRef:
155155
name: {{ .Values.global.redis.secretName }}
156156
key: port
157-
- name: BRANCH_GRPC_URL
158-
valueFrom:
159-
configMapKeyRef:
160-
name: {{ .Values.global.internalApi.configMapName }}
161-
key: INTERNAL_API_URL_BRANCH
162157

163158
startupProbe:
164159
httpGet:

front/helm/templates/project-page.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ spec:
9191
securityContext:
9292
privileged: false
9393
allowPrivilegeEscalation: false
94-
readOnlyRootFilesystem: {{ not .Values.global.development.writableRootFilesystem | default true }}
94+
readOnlyRootFilesystem: {{ not .Values.global.development.writableRootFilesystem }}
9595
capabilities:
9696
drop:
9797
- ALL

front/helm/templates/ui-cache-reactor.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ spec:
4545
securityContext:
4646
privileged: false
4747
allowPrivilegeEscalation: false
48-
readOnlyRootFilesystem: {{ not .Values.global.development.writableRootFilesystem | default true }}
48+
readOnlyRootFilesystem: {{ not .Values.global.development.writableRootFilesystem }}
4949
capabilities:
5050
drop:
5151
- ALL

0 commit comments

Comments
 (0)